Skip to content

Commit 4fdf6a7

Browse files
authored
🐛 [Connatix Player] - Fix player not unmuting while docking (#39792)
* fix player not being able to unmute while docking * volume fix
1 parent 4725f3b commit 4fdf6a7

1 file changed

Lines changed: 14 additions & 5 deletions

File tree

extensions/amp-connatix-player/0.1/amp-connatix-player.js

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,11 @@ import {
2828
getConsentPolicySharedData,
2929
getConsentPolicyState,
3030
} from '../../../src/consent';
31-
import {mutedOrUnmutedEvent, redispatch} from '../../../src/iframe-video';
31+
import {
32+
addUnsafeAllowAutoplay,
33+
mutedOrUnmutedEvent,
34+
redispatch,
35+
} from '../../../src/iframe-video';
3236
import {addParamsToUrl} from '../../../src/url';
3337
import {
3438
VideoEvents_Enum,
@@ -179,6 +183,14 @@ export class AmpConnatixPlayer extends AMP.BaseElement {
179183
this.isFullscreen_ = !this.isFullscreen_;
180184
break;
181185
}
186+
case 'cnxVolumeChanged': {
187+
const newVolume = dataJSON['args'];
188+
189+
this.muted_ = newVolume === 0;
190+
dispatchCustomEvent(this.element, mutedOrUnmutedEvent(this.muted_));
191+
192+
break;
193+
}
182194
}
183195

184196
redispatch(this.element, dataJSON['func'].toString(), {
@@ -321,6 +333,7 @@ export class AmpConnatixPlayer extends AMP.BaseElement {
321333

322334
// applyFillContent so that frame covers the entire component.
323335
applyFillContent(iframe, /* replacedContent */ true);
336+
addUnsafeAllowAutoplay(iframe);
324337

325338
// append child iframe for element
326339
element.appendChild(iframe);
@@ -432,15 +445,11 @@ export class AmpConnatixPlayer extends AMP.BaseElement {
432445

433446
/** @override */
434447
mute() {
435-
this.muted_ = true;
436-
dispatchCustomEvent(this.element, mutedOrUnmutedEvent(this.muted_));
437448
this.sendCommand_('mute');
438449
}
439450

440451
/** @override */
441452
unmute() {
442-
this.muted_ = false;
443-
dispatchCustomEvent(this.element, mutedOrUnmutedEvent(this.muted_));
444453
this.sendCommand_('unmute');
445454
}
446455

0 commit comments

Comments
 (0)