Annotations
4 warnings
|
usage of `Iterator::fold` on a type that implements `Try`:
src/channels.rs#L296
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/channels.rs:296:14
|
296 | .fold(Some(error), |error, channel| {
| ______________^
297 | | channel.init_recovery_or_shutdown(error)
298 | | });
| |______________^ help: use `try_fold` instead: `try_fold(error, |error, channel| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `-W clippy::manual-try-fold` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`
|
|
large size difference between variants:
/home/runner/work/lapin/lapin/target/debug/build/lapin-82bb434cb8b0500d/out/channel.rs#L150
warning: large size difference between variants
--> /home/runner/work/lapin/lapin/target/debug/build/lapin-82bb434cb8b0500d/out/channel.rs:150:1
|
150 | / pub(crate) enum Reply {
151 | | BasicQosOk(PromiseResolver<()>),
152 | | BasicConsumeOk(PromiseResolver<Consumer>, Option<Arc<ChannelCloser>>, ShortString, BasicConsumeOptions, FieldTable, Option<Consumer>),
| | -------------------------------------------------------------------------------------------------------------------------------------
| | |
| | the second-largest variant contains at least 228 bytes
153 | | BasicCancelOk(PromiseResolver<()>),
... |
156 | | ConnectionOpenOk(PromiseResolver<()>, Connection),
| | ------------------------------------------------- the largest variant contains at least 432 bytes
... |
175 | | ConfirmSelectOk(PromiseResolver<()>),
176 | | }
| |_^ the entire enum is at least 432 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `-W clippy::large-enum-variant` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::large_enum_variant)]`
help: consider boxing the large fields to reduce the total size of the enum
|
156 - ConnectionOpenOk(PromiseResolver<()>, Connection),
156 + ConnectionOpenOk(PromiseResolver<()>, Box<Connection>),
|
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/channels.rs#L296
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/channels.rs:296:14
|
296 | .fold(Some(error), |error, channel| {
| ______________^
297 | | channel.init_recovery_or_shutdown(error)
298 | | });
| |______________^ help: use `try_fold` instead: `try_fold(error, |error, channel| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `-W clippy::manual-try-fold` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`
|
|
large size difference between variants:
/home/runner/work/lapin/lapin/target/debug/build/lapin-82bb434cb8b0500d/out/channel.rs#L150
warning: large size difference between variants
--> /home/runner/work/lapin/lapin/target/debug/build/lapin-82bb434cb8b0500d/out/channel.rs:150:1
|
150 | / pub(crate) enum Reply {
151 | | BasicQosOk(PromiseResolver<()>),
152 | | BasicConsumeOk(PromiseResolver<Consumer>, Option<Arc<ChannelCloser>>, ShortString, BasicConsumeOptions, FieldTable, Option<Consumer>),
| | -------------------------------------------------------------------------------------------------------------------------------------
| | |
| | the second-largest variant contains at least 228 bytes
153 | | BasicCancelOk(PromiseResolver<()>),
... |
156 | | ConnectionOpenOk(PromiseResolver<()>, Connection),
| | ------------------------------------------------- the largest variant contains at least 432 bytes
... |
175 | | ConfirmSelectOk(PromiseResolver<()>),
176 | | }
| |_^ the entire enum is at least 432 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `-W clippy::large-enum-variant` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::large_enum_variant)]`
help: consider boxing the large fields to reduce the total size of the enum
|
156 - ConnectionOpenOk(PromiseResolver<()>, Connection),
156 + ConnectionOpenOk(PromiseResolver<()>, Box<Connection>),
|
|