Skip to content

Commit d9b9b9b

Browse files
committed
Move to #50.
Signed-off-by: Jackson Goerner <[email protected]>
1 parent 1f05f0d commit d9b9b9b

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
- Feature Name: extended_search_filters
22
- Start Date: 2025-01-06
3-
- RFC PR: [amundsen-io/rfcs#0000](https://github.com/amundsen-io/rfcs/pull/0000) (after opening the RFC PR, update this with a link to it and update the file name)
3+
- RFC PR: [amundsen-io/rfcs#50](https://github.com/amundsen-io/rfcs/pull/50)
44
- Amundsen Issue: [amundsen-io/amundsen#0000](https://github.com/amundsen-io/amundsen/issues/0000) (leave this empty for now)
55

66
# Extended Search Filters
@@ -37,7 +37,7 @@ Two of these filters focused on removing friction between your users and the sea
3737

3838
The radio select will render multiple options of your choosing, allowed you to select/deselect these options, and have the page automatically rerender the search results based on these options. For example, suppose we've got many tables in our system, but these all live in a few main database locations, then a radio select is probably the correct filter category to use:
3939

40-
![Example of radio filter](/assets/000/radio-example.png)
40+
![Example of radio filter](/assets/050/radio-example.png)
4141

4242
Radio selects can support multiple selections, or just a single selection at a time. The options rendered is also completely configurable, and can show an icon alongside the option. If you'd like to provide an option for 'everything else' that will simply match anything not covered by the visible options, you can include that too (This is the 'Other' option in the image above).
4343

@@ -47,14 +47,14 @@ The dropdown select will render a searchable dropdown which users can type into
4747

4848
For example, suppose we've got about 300 schemas in our system, which is too much for a radio button scheme, but not enough to warrant avoiding a better experience than freetext entirely. We can show the schemas in a searchable dropdown, allowing the users to see all schemas available.
4949

50-
![Example of Dropdown search filter](/assets/000/search-example.png)
50+
![Example of Dropdown search filter](/assets/050/search-example.png)
5151

5252
This could also rerender the search options based on the database filter values mentioned above! So when the snowflake checkbox isn't checked, snowflake schemas would not be shown in the dropdown.
5353

5454
One more example of dynamic rendering for search is in table tags. Users might have tagged resources with a `KEY=VALUE` format, so `my_schema.my_table` might have tags `ETL_OWNER=hsimpson`, `YEAR_INTRODUCED=2022`, etc. In order to adequately filter by this in our search page, you might have two dropdowns; One for selecting the tag key, and another for selecting the tag value.
5555

56-
![Example of tag key options](/assets/000/tag-key.png)
57-
![Example of tag value options](/assets/000/tag-value.png)
56+
![Example of tag key options](/assets/050/tag-key.png)
57+
![Example of tag value options](/assets/050/tag-value.png)
5858

5959
The tag value dropdown can then render it's search options based on the option selected for tag key.
6060

@@ -173,7 +173,7 @@ Both of these, while powerful, are less intuitive for users and less controlled
173173

174174
This radio select feature is present in acryl/datahub:
175175

176-
![Example of search view in Acryl](/assets/000/acryl-filter.png)
176+
![Example of search view in Acryl](/assets/050/acryl-filter.png)
177177

178178
Although I am not involved with other data communites and am unaware of the opinions / experiences of them.
179179

0 commit comments

Comments
 (0)