Change !!err to err != null

Author: amychisholm03

lib/subscribers/openai/chat.js

@@ -153,7 +153,7 @@ class OpenAIChatCompletions extends AiMonitoringChatSubscriber {
     }
   }
 
-  createCompletionSummary({ ctx, request, response = {}, err }) {
+  createCompletionSummary({ ctx, request, response = {}, err = null }) {
     const { transaction, segment } = ctx
     const headers = ctx?.extras?.headers || {}
     const summary = new LlmChatCompletionSummary({
@@ -162,7 +162,7 @@ class OpenAIChatCompletions extends AiMonitoringChatSubscriber {
       transaction,
       request,
       response: { ...response, headers },
-      error: !!err
+      error: err !== null
     })
     return summary
   }

lib/subscribers/openai/embeddings.js

@@ -20,7 +20,7 @@ class OpenAIEmbeddings extends AiMonitoringEmbeddingSubscriber {
     wrapPromise.call(this, data)
   }
 
-  createEmbedding({ ctx, request, response = {}, err }) {
+  createEmbedding({ ctx, request, response = {}, err = null }) {
     const { transaction, segment } = ctx
     const headers = ctx?.extras?.headers || {}
     return new LlmEmbedding({
@@ -29,7 +29,7 @@ class OpenAIEmbeddings extends AiMonitoringEmbeddingSubscriber {
       transaction,
       request,
       response: { ...response, headers },
-      error: !!err
+      error: err !== null
     })
   }