summary test passing

Author: amychisholm03

lib/llm-events/google-genai/embedding.js

@@ -28,7 +28,7 @@ class LlmEmbedding extends LlmEvent {
       : undefined
     this.error = params.isError
     this.duration = params.segment.getDurationInMillis()
-    // TODO: idk if this is correct for token count
+    // TODO: use token callback function? see Python agent work
     this.token_count = Array.isArray(params.response?.embeddings)
       ? params.response.embeddings.reduce((sum, e) => sum + (e?.values?.length || 0), 0)
       : undefined

lib/llm-events/google-genai/event.js

@@ -14,7 +14,7 @@ module.exports = class LlmEvent extends BaseEvent {
 
     this.id = makeId(36)
     this.appName = agent.config.applications()[0]
-    this.request_id = response?.headers?.['x-request-id'] // TODO: what is this in Gemini?
+    // this.request_id = response?.headers?.['x-request-id'] // TODO: what is this in Gemini?
     this.trace_id = transaction?.traceId
     this.span_id = segment?.id
     this['response.model'] = response?.modelVersion
@@ -23,30 +23,11 @@ module.exports = class LlmEvent extends BaseEvent {
     this.ingest_source = 'Node'
     this.metadata = agent
 
-    /**
-     * Used in embedding, and chat completion summary.
-     * The flag will include response attributes but also
-     * other attributes from request like model, and api key.
-     * Lastly, it includes the active span's duration.
-     */
+    // TODO: no valid response.headers found in Gemini?
     if (responseAttrs) {
       this.duration = segment?.getDurationInMillis()
-      this.responseAttrs(response)
+      // relevant headers will be prefixed with 'x-goog'?
+      // this.responseAttrs(response)
     }
   }
-
-  responseAttrs(response) {
-    // TODO: no response.headers?
-    // relevant headers will be prefixed with 'x-goog'?
-    this['response.organization'] = response?.headers?.['google-organization']
-    this['response.headers.llmVersion'] = response?.headers?.['gemini-version']
-    this['response.headers.ratelimitLimitRequests'] =
-      response?.headers?.['x-ratelimit-limit-requests']
-    this['response.headers.ratelimitLimitTokens'] = response?.headers?.['x-ratelimit-limit-tokens']
-    this['response.headers.ratelimitResetTokens'] = response?.headers?.['x-ratelimit-reset-tokens']
-    this['response.headers.ratelimitRemainingTokens'] =
-      response?.headers?.['x-ratelimit-remaining-tokens']
-    this['response.headers.ratelimitRemainingRequests'] =
-      response?.headers?.['x-ratelimit-remaining-requests']
-  }
 }

test/unit/llm-events/google-genai/chat-completion-summary.test.js

@@ -32,7 +32,7 @@ test('should properly create a LlmChatCompletionSummary event', (t, end) => {
         segment,
         transaction: tx,
         request: req,
-        response: res // TODO: res is different
+        response: res
       })
       const expected = getExpectedResult(tx, chatSummaryEvent, 'summary')
       assert.deepEqual(chatSummaryEvent, expected)

test/unit/llm-events/google-genai/common.js

@@ -5,8 +5,23 @@
 
 'use strict'
 const res = {
-  model: 'gemini-2.0-flash',
-  choices: [{ finish_reason: 'stop', message: { content: 'a lot', role: 'know-it-all' } }]
+  modelVersion: 'gemini-2.0-flash',
+  candidates: [
+    {
+      content: {
+        parts: [
+          { text: "I don't know!" }
+        ],
+        role: 'model'
+      },
+      finishReason: 'STOP'
+    }
+  ],
+  usageMetadata: {
+    promptTokenCount: 10,
+    candidatesTokenCount: 20,
+    totalTokenCount: 30
+  }
 }
 
 const req = {
@@ -29,20 +44,14 @@ function getExpectedResult(tx, event, type, completionId) {
     appName: 'New Relic for Node.js tests',
     trace_id: tx.traceId,
     span_id: spanId,
-    'response.model': 'gemini-2.0-flash',
+    'request.model': 'gemini-2.0-flash',
     vendor: 'gemini',
     ingest_source: 'Node'
   }
   const resKeys = {
     duration: child.getDurationInMillis(),
-    'request.model': 'gemini-2.0-flash',
-    'response.organization': 'new-relic',
-    'response.headers.llmVersion': '1.0.0',
-    'response.headers.ratelimitLimitRequests': '100',
-    'response.headers.ratelimitLimitTokens': '100',
-    'response.headers.ratelimitResetTokens': '100',
-    'response.headers.ratelimitRemainingTokens': '10',
-    'response.headers.ratelimitRemainingRequests': '10'
+    'response.model': 'gemini-2.0-flash',
+    // TODO: response.headers?
   }
 
   switch (type) {
@@ -56,10 +65,10 @@ function getExpectedResult(tx, event, type, completionId) {
       expected = {
         ...expected,
         ...resKeys,
-        'request.max_tokens': '1000000',
-        'request.temperature': '1.0',
-        'response.number_of_messages': 3,
-        'response.choices.finish_reason': 'stop',
+        'request.max_tokens': 1000000,
+        'request.temperature': 1.0,
+        'response.number_of_messages': 2,
+        'response.choices.finish_reason': 'STOP',
         error: false
       }
       break