test: Updated tests to mock outgoing calls to avoid issues in CI (newrelic#3234)

Author: bizob2828

test/integration/instrumentation/http-outbound.test.js

@@ -9,6 +9,7 @@ const helper = require('../../lib/agent_helper')
 const test = require('node:test')
 const assert = require('node:assert')
 const symbols = require('../../../lib/symbols')
+const nock = require('nock')
 
 test('external requests', async function (t) {
   t.beforeEach((ctx) => {
@@ -159,42 +160,15 @@ test('external requests', async function (t) {
     })
   })
 
-  await t.test('should not duplicate the external segment', function (t, end) {
-    const { agent } = t.nr
-    const https = require('https')
-
-    helper.runInTransaction(agent, function inTransaction() {
-      https.get('https://example.com:443/', function onResponse(res) {
-        res.once('end', check)
-        res.resume()
-      })
-    })
-
-    function check() {
-      const tx = agent.getTransaction()
-      const [segment] = tx.trace.getChildren(tx.trace.root.id)
-
-      assert.equal(segment.name, 'External/example.com/', 'should be named')
-      assert.ok(segment.timer.start, 'should have started')
-      assert.ok(segment.timer.hasEnd(), 'should have ended')
-      const segmentChildren = tx.trace.getChildren(segment.id)
-      assert.equal(segmentChildren.length, 1, 'should have 1 child')
-
-      const notDuped = segmentChildren[0]
-      assert.notEqual(
-        notDuped.name,
-        segment.name,
-        'child should not be named the same as the external segment'
-      )
-
-      end()
-    }
-  })
-
   await t.test('NODE-1647 should not interfere with `got`', { timeout: 5000 }, function (t, end) {
     const { agent } = t.nr
     // Our way of wrapping HTTP response objects caused `got` to hang. This was
     // resolved in agent 2.5.1.
+    nock.disableNetConnect()
+    t.after(() => {
+      nock.enableNetConnect()
+    })
+    nock('https://example.com').get('/').reply(200)
     const got = require('got')
     helper.runInTransaction(agent, function () {
       const req = got('https://example.com/')
@@ -215,8 +189,13 @@ test('external requests', async function (t) {
 
   await t.test('should record requests to default ports', (t, end) => {
     const { agent, http } = t.nr
+    nock.disableNetConnect()
+    t.after(() => {
+      nock.enableNetConnect()
+    })
+    nock('http://example.com').get('/').reply(200)
     helper.runInTransaction(agent, (tx) => {
-      http.get('http://example.com', (res) => {
+      http.get('http://example.com/', (res) => {
         res.resume()
         res.on('end', () => {
           const [segment] = tx.trace.getChildren(tx.trace.root.id)
@@ -229,9 +208,14 @@ test('external requests', async function (t) {
 
   await t.test('should expose the external segment on the http request', (t, end) => {
     const { agent, http } = t.nr
+    nock.disableNetConnect()
+    t.after(() => {
+      nock.enableNetConnect()
+    })
+    nock('http://example.com').get('/').reply(200)
     helper.runInTransaction(agent, (tx) => {
       let reqSegment = null
-      const req = http.get('http://example.com', (res) => {
+      const req = http.get('http://example.com/', (res) => {
         res.resume()
         res.on('end', () => {
           const [segment] = tx.trace.getChildren(tx.trace.root.id)

test/unit/spans/span-event.test.js

@@ -8,10 +8,11 @@ const assert = require('node:assert')
 const test = require('node:test')
 const DatastoreShim = require('../../../lib/shim/datastore-shim')
 const helper = require('../../lib/agent_helper')
-const https = require('https')
+const http = require('http')
 const SpanEvent = require('../../../lib/spans/span-event')
 const DatastoreParameters = require('../../../lib/shim/specs/params/datastore')
 const { QuerySpec } = require('../../../lib/shim/specs')
+const nock = require('nock')
 
 test('#constructor() should construct an empty span event', () => {
   const attrs = {}
@@ -43,6 +44,7 @@ test('#constructor() should construct an empty span event', () => {
 
 test('fromSegment()', async (t) => {
   t.beforeEach((ctx) => {
+    nock.disableNetConnect()
     ctx.nr = {}
     ctx.nr.agent = helper.instrumentMockedAgent({
       distributed_tracing: {
@@ -52,6 +54,7 @@ test('fromSegment()', async (t) => {
   })
 
   t.afterEach((ctx) => {
+    nock.enableNetConnect()
     helper.unloadAgent(ctx.nr.agent)
   })
 
@@ -132,8 +135,9 @@ test('fromSegment()', async (t) => {
     helper.runInTransaction(agent, (transaction) => {
       transaction.sampled = true
       transaction.priority = 42
+      nock('http://example.com').get('/?foo=bar').reply(200)
 
-      https.get('https://example.com?foo=bar', (res) => {
+      http.get('http://example.com?foo=bar', (res) => {
         res.resume()
         res.on('end', () => {
           const tx = agent.tracer.getTransaction()
@@ -159,7 +163,7 @@ test('fromSegment()', async (t) => {
           assert.equal(span.intrinsics.name, 'External/example.com/')
           assert.equal(span.intrinsics.timestamp, segment.timer.start)
 
-          assert.ok(span.intrinsics.duration >= 0.01 && span.intrinsics.duration <= 2)
+          assert.ok(span.intrinsics.duration > 0 && span.intrinsics.duration <= 2)
 
           // Should have type-specific intrinsics
           assert.equal(span.intrinsics.component, 'http')
@@ -169,13 +173,12 @@ test('fromSegment()', async (t) => {
           const attributes = span.attributes
 
           // Should have (most) http properties.
-          assert.equal(attributes['http.url'], 'https://example.com/')
+          assert.equal(attributes['http.url'], 'http://example.com/')
           assert.equal(attributes['server.address'], 'example.com')
-          assert.equal(attributes['server.port'], 443)
+          assert.equal(attributes['server.port'], 80)
           assert.ok(attributes['http.method'])
           assert.ok(attributes['http.request.method'])
           assert.equal(attributes['http.statusCode'], 200)
-          assert.equal(attributes['http.statusText'], 'OK')
 
           // should nullify mapped properties
           assert.ok(!attributes.library)
@@ -353,8 +356,9 @@ test('fromSegment()', async (t) => {
 
   await t.test('should handle truncated http spans', (t, end) => {
     const { agent } = t.nr
+    nock('http://www.example.com').get('/path?foo=bar').reply(200)
     helper.runInTransaction(agent, (transaction) => {
-      https.get('https://example.com?foo=bar', (res) => {
+      http.get('http://www.example.com/path?foo=bar', (res) => {
         transaction.end() // prematurely end to truncate
 
         res.resume()