test: Fixed fastify segment tree assertion when security agent is enabled (newrelic#3422)

Author: bizob2828

test/versioned/fastify/add-hook.test.js

@@ -95,11 +95,9 @@ test('non-error hooks', async (t) => {
         'WebTransaction/WebFrameworkUri/Fastify/GET//add-hook',
         [
           'Nodejs/Middleware/Fastify/onRequest/<anonymous>',
-          [
-            ...getExpectedSegments(REQUEST_HOOKS),
-            'Nodejs/Middleware/Fastify/routeHandler//add-hook',
-            getExpectedSegments(AFTER_HANDLER_HOOKS)
-          ]
+          ...getExpectedSegments(REQUEST_HOOKS),
+          'Nodejs/Middleware/Fastify/routeHandler//add-hook',
+          getExpectedSegments(AFTER_HANDLER_HOOKS)
         ]
       ]
     } else {
@@ -155,10 +153,8 @@ test('error hook', async function errorHookTest(t) {
         'WebTransaction/WebFrameworkUri/Fastify/GET//error',
         [
           'Nodejs/Middleware/Fastify/onRequest/<anonymous>',
-          [
-            'Nodejs/Middleware/Fastify/errorRoute//error',
-            `Nodejs/Middleware/Fastify/${hookName}/testHook`
-          ]
+          'Nodejs/Middleware/Fastify/errorRoute//error',
+          `Nodejs/Middleware/Fastify/${hookName}/testHook`
         ]
       ]
     } else {

test/versioned/fastify/code-level-metrics-hooks.test.js

@@ -46,8 +46,9 @@ async function performTest(t) {
     const [baseSegment] = transaction.trace.getChildren(transaction.trace.root.id)
     let [onRequestSegment, handlerSegment] = transaction.trace.getChildren(baseSegment.id)
     if (helper.isSecurityAgentEnabled(agent)) {
-      ;[onRequestSegment, handlerSegment] = transaction.trace.getChildren(onRequestSegment.id)
+      ;[, onRequestSegment, handlerSegment] = transaction.trace.getChildren(baseSegment.id)
     }
+
     const [onSendSegment] = transaction.trace.getChildren(handlerSegment.id)
     assertCLMAttrs({
       segments: [

test/versioned/fastify/code-level-metrics-middleware.test.js

@@ -49,11 +49,11 @@ async function setup(t, config) {
 
 function assertSegments({ t, trace, baseSegment, isCLMEnabled }) {
   const { agent } = t.nr
-  let children = trace.getChildren(baseSegment.id)
+  const children = trace.getChildren(baseSegment.id)
+  let [middieSegment, handlerSegment] = children
   if (helper.isSecurityAgentEnabled(agent)) {
-    children = trace.getChildren(children[0].id)
+    ;[, middieSegment, handlerSegment] = children
   }
-  const [middieSegment, handlerSegment] = children
   assertCLMAttrs({
     segments: [
       {

test/versioned/fastify/naming-common.js

@@ -34,7 +34,7 @@ module.exports = async function runTests(t, getExpectedSegments) {
           // it sometimes has timers.setTimeout depending on route
           expectedSegments = [
             `WebTransaction/WebFrameworkUri/Fastify/GET/${uri}`,
-            ['Nodejs/Middleware/Fastify/onRequest/<anonymous>', getExpectedSegments(uri)]
+            ['Nodejs/Middleware/Fastify/onRequest/<anonymous>', ...getExpectedSegments(uri)]
           ]
         } else {
           expectedSegments = [