Skip to content

Commit d650238

Browse files
amychisholm03amychisholm03
committed
lint issues
1 parent 984148e commit d650238

File tree

1 file changed

+59
-64
lines changed

1 file changed

+59
-64
lines changed

‎test/unit/serverless/aws-lambda-streamified.test.js‎

Lines changed: 59 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
const test = require('node:test')
99
const assert = require('node:assert')
1010
const os = require('node:os')
11-
const { Writable } = require('node:stream');
11+
const { Writable } = require('node:stream')
1212

1313
const { tspl } = require('@matteo.collina/tspl')
1414
const helper = require('../../lib/agent_helper')
@@ -273,8 +273,6 @@ test('AwsLambda.patchLambdaHandler', async (t) => {
273273

274274
assert.ok(headers.traceparent)
275275
assert.ok(headers.tracestate)
276-
277-
callback(null, validResponse)
278276
})
279277

280278
const wrappedHandler = awsLambda.patchLambdaHandler(handler)
@@ -437,7 +435,7 @@ test('AwsLambda.patchLambdaHandler', async (t) => {
437435
}
438436
})
439437

440-
/// TODO: make sure the agent can capture HTTP statusCode from the stream metadata.
438+
/// TODO: make sure the agent can capture HTTP statusCode from the stream metadata.
441439
// await t.test('should capture status code', (t, end) => {
442440
// const { agent, awsLambda, stubResponseStream, stubContext } = t.nr
443441
// agent.on('transactionFinished', confirmAgentAttribute)
@@ -541,7 +539,7 @@ test('AwsLambda.patchLambdaHandler', async (t) => {
541539
const chunks = ['no headers 1', 'no headers 2', 'no headers 3']
542540
await writeStreamResponse(chunks, responseStream, 500)
543541
responseStream.end()
544-
});
542+
})
545543

546544
const wrappedHandler = awsLambda.patchLambdaHandler(handler)
547545

@@ -1190,79 +1188,79 @@ test('AwsLambda.patchLambdaHandler', async (t) => {
11901188
}
11911189
})
11921190

1193-
await t.test('when callback used', async (t) => {
1194-
helper.unloadAgent(t.nr.agent)
1191+
// await t.test('when callback used', async (t) => {
1192+
// helper.unloadAgent(t.nr.agent)
11951193

1196-
await t.test('should end appropriately', (t, end) => {
1197-
const { agent, awsLambda, stubEvent, stubContext } = t.nr
1198-
let transaction
1194+
// await t.test('should end appropriately', (t, end) => {
1195+
// const { agent, awsLambda, stubEvent, stubContext } = t.nr
1196+
// let transaction
11991197

1200-
const handler = lambdaBuiltIns.streamifyResponse(async (event, responseStream, context) => {
1201-
transaction = agent.tracer.getTransaction()
1202-
callback(null, 'worked')
1203-
})
1198+
// const handler = lambdaBuiltIns.streamifyResponse(async (event, responseStream, context) => {
1199+
// transaction = agent.tracer.getTransaction()
1200+
// callback(null, 'worked')
1201+
// })
12041202

1205-
const wrappedHandler = awsLambda.patchLambdaHandler(handler)
1203+
// const wrappedHandler = awsLambda.patchLambdaHandler(handler)
12061204

1207-
wrappedHandler(stubEvent, stubContext, function confirmEndCallback() {
1208-
assert.equal(transaction.isActive(), false)
1205+
// wrappedHandler(stubEvent, stubContext, function confirmEndCallback() {
1206+
// assert.equal(transaction.isActive(), false)
12091207

1210-
const currentTransaction = agent.tracer.getTransaction()
1211-
assert.equal(currentTransaction, null)
1212-
end()
1213-
})
1214-
})
1208+
// const currentTransaction = agent.tracer.getTransaction()
1209+
// assert.equal(currentTransaction, null)
1210+
// end()
1211+
// })
1212+
// })
12151213

1216-
await t.test('should notice errors', (t, end) => {
1217-
const { agent, awsLambda, error, stubEvent, stubResponseStream, stubContext } = t.nr
1218-
agent.on('harvestStarted', confirmErrorCapture)
1214+
// await t.test('should notice errors', (t, end) => {
1215+
// const { agent, awsLambda, error, stubEvent, stubResponseStream, stubContext } = t.nr
1216+
// agent.on('harvestStarted', confirmErrorCapture)
12191217

1220-
const handler = lambdaBuiltIns.streamifyResponse(async (event, responseStream, context) => {
1221-
callback(error, 'failed')
1222-
})
1218+
// const handler = lambdaBuiltIns.streamifyResponse(async (event, responseStream, context) => {
1219+
// callback(error, 'failed')
1220+
// })
12231221

1224-
const wrappedHandler = awsLambda.patchLambdaHandler(handler)
1222+
// const wrappedHandler = awsLambda.patchLambdaHandler(handler)
12251223

1226-
wrappedHandler(stubEvent, stubResponseStream, stubContext)
1224+
// wrappedHandler(stubEvent, stubResponseStream, stubContext)
12271225

1228-
function confirmErrorCapture() {
1229-
assert.equal(agent.errors.traceAggregator.errors.length, 1)
1230-
const noticedError = agent.errors.traceAggregator.errors[0]
1231-
assert.equal(noticedError[1], expectedBgTransactionName)
1232-
assert.equal(noticedError[2], errorMessage)
1233-
assert.equal(noticedError[3], 'SyntaxError')
1234-
}
1226+
// function confirmErrorCapture() {
1227+
// assert.equal(agent.errors.traceAggregator.errors.length, 1)
1228+
// const noticedError = agent.errors.traceAggregator.errors[0]
1229+
// assert.equal(noticedError[1], expectedBgTransactionName)
1230+
// assert.equal(noticedError[2], errorMessage)
1231+
// assert.equal(noticedError[3], 'SyntaxError')
1232+
// }
12351233

1236-
end()
1237-
})
1234+
// end()
1235+
// })
12381236

1239-
await t.test('should notice string errors', (t, end) => {
1240-
const { agent, awsLambda, stubEvent, stubResponseStream, stubContext } = t.nr
1241-
agent.on('harvestStarted', confirmErrorCapture)
1237+
// await t.test('should notice string errors', (t, end) => {
1238+
// const { agent, awsLambda, stubEvent, stubResponseStream, stubContext } = t.nr
1239+
// agent.on('harvestStarted', confirmErrorCapture)
12421240

1243-
const handler = lambdaBuiltIns.streamifyResponse(async (event, responseStream, context) => {
1244-
// eslint-disable-next-line n/no-callback-literal
1245-
callback('failed')
1246-
})
1241+
// const handler = lambdaBuiltIns.streamifyResponse(async (event, responseStream, context) => {
1242+
// // eslint-disable-next-line n/no-callback-literal
1243+
// callback('failed')
1244+
// })
12471245

1248-
const wrappedHandler = awsLambda.patchLambdaHandler(handler)
1246+
// const wrappedHandler = awsLambda.patchLambdaHandler(handler)
12491247

1250-
wrappedHandler(stubEvent, stubResponseStream, stubContext)
1248+
// wrappedHandler(stubEvent, stubResponseStream, stubContext)
12511249

1252-
function confirmErrorCapture() {
1253-
assert.equal(agent.errors.traceAggregator.errors.length, 1)
1254-
const noticedError = agent.errors.traceAggregator.errors[0]
1255-
assert.equal(noticedError[1], expectedBgTransactionName)
1256-
assert.equal(noticedError[2], 'failed')
1257-
assert.equal(noticedError[3], 'Error')
1250+
// function confirmErrorCapture() {
1251+
// assert.equal(agent.errors.traceAggregator.errors.length, 1)
1252+
// const noticedError = agent.errors.traceAggregator.errors[0]
1253+
// assert.equal(noticedError[1], expectedBgTransactionName)
1254+
// assert.equal(noticedError[2], 'failed')
1255+
// assert.equal(noticedError[3], 'Error')
12581256

1259-
const data = noticedError[4]
1260-
assert.ok(data.stack_trace)
1261-
}
1257+
// const data = noticedError[4]
1258+
// assert.ok(data.stack_trace)
1259+
// }
12621260

1263-
end()
1264-
})
1265-
})
1261+
// end()
1262+
// })
1263+
// })
12661264

12671265
await test('when context.done used', async (t) => {
12681266
helper.unloadAgent(t.nr.agent)
@@ -1328,7 +1326,7 @@ test('AwsLambda.patchLambdaHandler', async (t) => {
13281326
})
13291327

13301328
const handler = lambdaBuiltIns.streamifyResponse(async (event, responseStream, context) => {
1331-
context.done(error, 'failed')
1329+
context.done('failed')
13321330
})
13331331

13341332
const wrappedHandler = awsLambda.patchLambdaHandler(handler)
@@ -1387,7 +1385,6 @@ test('AwsLambda.patchLambdaHandler', async (t) => {
13871385
context.fail()
13881386
})
13891387

1390-
13911388
wrappedHandler(stubEvent, stubResponseStream, stubContext)
13921389
})
13931390

@@ -1694,8 +1691,6 @@ test('AwsLambda.patchLambdaHandler', async (t) => {
16941691
assert.equal(transaction.getFullName(), expectedBgTransactionName)
16951692
assert.ok(transaction.isActive())
16961693

1697-
cb()
1698-
16991694
assert.equal(transaction.isActive(), false)
17001695
return resolve('hello')
17011696
})

0 commit comments

Comments
 (0)