cleanup unit tests

Author: amychisholm03

test/unit/instrumentation/@google/genai.test.js

@@ -6,8 +6,8 @@
 'use strict'
 const test = require('node:test')
 const assert = require('node:assert')
-const helper = require('../../../lib/agent_helper')
-const GenericShim = require('../../../../lib/shim/shim')
+const helper = require('#testlib/agent_helper.js')
+const GenericShim = require('#agentlib/shim/shim.js')
 const sinon = require('sinon')
 
 test('@google/genai unit tests', async (t) => {

test/unit/llm-events/google-genai/chat-completion-message.test.js

@@ -7,8 +7,8 @@
 
 const test = require('node:test')
 const assert = require('node:assert')
-const LlmChatCompletionMessage = require('../../../../lib/llm-events/google-genai/chat-completion-message')
-const helper = require('../../../lib/agent_helper')
+const LlmChatCompletionMessage = require('#agentlib/llm-events/google-genai/chat-completion-message.js')
+const helper = require('#testlib/agent_helper.js')
 const { req, res, getExpectedResult } = require('./common')
 
 test.beforeEach((ctx) => {
@@ -200,7 +200,7 @@ test('should not set token_count if not set in usage nor a callback registered r
   const { agent } = t.nr
   const api = helper.getAgentApi()
   function cb() {
-    // empty cb
+    // no-op so we don't return a token count
   }
   api.setLlmTokenCountCallback(cb)
   helper.runInTransaction(agent, (tx) => {

test/unit/llm-events/google-genai/chat-completion-summary.test.js

@@ -7,8 +7,8 @@
 
 const test = require('node:test')
 const assert = require('node:assert')
-const LlmChatCompletionSummary = require('../../../../lib/llm-events/google-genai/chat-completion-summary')
-const helper = require('../../../lib/agent_helper')
+const LlmChatCompletionSummary = require('#agentlib/llm-events/google-genai/chat-completion-summary.js')
+const helper = require('#testlib/agent_helper.js')
 const { req, res, getExpectedResult } = require('./common')
 
 test.beforeEach((ctx) => {

test/unit/llm-events/google-genai/embedding.test.js

@@ -7,8 +7,8 @@
 
 const test = require('node:test')
 const assert = require('node:assert')
-const LlmEmbedding = require('../../../../lib/llm-events/google-genai/embedding')
-const helper = require('../../../lib/agent_helper')
+const LlmEmbedding = require('#agentlib/llm-events/google-genai/embedding.js')
+const helper = require('#testlib/agent_helper.js')
 const { res, getExpectedResult } = require('./common')
 
 test.beforeEach((ctx) => {
@@ -45,7 +45,8 @@ test('should properly create a LlmEmbedding event', (t, end) => {
     })
   })
 })
-;[
+
+const serializeTestCases = [
   { type: 'string', value: 'test contents', expected: 'test contents' },
   {
     type: 'array of strings',
@@ -62,20 +63,21 @@ test('should properly create a LlmEmbedding event', (t, end) => {
     ],
     expected: '1,2,3,4,5,6'
   }
-].forEach(({ type, value, expected }) => {
-  test(`should properly serialize contents when it is a ${type}`, (t, end) => {
+]
+for (const testCase of serializeTestCases) {
+  test(`should properly serialize contents when it is a ${testCase.type}`, (t, end) => {
     const { agent } = t.nr
     const embeddingEvent = new LlmEmbedding({
       agent,
       segment: null,
       transaction: null,
-      request: { contents: value },
+      request: { contents: testCase.value },
       response: {}
     })
-    assert.equal(embeddingEvent.input, expected)
+    assert.equal(embeddingEvent.input, testCase.expected)
     end()
   })
-})
+}
 
 test('should set error to true', (t, end) => {
   const { agent } = t.nr