bug fix: generate directory if path not exist in compile_mmap_model (#281)

Generate directory if path not exist in compile_mmap_model when saving a XLinearModel.

Co-authored-by: jianhao peng <jianhaop@amazon.com>

Author: jianhao2016

pecos/xmc/xlinear/model.py

@@ -95,8 +95,8 @@ def save(self, model_folder):
         Args:
             model_folder (str): dir to save the model
         """
-        if not path.exists(model_folder):
-            os.makedirs(model_folder)
+
+        os.makedirs(model_folder, exist_ok=True)
         param = self.append_meta({})
         with open(f"{model_folder}/param.json", "w", encoding="utf-8") as fout:
             fout.write(json.dumps(param, indent=True))
@@ -144,6 +144,7 @@ def compile_mmap_model(cls, npz_folder, mmap_folder):
         """
         import shutil
 
+        os.makedirs(mmap_folder, exist_ok=True)
         shutil.copyfile(path.join(npz_folder, "param.json"), path.join(mmap_folder, "param.json"))
         HierarchicalMLModel.compile_mmap_model(
             path.join(npz_folder, "ranker"), path.join(mmap_folder, "ranker")

test/pecos/xmc/xlinear/test_xlinear.py

@@ -1138,7 +1138,6 @@ def test_on_model(model, X):
 
 
 def test_mmap(tmpdir):
-    from pathlib import Path
     from pecos.utils import smat_util
     from pecos.xmc.xlinear import XLinearModel
     from pecos.xmc import PostProcessor
@@ -1153,7 +1152,6 @@ def test_mmap(tmpdir):
 
     npz_model_folder = str(tmpdir.join("save_model_npz"))
     mmap_model_folder = str(tmpdir.join("save_model_mmap"))
-    Path(mmap_model_folder).mkdir(parents=True, exist_ok=True)
     py_model.save(npz_model_folder)
     XLinearModel.compile_mmap_model(npz_model_folder, mmap_model_folder)
     mmap_model = XLinearModel.load(mmap_model_folder, is_predict_only=True)