change function name, other requested changes

Author: SaundersR1999

.gitignore

@@ -181,5 +181,4 @@ cython_debug/
 .cursorrules
 
 # specific test file to ignore
-telemetry_test.py
-trace_test.py
+*_test_local.py

anaconda_opentelemetry/exporter_shim.py

@@ -20,7 +20,7 @@ def __init__(self, exporter_class, **kwargs):
         self._exporter = exporter_class(**kwargs)
         self._state = ExporterState.READY
 
-    def update_endpoint(self, batch_access, config, new_endpoint, auth_token=None):
+    def change_signal_endpoint(self, batch_access, config, new_endpoint, auth_token=None):
 
         endpoint = config._change_signal_endpoint(
             self._signal,

anaconda_opentelemetry/signals.py

@@ -30,7 +30,6 @@
 from opentelemetry.trace.status import StatusCode
 
 from .config import Configuration as Config
-from .config import deprecated
 from .exporter_shim import OTLPMetricExporterShim, OTLPSpanExporterShim, OTLPLogExporterShim
 from .attributes import ResourceAttributes as Attributes
 from .__version__ import __SDK_VERSION__, __TELEMETRY_SCHEMA_VERSION__
@@ -574,7 +573,7 @@ def initialize_telemetry(config: Config,
         )
     __ANACONDA_TELEMETRY_INITIALIZED = True
 
-def update_endpoint(signal_type: str, new_endpoint: str, auth_token: str = None):
+def change_signal_endpoint(signal_type: str, new_endpoint: str, auth_token: str = None):
     """
     Updates the endpoint for the passed signal
     
@@ -597,7 +596,7 @@ def update_endpoint(signal_type: str, new_endpoint: str, auth_token: str = None)
         logging.getLogger(__package__).warning(f"{signal_type} not a valid signal type.")
         return False
 
-    updated_endpoint = _AnacondaTelInstance._instance.exporter.update_endpoint(
+    updated_endpoint = _AnacondaTelInstance._instance.exporter.change_signal_endpoint(
         batch_access,
         _AnacondaTelInstance._instance._config,
         new_endpoint,

tests/unit_tests/exporter_shim_test.py

@@ -97,7 +97,7 @@ def test_shutdown_delegates_to_exporter(self):
         assert result == True
         assert mixin._exporter.is_shutdown == True
 
-    def test_update_endpoint_successful(self):
+    def test_change_signal_endpoint_successful(self):
         mixin = _OTLPExporterMixin(MockExporter, endpoint="http://localhost:4317")
         mixin._signal = "metrics"
 
@@ -106,7 +106,7 @@ def test_update_endpoint_successful(self):
 
         batch_access = Mock()
 
-        result = mixin.update_endpoint(
+        result = mixin.change_signal_endpoint(
             batch_access,
             config,
             "http://newhost:8080",
@@ -128,7 +128,7 @@ def test_update_endpoint_successful(self):
         assert isinstance(mixin._exporter, MockExporter)
         assert mixin._exporter.kwargs['endpoint'] == "http://newhost:8080/v1/metrics"
 
-    def test_update_endpoint_handles_exporter_creation_failure(self):
+    def test_change_signal_endpoint_handles_exporter_creation_failure(self):
         class FailingExporter:
             def __init__(self, **kwargs):
                 if kwargs.get('endpoint') == "http://invalid:8080/v1/metrics":
@@ -148,7 +148,7 @@ def shutdown(self):
 
         batch_access = Mock()
 
-        result = mixin.update_endpoint(
+        result = mixin.change_signal_endpoint(
             batch_access,
             config,
             "http://invalid:8080"
@@ -159,8 +159,8 @@ def shutdown(self):
         assert mixin._exporter is old_exporter
         batch_access.force_flush.assert_not_called()
 
-    def test_update_endpoint_thread_safety(self):
-        """Test that update_endpoint properly locks during state changes"""
+    def test_change_signal_endpoint_thread_safety(self):
+        """Test that change_signal_endpoint properly locks during state changes"""
         mixin = _OTLPExporterMixin(MockExporter, endpoint="http://localhost:4317")
         mixin._signal = "metrics"
 
@@ -190,7 +190,7 @@ def track_state_on_exit(*args):
 
         mixin._lock = mock_lock
 
-        mixin.update_endpoint(batch_access, config, "http://newhost:8080")
+        mixin.change_signal_endpoint(batch_access, config, "http://newhost:8080")
 
         # Should acquire lock at least twice
         assert enter_count[0] >= 2
@@ -254,15 +254,15 @@ def test_export_with_spans(self):
         assert result == "SUCCESS"
         assert shim._exporter.exported_items == [spans]
 
-    def test_update_endpoint_uses_tracing_signal(self):
+    def test_change_signal_endpoint_uses_tracing_signal(self):
         shim = OTLPSpanExporterShim(MockExporter)
 
         config = Mock()
         config._change_signal_endpoint.return_value = "http://newhost:8080/v1/traces"
 
         batch_access = Mock()
 
-        shim.update_endpoint(batch_access, config, "http://newhost:8080")
+        shim.change_signal_endpoint(batch_access, config, "http://newhost:8080")
 
         config._change_signal_endpoint.assert_called_once_with(
             "tracing",
@@ -293,15 +293,15 @@ def test_export_with_logs(self):
         assert result == "SUCCESS"
         assert shim._exporter.exported_items == [logs]
 
-    def test_update_endpoint_uses_logging_signal(self):
+    def test_change_signal_endpoint_uses_logging_signal(self):
         shim = OTLPLogExporterShim(MockExporter)
 
         config = Mock()
         config._change_signal_endpoint.return_value = "http://newhost:8080/v1/logs"
 
         batch_access = Mock()
 
-        shim.update_endpoint(batch_access, config, "http://newhost:8080")
+        shim.change_signal_endpoint(batch_access, config, "http://newhost:8080")
 
         config._change_signal_endpoint.assert_called_once_with(
             "logging",
@@ -343,7 +343,7 @@ def test_endpoint_update_sequence(self):
 
         for endpoint in endpoints:
             config._change_signal_endpoint.return_value = f"{endpoint}/v1/metrics"
-            result = shim.update_endpoint(batch_access, config, endpoint)
+            result = shim.change_signal_endpoint(batch_access, config, endpoint)
 
             assert result == True
             assert shim._init_kwargs['endpoint'] == f"{endpoint}/v1/metrics"
@@ -370,17 +370,17 @@ def export_continuously():
                     export_results.append(f"error: {e}")
                 time.sleep(0.01)
 
-        def update_endpoint():
+        def change_signal_endpoint():
             config = Mock()
             config._change_signal_endpoint.return_value = "http://newhost:8080/v1/metrics"
             batch_access = Mock()
 
             time.sleep(0.05)
-            result = shim.update_endpoint(batch_access, config, "http://newhost:8080")
+            result = shim.change_signal_endpoint(batch_access, config, "http://newhost:8080")
             update_results.append(result)
 
         export_thread = Thread(target=export_continuously)
-        update_thread = Thread(target=update_endpoint)
+        update_thread = Thread(target=change_signal_endpoint)
 
         export_thread.start()
         update_thread.start()

tests/unit_tests/test_external.py

@@ -8,7 +8,7 @@
 from unittest.mock import patch, MagicMock
 import anaconda_opentelemetry.signals as signals_package
 from anaconda_opentelemetry.signals import initialize_telemetry, record_histogram, increment_counter, \
-    decrement_counter, get_trace, get_telemetry_logger_handler, MetricsNotInitialized, update_endpoint
+    decrement_counter, get_trace, get_telemetry_logger_handler, MetricsNotInitialized, change_signal_endpoint
 from anaconda_opentelemetry.signals import __check_internet_status as check_internet
 from anaconda_opentelemetry.config import Configuration as Config
 from anaconda_opentelemetry.attributes import ResourceAttributes as Attributes
@@ -1186,25 +1186,25 @@ def setup_method(self):
         """Reset all instances state before each test"""
         _instance = None
 
-    def test_update_endpoint_invalid_signal_type(self):
+    def test_change_signal_endpoint_invalid_signal_type(self):
         # Test with invalid signal type
-        result = update_endpoint('invalid_signal', 'http://new-endpoint:4317')
+        result = change_signal_endpoint('invalid_signal', 'http://new-endpoint:4317')
         assert result is False
 
     @patch('anaconda_opentelemetry.signals._AnacondaLogger._instance')
-    def test_update_endpoint_logging_success(self, mock_logger_instance):
+    def test_change_signal_endpoint_logging_success(self, mock_logger_instance):
         mock_exporter = MagicMock()
-        mock_exporter.update_endpoint.return_value = True
+        mock_exporter.change_signal_endpoint.return_value = True
         mock_processor = MagicMock()
         mock_config = MagicMock()
 
         mock_logger_instance._processor = mock_processor
         mock_logger_instance.exporter = mock_exporter
         mock_logger_instance._config = mock_config
 
-        result = update_endpoint('logging', 'http://new-endpoint:4317')
+        result = change_signal_endpoint('logging', 'http://new-endpoint:4317')
 
-        mock_exporter.update_endpoint.assert_called_once_with(
+        mock_exporter.change_signal_endpoint.assert_called_once_with(
             mock_processor,
             mock_config,
             'http://new-endpoint:4317',
@@ -1213,19 +1213,19 @@ def test_update_endpoint_logging_success(self, mock_logger_instance):
         assert result is True
 
     @patch('anaconda_opentelemetry.signals._AnacondaLogger._instance')
-    def test_update_endpoint_logging_with_auth_token(self, mock_logger_instance):
+    def test_change_signal_endpoint_logging_with_auth_token(self, mock_logger_instance):
         mock_exporter = MagicMock()
-        mock_exporter.update_endpoint.return_value = True
+        mock_exporter.change_signal_endpoint.return_value = True
         mock_processor = MagicMock()
         mock_config = MagicMock()
 
         mock_logger_instance._processor = mock_processor
         mock_logger_instance.exporter = mock_exporter
         mock_logger_instance._config = mock_config
 
-        result = update_endpoint('logging', 'http://new-endpoint:4317', auth_token='test_token')
+        result = change_signal_endpoint('logging', 'http://new-endpoint:4317', auth_token='test_token')
 
-        mock_exporter.update_endpoint.assert_called_once_with(
+        mock_exporter.change_signal_endpoint.assert_called_once_with(
             mock_processor,
             mock_config,
             'http://new-endpoint:4317',
@@ -1234,34 +1234,34 @@ def test_update_endpoint_logging_with_auth_token(self, mock_logger_instance):
         assert result is True
 
     @patch('anaconda_opentelemetry.signals._AnacondaLogger._instance')
-    def test_update_endpoint_logging_failure(self, mock_logger_instance):
+    def test_change_signal_endpoint_logging_failure(self, mock_logger_instance):
         mock_exporter = MagicMock()
-        mock_exporter.update_endpoint.return_value = False
+        mock_exporter.change_signal_endpoint.return_value = False
         mock_processor = MagicMock()
         mock_config = MagicMock()
 
         mock_logger_instance._processor = mock_processor
         mock_logger_instance.exporter = mock_exporter
         mock_logger_instance._config = mock_config
 
-        result = update_endpoint('logging', 'http://new-endpoint:4317')
+        result = change_signal_endpoint('logging', 'http://new-endpoint:4317')
 
         assert result is False
 
     @patch('anaconda_opentelemetry.signals._AnacondaMetrics._instance')
-    def test_update_endpoint_metrics_success(self, mock_metrics_instance):
+    def test_change_signal_endpoint_metrics_success(self, mock_metrics_instance):
         mock_exporter = MagicMock()
-        mock_exporter.update_endpoint.return_value = True
+        mock_exporter.change_signal_endpoint.return_value = True
         mock_metric_reader = MagicMock()
         mock_config = MagicMock()
 
         mock_metrics_instance.metric_reader = mock_metric_reader
         mock_metrics_instance.exporter = mock_exporter
         mock_metrics_instance._config = mock_config
 
-        result = update_endpoint('metrics', 'http://new-endpoint:4317')
+        result = change_signal_endpoint('metrics', 'http://new-endpoint:4317')
 
-        mock_exporter.update_endpoint.assert_called_once_with(
+        mock_exporter.change_signal_endpoint.assert_called_once_with(
             mock_metric_reader,
             mock_config,
             'http://new-endpoint:4317',
@@ -1270,34 +1270,34 @@ def test_update_endpoint_metrics_success(self, mock_metrics_instance):
         assert result is True
 
     @patch('anaconda_opentelemetry.signals._AnacondaMetrics._instance')
-    def test_update_endpoint_metrics_failure(self, mock_metrics_instance):
+    def test_change_signal_endpoint_metrics_failure(self, mock_metrics_instance):
         mock_exporter = MagicMock()
-        mock_exporter.update_endpoint.return_value = False
+        mock_exporter.change_signal_endpoint.return_value = False
         mock_metric_reader = MagicMock()
         mock_config = MagicMock()
 
         mock_metrics_instance.metric_reader = mock_metric_reader
         mock_metrics_instance.exporter = mock_exporter
         mock_metrics_instance._config = mock_config
 
-        result = update_endpoint('metrics', 'http://new-endpoint:4317')
+        result = change_signal_endpoint('metrics', 'http://new-endpoint:4317')
 
         assert result is False
 
     @patch('anaconda_opentelemetry.signals._AnacondaTrace._instance')
-    def test_update_endpoint_tracing_success(self, mock_trace_instance):
+    def test_change_signal_endpoint_tracing_success(self, mock_trace_instance):
         mock_exporter = MagicMock()
-        mock_exporter.update_endpoint.return_value = True
+        mock_exporter.change_signal_endpoint.return_value = True
         mock_processor = MagicMock()
         mock_config = MagicMock()
 
         mock_trace_instance._processor = mock_processor
         mock_trace_instance.exporter = mock_exporter
         mock_trace_instance._config = mock_config
 
-        result = update_endpoint('tracing', 'http://new-endpoint:4317')
+        result = change_signal_endpoint('tracing', 'http://new-endpoint:4317')
 
-        mock_exporter.update_endpoint.assert_called_once_with(
+        mock_exporter.change_signal_endpoint.assert_called_once_with(
             mock_processor,
             mock_config,
             'http://new-endpoint:4317',
@@ -1306,32 +1306,32 @@ def test_update_endpoint_tracing_success(self, mock_trace_instance):
         assert result is True
 
     @patch('anaconda_opentelemetry.signals._AnacondaTrace._instance')
-    def test_update_endpoint_tracing_failure(self, mock_trace_instance):
+    def test_change_signal_endpoint_tracing_failure(self, mock_trace_instance):
         mock_exporter = MagicMock()
-        mock_exporter.update_endpoint.return_value = False
+        mock_exporter.change_signal_endpoint.return_value = False
         mock_processor = MagicMock()
         mock_config = MagicMock()
 
         mock_trace_instance._processor = mock_processor
         mock_trace_instance.exporter = mock_exporter
         mock_trace_instance._config = mock_config
 
-        result = update_endpoint('tracing', 'http://new-endpoint:4317')
+        result = change_signal_endpoint('tracing', 'http://new-endpoint:4317')
 
         assert result is False
 
     @patch('anaconda_opentelemetry.signals._AnacondaLogger._instance')
-    def test_update_endpoint_case_insensitive(self, mock_logger_instance):
+    def test_change_signal_endpoint_case_insensitive(self, mock_logger_instance):
         mock_exporter = MagicMock()
-        mock_exporter.update_endpoint.return_value = True
+        mock_exporter.change_signal_endpoint.return_value = True
         mock_processor = MagicMock()
         mock_config = MagicMock()
 
         mock_logger_instance._processor = mock_processor
         mock_logger_instance.exporter = mock_exporter
         mock_logger_instance._config = mock_config
 
-        result = update_endpoint('LOGGING', 'http://new-endpoint:4317')
+        result = change_signal_endpoint('LOGGING', 'http://new-endpoint:4317')
 
         assert result is True
-        mock_exporter.update_endpoint.assert_called_once()
+        mock_exporter.change_signal_endpoint.assert_called_once()