Update CI workflows

- golangci-lint-action v2 -> v6, remove deleted linters (structcheck,
  deadcode), add explicit setup-go step, remove GO111MODULE
- codeql-action v2 -> v3, remove manual PR checkout workaround
- Skip global installability test on non-tag pushes
- Windows: test all packages (./...), add oldstable Go version

Author: anacrolix

.github/workflows/codeql-analysis.yml

@@ -2,9 +2,8 @@ name: "CodeQL"
 
 on:
   push:
-    branches: [master, ]
+    branches: [master]
   pull_request:
-    # The branches below must be a subset of the branches above
     branches: [master]
   schedule:
     - cron: '0 10 * * 4'
@@ -17,38 +16,12 @@ jobs:
     steps:
     - name: Checkout repository
       uses: actions/checkout@v4
-      with:
-        # We must fetch at least the immediate parents so that if this is
-        # a pull request then we can checkout the head.
-        fetch-depth: 2
-
-    # If this run was triggered by a pull request event, then checkout
-    # the head of the pull request instead of the merge commit.
-    - run: git checkout HEAD^2
-      if: ${{ github.event_name == 'pull_request' }}
 
-    # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@v2
-      # Override language selection by uncommenting this and choosing your languages
-      # with:
-      #   languages: go, javascript, csharp, python, cpp, java
+      uses: github/codeql-action/init@v3
 
-    # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
-    # If this step fails, then you should remove it and run the build manually (see below)
     - name: Autobuild
-      uses: github/codeql-action/autobuild@v2
-
-    # ℹ️ Command-line programs to run using the OS shell.
-    # 📚 https://git.io/JvXDl
-
-    # ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
-    #    and modify them (or add more) to build your code if your project
-    #    uses a compiled language
-
-    #- run: |
-    #   make bootstrap
-    #   make release
+      uses: github/codeql-action/autobuild@v3
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v2
+      uses: github/codeql-action/analyze@v3

.github/workflows/go.yml

@@ -43,6 +43,7 @@ jobs:
         run: GOOS=js GOARCH=wasm go build . ./storage ./tracker/...
 
       - name: Test global installability
+        if: startsWith(github.ref, 'refs/tags/v')
         run: |
           # Create isolated environment
           TMPDIR=$(mktemp -d)

.github/workflows/linter.yml

@@ -10,28 +10,13 @@ jobs:
   golint:
     name: Lint
     runs-on: ubuntu-latest
-    env:
-      GO111MODULE: on
     steps:
       - uses: actions/checkout@v4
-      - uses: golangci/golangci-lint-action@v2
+      - uses: actions/setup-go@v5
+        with:
+          go-version: stable
+      - uses: golangci/golangci-lint-action@v6
         with:
           version: latest
-
-          # Optional: working directory, useful for monorepos
-          # working-directory: somedir
-
-          # Optional: golangci-lint command line arguments.
-          args: -D errcheck,unused,structcheck,deadcode
-
-          # Optional: show only new issues if it's a pull request. The default value is `false`.
+          args: -D errcheck,unused
           only-new-issues: true
-
-          # Optional: if set to true then the action will use pre-installed Go.
-          skip-go-installation: true
-
-          # Optional: if set to true then the action don't cache or restore ~/go/pkg.
-          # skip-pkg-cache: true
-
-          # Optional: if set to true then the action don't cache or restore ~/.cache/go-build.
-          # skip-build-cache: true

.github/workflows/windows.yml

@@ -8,7 +8,8 @@ jobs:
     runs-on: windows-latest
     strategy:
       matrix:
-        go-version: [stable]
+        go-version: [stable, oldstable]
+      fail-fast: false
     steps:
       - uses: actions/checkout@v4
         with:
@@ -17,7 +18,7 @@ jobs:
         with:
           go-version: ${{ matrix.go-version }}
       - run: go mod download
-      - name: Test torrent package
-        run: go test -count=1 -v .
+      - name: Test packages
+        run: go test -count=1 ./...
         env:
           CGO_ENABLED: "0"