Skip to content

Commit 2b1434b

Browse files
authored
fix(release): Fix release-plz dirty-tree errors from Ruby binstubs (microsoft#547)
Ruby binstubs were checked in, but ignore via .gitignore **bin pattern. This causes release-plz to think that the source tree is dirty. The binstubs are deleted from source repo since they are always regenerated by bundler. Also simplizy release-plz to focus only on the core crate. Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
1 parent fd59bb5 commit 2b1434b

4 files changed

Lines changed: 3 additions & 30 deletions

File tree

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ bindings/*/target
2929
**bin
3030
**obj
3131

32+
# Bundler binstubs regenerated during ruby setup
33+
bindings/ruby/bin/
34+
3235
# Visual Studio folders
3336
**/*.vs
3437

bindings/ruby/bin/console

Lines changed: 0 additions & 11 deletions
This file was deleted.

bindings/ruby/bin/setup

Lines changed: 0 additions & 8 deletions
This file was deleted.

release-plz.toml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,9 @@ changelog_update = false
55
dependencies_update = false
66
publish = false
77

8-
# These files show up as modified (dirty) to release-plz:
9-
# bindings/ruby/bin/console
10-
# bindings/ruby/bin/setup
11-
# As a result, release-plz fails during update.
12-
# As a workaround, allow dirty workding directory.
13-
allow_dirty = true
14-
# But don't allow release-plz to publish dirty packages.
15-
publish_allow_dirty = false
16-
17-
188
[[package]]
199
name = "regorus"
2010
git_tag_enable = true
2111
git_release_enable = true
2212
changelog_update = true
2313
publish = true
24-
command = "cargo xtask bindings --base-ref origin/main"

0 commit comments

Comments
 (0)