We can't build https://github.com/analogdevicesinc/adi_3dtof_adtf31xx using v6.1.0 or later, including main, because it complains that libzmq-static cannot be found.
The solution to fix this was to set it as PRIVATE instead of PUBLIC here since the network interface where it is used is private anyway and the library is statically linked.
On another note, since cppzmq is used, it would probably be better to link cppzmq-static rather than libzmq-static (see their README).
I didn't understand why there's a double check here:
NOT WITH_SUBMODULES AND NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/../dependencies/third-party/libzmq/.git"
If someone sets WITH_SUBMODULES as OFF I assume the system installed libzmq and cppzmq should be used regardless of the submodule existing.
Moreover, if it is found, it should be linked.
We can't build https://github.com/analogdevicesinc/adi_3dtof_adtf31xx using
v6.1.0or later, includingmain, because it complains thatlibzmq-staticcannot be found.The solution to fix this was to set it as
PRIVATEinstead ofPUBLIChere since the network interface where it is used is private anyway and the library is statically linked.On another note, since
cppzmqis used, it would probably be better to linkcppzmq-staticrather thanlibzmq-static(see their README).I didn't understand why there's a double check here:
If someone sets WITH_SUBMODULES as OFF I assume the system installed libzmq and cppzmq should be used regardless of the submodule existing.
Moreover, if it is found, it should be linked.