usb: chipidea: core: modernize ulpi reset gpio handling

The ulpi reset gpio code (which is a patch owned by us) was still using
the legacy gpio API which brings some pain from times to times whem
merging to a new kernel version (ex: this merge a macro was dropped from
upstream). Hence, use the proper GPIO consumer API.

On top of that, correctly handle the pin polarity. The pins is active
low so this means we want to request the GPIO asserted to reset the phy
(hence GPIOD_OUT_HIGH) and then bring the device out of reset by
deaserting the pin (hence passing 0 in gpiod_set_value_cansleep().
Things worked because we "cheated" in DT by saying the pin is active
high and then requesting it in the deasserted state (setting the pin to 0
and effectively assert/reset it), Then asserting it by passing 1 to
gpiod_set_value_cansleep() which in fact was deasserting the pin.

While at it, remove the #ifdef and use fsleep() instead of msleep().

Signed-off-by: Nuno Sá <nuno.sa@analog.com>

Author: nunojsa

drivers/usb/chipidea/core.c

@@ -18,7 +18,7 @@
 #include <linux/device.h>
 #include <linux/dma-mapping.h>
 #include <linux/extcon.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
 #include <linux/module.h>
@@ -36,7 +36,6 @@
 #include <linux/usb/of.h>
 #include <linux/usb/ulpi.h>
 #include <linux/of.h>
-#include <linux/of_gpio.h>
 #include <linux/phy.h>
 #include <linux/regulator/consumer.h>
 #include <linux/usb/ehci_def.h>
@@ -988,25 +987,28 @@ static void ci_get_otg_capable(struct ci_hdrc *ci)
 	}
 }
 
-#ifdef CONFIG_USB_ULPI
-
 static int ci_hdrc_create_ulpi_phy(struct device *dev, struct ci_hdrc *ci)
 {
 	struct usb_phy *ulpi;
-	int reset_gpio;
-	int ret;
+	struct gpio_desc *reset_gpio;
 
-	reset_gpio = of_get_named_gpio(dev->parent->of_node, "xlnx,phy-reset-gpio", 0);
-	if (gpio_is_valid(reset_gpio)) {
-		ret = devm_gpio_request_one(dev, reset_gpio,
-				GPIOF_OUT_INIT_LOW, "ulpi resetb");
-		if (ret) {
-			dev_err(dev, "Failed to request ULPI reset gpio: %d\n", ret);
+	if (!IS_ENABLED(CONFIG_USB_ULPI))
+		return 0;
+
+	reset_gpio = devm_gpiod_get_optional(dev->parent, "xlnx,phy-reset-gpio",
+					     GPIOD_OUT_HIGH);
+	if (IS_ERR(reset_gpio))
+		return dev_err_probe(dev, PTR_ERR(reset_gpio), "Failed to get ULPI reset gpio\n");
+	if (reset_gpio) {
+		int ret;
+
+		ret = gpiod_set_consumer_name(reset_gpio, "ulpi resetb");
+		if (ret)
 			return ret;
-		}
-		msleep(5);
-		gpio_set_value_cansleep(reset_gpio, 1);
-		msleep(1);
+
+		fsleep(5);
+		gpiod_set_value_cansleep(reset_gpio, 0);
+		fsleep(1);
 	}
 
 	ulpi = otg_ulpi_create(&ulpi_viewport_access_ops,
@@ -1019,15 +1021,6 @@ static int ci_hdrc_create_ulpi_phy(struct device *dev, struct ci_hdrc *ci)
 	return 0;
 }
 
-#else
-
-static int ci_hdrc_create_ulpi_phy(struct device *dev, struct ci_hdrc *ci)
-{
-	return 0;
-}
-
-#endif
-
 static ssize_t role_show(struct device *dev, struct device_attribute *attr,
 			  char *buf)
 {