Replace pylint disable comments with ruff noqa and remove others

Co-authored-by: AlexeyKozhevin <[email protected]>

Author: Copilot

nbtools/__init__.py

@@ -1,5 +1,4 @@
 """ Init file. """
-#pylint: disable=wildcard-import
 from .core import *
 from .exec_notebook import exec_notebook, run_notebook
 from .pylint_notebook import pylint_notebook

nbtools/core.py

@@ -1,5 +1,4 @@
 """ Core utility functions to work with Jupyter Notebooks. """
-#pylint: disable=import-outside-toplevel
 import os
 import sys
 import re
@@ -34,7 +33,6 @@ def get_notebook_path():
 
     If run outside Jupyter notebook, returns None.
     """
-    #pylint: disable=missing-timeout
     if not in_notebook():
         return None
 
@@ -74,7 +72,7 @@ def get_notebook_name():
 
 def notebook_to_script(path_script, path_notebook=None, ignore_markdown=True, return_info=False):
     """ Convert a notebook to a script. """
-    import nbformat #pylint: disable=import-outside-toplevel
+    import nbformat
     path_notebook = path_notebook or get_notebook_path()
     if path_notebook is None:
         raise ValueError('Provide path to Jupyter Notebook or run `notebook_to_script` inside of it!')
@@ -267,7 +265,6 @@ def set_gpus(n=1, min_free_memory=0.9, max_processes=2, verbose=False, raise_err
     devices : list
         Indices of selected and reserved GPUs.
     """
-    #pylint: disable=consider-iterating-dictionary
     if 'CUDA_VISIBLE_DEVICES' in os.environ.keys():
         str_devices = os.environ["CUDA_VISIBLE_DEVICES"]
         warnings.warn(f'`CUDA_VISIBLE_DEVICES` is already set to "{str_devices}"!')

nbtools/exec_notebook.py

@@ -1,5 +1,4 @@
 """ Functions for running Jupyter Notebooks programmatically."""
-#pylint: disable=import-outside-toplevel
 import os
 import time
 import json
@@ -10,7 +9,7 @@
 import psutil
 
 
-TMP_DIR = '/tmp/nbtools_exec_notebook'
+TMP_DIR = '/tmp/nbtools_exec_notebook'  # noqa: S108
 os.makedirs(TMP_DIR, exist_ok=True)
 
 
@@ -19,7 +18,6 @@ def run_in_process(func):
     """ Decorator to run the ``func`` in a separate process for terminating all related processes properly. """
     @wraps(func)
     def _wrapper(*args, **kwargs):
-        # pylint: disable=broad-exception-caught, broad-exception-raised
         _output_queue = Queue()
         kwargs = {**kwargs, '_output_queue': _output_queue}
 
@@ -39,7 +37,7 @@ def _wrapper(*args, **kwargs):
 
             output = _output_queue.get()
             process.join()
-        except (KeyboardInterrupt, Exception) as e:
+        except (KeyboardInterrupt, Exception) as e:  # noqa: BLE001
             output = {'failed': True, 'traceback': e}
 
             # Terminate all relevant processes when something went wrong, e.g. Keyboard Interrupt
@@ -245,7 +243,6 @@ def exec_notebook(path, inputs=None, outputs=None, inputs_pos=1, replace_inputs_
             - ``'notebook'`` : :class:`nbformat.notebooknode.NotebookNode`, optional
                 Executed notebook object. Note that this output is provided only if ``return_notebook`` is ``True``.
     """
-    # pylint: disable=bare-except, lost-exception, return-in-finally
     import nbformat
     from jupyter_client.manager import KernelManager
     from nbconvert.preprocessors import ExecutePreprocessor
@@ -321,7 +318,7 @@ def exec_notebook(path, inputs=None, outputs=None, inputs_pos=1, replace_inputs_
     exec_failed = False
     try:
         executor.preprocess(notebook, {'metadata': {'path': working_dir}}, km=kernel_manager)
-    except:
+    except:  # noqa: E722
         exec_failed = True
 
         # Save notebook outputs in the shelve db
@@ -359,7 +356,7 @@ def exec_notebook(path, inputs=None, outputs=None, inputs_pos=1, replace_inputs_
             # Re-raise exception if needed
             if raise_exception:
                 _output_queue.put(exec_res)
-                return None
+                return None  # noqa: RET501
         else:
             exec_res = {'failed': failed, 'failed cell number': None, 'traceback': ''}
 
@@ -397,7 +394,7 @@ def exec_notebook(path, inputs=None, outputs=None, inputs_pos=1, replace_inputs_
             exec_res['notebook'] = notebook
 
         _output_queue.put(exec_res) # return for parent process
-    return None
+    return None  # noqa: RET501
 
 # Functions for database operations cells masking
 def _display_inputs_reading(notebook, pos):

nbtools/nbstat/__init__.py

@@ -1,5 +1,4 @@
 """ NBstat module: monitoring running Python processes and Notebooks. """
-#pylint: disable=wildcard-import
 from .resource import Resource
 from .resource_entry import ResourceEntry
 from .resource_table import ResourceTable

nbtools/nbstat/cli.py

@@ -1,7 +1,6 @@
 """ Command line interface of `nbstat`.
 Also provides `nbwatch`, `devicestat` and `devicewatch` functions.
 """
-#pylint: disable=redefined-outer-name, too-many-nested-blocks
 import sys
 import traceback
 from inspect import cleandoc
@@ -21,9 +20,9 @@ def main(name, interval=None):
     """ Run command `name`. If `interval` is given, continuously output it to a terminal in fullscreen mode. """
     # Attach SIGPIPE handler to properly handle broken pipe
     try: # sigpipe not available under windows. just ignore in this case
-        import signal # pylint: disable=import-outside-toplevel
+        import signal  # noqa: E402
         signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-    except Exception: # pylint: disable=broad-except
+    except Exception:  # noqa: BLE001, S110
         pass
 
     # Make parameters for requested view
@@ -54,15 +53,14 @@ def output_once(inspector, name, formatter, view_args):
     try:
         view = inspector.get_view(name=name, formatter=formatter, **view_args)
         print(view)
-    except Exception as e: # pylint: disable=broad-except
+    except Exception as e:
         _ = e
         print('Error on getting system information!' + str(e))
         raise e
 
 def output_looped(inspector, name, formatter, view_args,
                   other_name, other_formatter, other_view_args, interval=0.5):
     """ Output visualization to a stdout once each `interval` seconds in a fullscreen mode. """
-    #pylint: disable=too-many-statements
     terminal = Terminal()
 
     initial_view_args = dict(view_args)
@@ -194,7 +192,7 @@ def output_looped(inspector, name, formatter, view_args,
                         else:
                             print(f'\nUnrecognized key={inkey}, code={inkey.code}.')
 
-                except Exception as e: # pylint: disable=broad-except
+                except Exception as e:  # noqa: BLE001
                     sys.stderr.write(traceback.format_exc())
                     sys.stderr.write('Error on getting system information!')
                     sys.stderr.write(str(e))

nbtools/nbstat/resource_entry.py

@@ -39,7 +39,6 @@ def to_format_data(self, resource, terminal, **kwargs):
         kwargs : dict
             Other parameters for string creation like memory format, width, etc.
         """
-        #pylint: disable=too-many-statements
         resource = Resource.parse_alias(resource)
         default_string = '-'
         style, string = None, None

nbtools/nbstat/resource_inspector.py

@@ -22,7 +22,7 @@
 KERNEL_ID_SEARCHER   = re.compile('kernel-(.*).json').search
 VSCODE_KEY_SEARCHER  = re.compile('key=b"(.*)"').search
 SCRIPT_NAME_SEARCHER = re.compile('python.* (.*).py').search
-RUN_NOTEBOOK_PATH_SEARCHER = re.compile('/tmp/.*.json.*--HistoryManager.hist_file=:memory:.*').search
+RUN_NOTEBOOK_PATH_SEARCHER = re.compile('/tmp/.*.json.*--HistoryManager.hist_file=:memory:.*').search  # noqa: S108
 
 
 class ResourceInspector:
@@ -159,7 +159,6 @@ def get_notebook_table(self, formatter=None):
 
         TODO: once VSCode has stable standard and doc for ipykernel launches, add its parsing here.
         """
-        #pylint: disable=import-outside-toplevel, missing-timeout
         servers = []
         try:
             from notebook.notebookapp import list_running_servers as list_running_servers_v2
@@ -628,7 +627,7 @@ def make_terminal(self, force_styling, separator):
         """ Create terminal instance. """
         terminal = Terminal(kind=os.getenv('TERM'), force_styling=force_styling if force_styling else None)
         terminal.separator_symbol = separator
-        terminal._normal = '\x1b[0;10m' # pylint: disable=protected-access
+        terminal._normal = '\x1b[0;10m'  # noqa: SLF001
 
         # Change some methods to a faster versions
         # TODO: better measurements and tests for the same outputs

nbtools/nbstat/resource_table.py

@@ -32,7 +32,6 @@ class ResourceTable:
     # TODO: can require `index` and/or `columns` at table creation, should we want so, for consistency
     # TODO: can create a `PandasResourceTable` with the same API, but `pandas.DataFrame` under the hood
     """
-    #pylint: disable=self-cls-assignment
     def __init__(self, data=None):
         self._data = [] if data is None else [ResourceEntry(entry) for entry in data]
 
@@ -468,7 +467,7 @@ def format(self, terminal, formatter, hide_similar=True,
                     if hide_similar and hidable and i > 0:
                         style, string = '', ''
 
-                    if False and i: # pylint: disable=condition-evals-to-constant
+                    if False and i:
                         # TODO: aggregate info by using `aggregate` method
                         # for a given resource and create a ResourceEntry out of it to make style/string
                         remaining_table = subtable[1:]
@@ -536,5 +535,5 @@ def format(self, terminal, formatter, hide_similar=True,
     # Pandas compatibility
     def to_pd(self):
         """ Convert the table to a `pandas.DataFrame`. """
-        import pandas as pd #pylint: disable=import-outside-toplevel
+        import pandas as pd
         return pd.DataFrame(self.data)

nbtools/nbstat/utils.py

@@ -1,5 +1,4 @@
 """ Utility functions. """
-#pylint: disable=redefined-builtin
 import re
 import platform
 import linecache
@@ -25,7 +24,7 @@ def pid_to_name_linux(pid):
     try:
         line = linecache.getline(f'/proc/{pid}/status', 1)
         name = line.strip().split()[1]
-    except Exception: #pylint: disable=broad-except
+    except Exception:  # noqa: BLE001
         name = ''
     return name
 
@@ -42,7 +41,7 @@ def pid_to_ngid_linux(pid):
         line = linecache.getline(f'/proc/{pid}/status', 5)
         ngid = line.strip().split()[1]
         ngid = int(ngid)
-    except Exception: #pylint: disable=broad-except
+    except Exception:  # noqa: BLE001
         ngid = pid
     return ngid or pid
 

ruff.toml

@@ -36,6 +36,7 @@ ignore = [
     "S101",
     "S301",
     "S102",
+    "S113",    # requests-call-without-timeout
 ]
 
 [lint.per-file-ignores]