Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit cab1f1e

Browse files
ruowanraych1
authored andcommittedDec 16, 2022
update arc review comments and mail (Azure#21867)
* update arc review comments and mail * Update .github/comment.yml Co-authored-by: Ray Chen <raychen@microsoft.com>
1 parent 6fc0e43 commit cab1f1e

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed
 

‎.github/comment.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,11 @@
5151
label: CI-RpaaSRPNotInPrivateRepo
5252
onLabeledComments: "Hi @${PRAuthor} This PR was flagged for attempting to introduce a new RP namespace to the main branch without first merging the new RP to the RPSaaSMaster branch. Please add the new RP in a merge to RPSaaSMaster before continuing the merge to main."
5353

54+
- rule:
55+
type: label
56+
label: ArcReview
57+
onLabeledComments: "Hi @${PRAuthor} and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at [Consistency in ARM Modeling](https://msazure.visualstudio.com/One/_wiki/wikis/One.wiki/377428/Consistency-in-ARM-Modeling?anchor=general-design-guidance). To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to arcboard@microsoft.com."
58+
5459
- rule:
5560
type: label
5661
label: CI-FixRequiredOnFailure

‎.github/sla.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,22 @@
2828
- ${AUTHOR}
2929
- ${ASSIGNEE}
3030

31+
32+
- scheduleTask:
33+
action: sendEmail
34+
scope: pull_request
35+
name: "send email to Arc review board"
36+
trigger:
37+
- label
38+
args:
39+
booleanFilterExpression: "ArcReview"
40+
message: "<p>Hi, Arc review board,</p><p>Please review the PR ${URL} . You receive the email because the PR is labeled with ArcReview. One or more change(s) have been detected in your Arc enabled VM or Arc enabled Server RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), add the label ArcSignedOff.</p>"
41+
subject: "Action Required ArcReview: Please review PR ${URL}"
42+
to: ruowan@microsoft.com
43+
cc:
44+
- ${AUTHOR}
45+
- ${ASSIGNEE}
46+
3147
- scheduleTask:
3248
action: sendEmail
3349
scope: pull_request

0 commit comments

Comments
 (0)
Please sign in to comment.