Commit a0496cb
committed
fix: repair botched soundboard sidebar rework and residual UTF-8 mojibake
Five concrete bugs landed in the post-3.24.0 soundboard rework. Plus the
UTF-8 "fix" commit (e9db131) missed most of the corrupted spots, so a
bunch of theme logos and sound-manager labels were still rendering as
'ðŸ…' garbage.
Soundboard sidebar (public/css/style.css, public/js/modules/app-media.js,
public/js/modules/app-voice.js):
- Panel was rendering at the FAR LEFT of #app-body. #app-body uses CSS
flex 'order' for layout, and .sb-sidebar-panel had no explicit order.
Default order 0 pushed it ahead of sidebar (1), main (2), and right-
sidebar (3). Added '#app-body .sb-sidebar-panel { order: 3; }' and
bumped '.right-sidebar' to order 4 (default and [data-panel-pos=right]
variant) so the panel sits between main and the voice/users panel as
the inline HTML comment always claimed.
- Collapse arrows snapped instead of sliding. Both .sidebar-collapse-btn
and .sb-sidebar-toggle-btn are position: fixed with 'right' set
imperatively in JS when panels open/close, but their CSS transition
only animated color + background. Added 'right 0.25s ease' so the
buttons slide with the panels.
- Soundboard surfaces stayed open after leaving voice. Added a
_closeSoundboardForVoiceLeave method on the media mixin that closes
the sidebar panel, the sound modal, and the popped-out PiP, and
hooked _leaveVoice to call it.
UTF-8 mojibake repair (public/css/style.css, public/js/modules/app-media.js):
- 10 theme logos were corrupted by the same PS5 -> cp1252 round-trip
that hit the package.json bump path in v3.17.0. Restored from the
original characters preserved in git history:
eldenring 💍 zelda 🗡️ gospel 🕊️ halo ⌁ nord ❄
minecraft ⛏️ ffx ⚔️ fallout ☢️ scripture ✝️ cloudy ☁
- Sound manager 'Assign to Events' dropdown showed garbage where the
built-in / mic-icon group label should be. Fixed both occurrences
(group_builtin t() interpolation and the 'Sounds' fallback label)
back to 🎙️.
- Bot detail 'Moderation' label was rendering '🛡ï¸' instead of 🛡️.
UTF-8 writes used Python with explicit BOM preservation per
AGENT_INSTRUCTIONS.md (never PowerShell Set-Content). Verified BOMs
still present on style.css and app-media.js after edits.1 parent 46d9fc1 commit a0496cb
2 files changed
Lines changed: 3128 additions & 3108 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
692 | 692 | | |
693 | 693 | | |
694 | 694 | | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
695 | 712 | | |
696 | 713 | | |
697 | 714 | | |
| |||
898 | 915 | | |
899 | 916 | | |
900 | 917 | | |
901 | | - | |
| 918 | + | |
902 | 919 | | |
903 | 920 | | |
904 | 921 | | |
| |||
1221 | 1238 | | |
1222 | 1239 | | |
1223 | 1240 | | |
1224 | | - | |
| 1241 | + | |
1225 | 1242 | | |
1226 | 1243 | | |
1227 | 1244 | | |
| |||
1903 | 1920 | | |
1904 | 1921 | | |
1905 | 1922 | | |
1906 | | - | |
| 1923 | + | |
1907 | 1924 | | |
1908 | 1925 | | |
1909 | 1926 | | |
| |||
0 commit comments