channels: per-channel default role auto-grant (#5389)

Author: ancsemi

CHANGELOG.md

@@ -14,6 +14,7 @@ Format follows [Keep a Changelog](https://keepachangelog.com/). Haven uses [Sema
 ## [Unreleased]
 
 ### Added
+- **#5389: Per-channel default role.** Channel Functions → "Default Role" picks a server role that gets auto-granted (channel-scoped) to every current member and to anyone who joins later. Setting it backfills all existing members in one transaction; clearing it leaves prior grants in place so admins can decide whether to revoke from the Roles UI. New `channels.default_role_id` column (nullable FK → roles, SET NULL on delete), new `set-channel-default-role` socket event gated on `manage_roles`, and the auto-grant fires through the public-join, server-code, and vanity-code join paths. DMs are excluded since they have no roles. `INSERT OR IGNORE` on `user_roles (user_id, role_id, channel_id)` keeps repeated joins idempotent.
 - **#5392: Admin-adjustable max sticker file size.** Stickers had a hard-coded 1 MB ceiling that made them feel cramped compared to images — small enough that most "GIF library" candidates failed to upload. Admin Settings → Uploads & Limits now has a "Max Sticker File Size (KB)" input (256–10240 KB, default 1024). The server already read `max_sticker_kb` per-upload via `createStickerUpload()`, so this just surfaces and validates the setting. Bump it up if you want stickers to double as a GIF library.
 - **#5393: `/break` slash command + persona compacting hard-stop.** Different personas sent in quick succession under the same account were sometimes still visually compacting into a single grouped block for *other* viewers (not the poster — they saw it correctly), making the personas indistinguishable. Three defensive layers now: (1) the grouping check also compares `persona_username` and the displayed `username`, so even if a stale or missing `persona_id` slips through the wire the displayed name still forces a break; (2) a new `break_chain` column on `messages` lets any message hard-stop compaction with the previous one; (3) the new `/break <message>` slash command (also surfaced in the autocomplete list) lets users manually force a fresh group whenever they want, including for normal non-persona messages. The flag round-trips through the SELECT projections, the broadcast object, and the rendered DOM data-attrs so it survives reconnects, history pagination, and DOM trimming.
 - **#5300: Admin password reset (opt-in) backend.** New `admin_password_reset_enabled` server setting (default `false`) lets admins enable a "reset user password to a one-time temp value" flow. New socket event `admin-reset-user-password` (admin-only, gated on the setting) generates a 16-hex-char temp password (`XXXX-XXXX-XXXX-XXXX`), bcrypt-hashes it, bumps `password_version` (which invalidates the target's existing JWTs via the existing pwv-rejection path), sets a new `must_change_password` flag on the user row, and returns the plaintext temp password to the admin once. Audit-logged as `admin_password_reset`. Login response now carries `mustChangePassword: bool`, and a new `POST /api/auth/change-password-required` endpoint accepts a valid token + new password and clears the flag. The setting is also mirrored into `/api/public-config` so any user can see whether admins on this server have this power before signing up. Admin Settings has a checkbox + warning text covering the E2E impact (the user's wrap key derives from the password, so old encrypted DM history becomes unrecoverable on their side, matching the existing recovery-codes flow). Backend by @Amnibro (#5318).

public/app.html

@@ -2812,6 +2812,10 @@ <h3>⚙ <span data-i18n="modals.manage_servers.title">Manage Servers</span></h3>
         <span class="cfn-label">📢 <span data-i18n="channel_functions.announcement">Announcement</span></span>
         <span class="cfn-badge cfn-off" data-i18n="channel_functions.off">OFF</span>
       </div>
+      <div class="cfn-row" data-fn="default-role" data-i18n-title="channel_functions.default_role_hint" title="Auto-grant this role (scoped to this channel) to every current and future member">
+        <span class="cfn-label">👑 <span data-i18n="channel_functions.default_role">Default Role</span></span>
+        <span class="cfn-badge cfn-off" data-i18n="channel_functions.none">None</span>
+      </div>
       <div class="cfn-divider cfn-afk-divider" style="display:none"></div>
       <div class="cfn-row cfn-afk-row" data-fn="afk-sub" style="display:none" data-i18n-title="channel_functions.afk_sub_hint" title="Designate a sub-channel as the AFK voice room — idle users are moved here">
         <span class="cfn-label">💤 <span data-i18n="channel_functions.afk_sub">AFK Sub</span></span>

public/js/modules/app-channels.js

@@ -496,6 +496,18 @@ _updateChannelFunctionsPanel(ch) {
   // Announcement channel
   const isAnnouncement = ch.notification_type === 'announcement';
   this._setCfnBadge('announcement', isAnnouncement, isAnnouncement ? 'ON' : 'OFF');
+  // (#5389) Default role badge — show role name when set, else "None".
+  // Hide for DMs since DMs have no role concept.
+  const defaultRoleRow = document.querySelector('.cfn-row[data-fn="default-role"]');
+  if (defaultRoleRow) {
+    defaultRoleRow.style.display = ch.is_dm ? 'none' : '';
+    if (!ch.is_dm) {
+      const drId = ch.default_role_id || null;
+      const role = drId && Array.isArray(this._allRoles)
+        ? this._allRoles.find(r => r.id === drId) : null;
+      this._setCfnBadge('default-role', !!drId, role ? role.name : (drId ? `#${drId}` : 'None'));
+    }
+  }
   // Self Destruct timer
   const hasExpiry = !!ch.expires_at;
   if (hasExpiry) {

public/js/modules/app-ui.js

@@ -460,6 +460,53 @@ _setupUI() {
       const newType = isAnnouncement ? 'default' : 'announcement';
       optimistic({ notification_type: newType });
       this.socket.emit('set-notification-type', { code, type: newType });
+    } else if (fn === 'default-role') {
+      // (#5389) Dropdown of available server roles. Selecting one fires
+      // set-channel-default-role; selecting "None" clears the default.
+      if (row.querySelector('.cfn-select')) return;
+      const badge = row.querySelector('.cfn-badge');
+      if (!badge) return;
+      // Lazy-fetch roles if we haven't yet (e.g. admin opened the panel
+      // before visiting the Roles page).
+      const _open = () => {
+        const roles = Array.isArray(this._allRoles) ? this._allRoles : [];
+        const select = document.createElement('select');
+        select.className = 'cfn-select cfn-input';
+        select.onclick = e2 => e2.stopPropagation();
+        const noneOpt = document.createElement('option');
+        noneOpt.value = ''; noneOpt.textContent = 'None';
+        select.appendChild(noneOpt);
+        for (const r of roles) {
+          const opt = document.createElement('option');
+          opt.value = String(r.id);
+          opt.textContent = r.name;
+          if (ch && r.id === ch.default_role_id) opt.selected = true;
+          select.appendChild(opt);
+        }
+        badge.replaceWith(select);
+        select.focus();
+        let committed = false;
+        const commit = () => {
+          if (committed) return;
+          committed = true;
+          const raw = select.value;
+          const roleId = raw ? parseInt(raw, 10) : null;
+          optimistic({ default_role_id: roleId });
+          this.socket.emit('set-channel-default-role', { code, roleId });
+        };
+        select.addEventListener('change', () => { commit(); select.blur(); });
+        select.addEventListener('blur', () => {
+          if (!committed) this._updateChannelFunctionsPanel(ch);
+        });
+      };
+      if (Array.isArray(this._allRoles) && this._allRoles.length) {
+        _open();
+      } else {
+        this.socket.emit('get-roles', {}, (res) => {
+          if (res && Array.isArray(res.roles)) this._allRoles = res.roles;
+          _open();
+        });
+      }
     } else if (fn === 'user-limit') {
       // If an input is already showing, don't open another
       if (row.querySelector('.cfn-input')) return;

src/database.js

@@ -412,6 +412,15 @@ function initDatabase() {
     try { db.prepare(`SELECT ${col.name} FROM channels LIMIT 0`).get(); } catch { db.exec(col.sql); }
   }
 
+  // ── Migration: per-channel default role (#5389) ──────────
+  // When set, every existing and future member of this channel is granted
+  // this role scoped to this channel via user_roles. NULL = no auto-grant.
+  try {
+    db.prepare("SELECT default_role_id FROM channels LIMIT 0").get();
+  } catch {
+    db.exec("ALTER TABLE channels ADD COLUMN default_role_id INTEGER DEFAULT NULL REFERENCES roles(id) ON DELETE SET NULL");
+  }
+
   // ── Migration: sub-channels (parent_channel_id, position) ──
   try {
     db.prepare("SELECT parent_channel_id FROM channels LIMIT 0").get();

src/socketHandlers/channels.js

@@ -14,6 +14,24 @@ module.exports = function register(socket, ctx) {
   const { channelUsers, voiceUsers, activeMusic, musicQueues } = state;
   const _audit = (typeof logAudit === 'function') ? logAudit : () => {};
 
+  // (#5389) Auto-grant a channel's default_role_id to a user when they join
+  // or are added to that channel. No-op if the channel has no default role.
+  // Safe to call repeatedly — INSERT OR IGNORE avoids duplicates.
+  const _applyChannelDefaultRole = (channelId, userId, grantedBy = null) => {
+    try {
+      const row = db.prepare('SELECT default_role_id FROM channels WHERE id = ?').get(channelId);
+      if (!row || !row.default_role_id) return;
+      db.prepare(
+        'INSERT OR IGNORE INTO user_roles (user_id, role_id, channel_id, granted_by) VALUES (?, ?, ?, ?)'
+      ).run(userId, row.default_role_id, channelId, grantedBy);
+      if (typeof applyRoleChannelAccess === 'function') {
+        try { applyRoleChannelAccess(row.default_role_id, userId, 'grant'); } catch { /* non-critical */ }
+      }
+    } catch (e) {
+      console.warn('applyChannelDefaultRole failed:', e.message);
+    }
+  };
+
   // ── Get user's channels ─────────────────────────────────
   socket.on('get-channels', () => {
     const channels = getEnrichedChannels(
@@ -211,11 +229,13 @@ module.exports = function register(socket, ctx) {
     const _doAutoJoin = () => {
       const { parents, allowSet } = _resolveAutoJoinChannels();
       const insertMember = db.prepare('INSERT OR IGNORE INTO channel_members (channel_id, user_id) VALUES (?, ?)');
+      const joinedChannelIds = [];
       let joinedCount = 0;
       const txn = db.transaction(() => {
         for (const parent of parents) {
           insertMember.run(parent.id, socket.user.id);
           socket.join(`channel:${parent.code}`);
+          joinedChannelIds.push(parent.id);
           joinedCount++;
           // Sub-channels: never grant private subs via invite. When a
           // default-channels allowlist is set, only grant subs whose
@@ -224,11 +244,14 @@ module.exports = function register(socket, ctx) {
           for (const sub of subs) {
             insertMember.run(sub.id, socket.user.id);
             socket.join(`channel:${sub.code}`);
+            joinedChannelIds.push(sub.id);
             joinedCount++;
           }
         }
       });
       txn();
+      // (#5389) Apply each channel's default role after membership is settled.
+      for (const chId of joinedChannelIds) _applyChannelDefaultRole(chId, socket.user.id);
       return joinedCount;
     };
 
@@ -288,6 +311,9 @@ module.exports = function register(socket, ctx) {
           applyRoleChannelAccess(ar.id, socket.user.id, 'grant');
         }
       } catch { /* non-critical */ }
+
+      // (#5389) Per-channel default role auto-grant.
+      _applyChannelDefaultRole(channel.id, socket.user.id);
     }
 
     if (!channel.parent_channel_id) {
@@ -298,6 +324,7 @@ module.exports = function register(socket, ctx) {
       subs.forEach(sub => {
         insertSub.run(sub.id, socket.user.id);
         socket.join(`channel:${sub.code}`);
+        _applyChannelDefaultRole(sub.id, socket.user.id);
       });
     }
 
@@ -705,6 +732,64 @@ module.exports = function register(socket, ctx) {
     }
   });
 
+  // (#5389) Per-channel default role. Setting it auto-grants the role
+  // (channel-scoped) to every existing member and every future joiner.
+  // Clearing it (roleId = null/0) leaves existing grants alone — admins can
+  // revoke from the Roles UI if they want to strip them.
+  socket.on('set-channel-default-role', (data) => {
+    if (!data || typeof data !== 'object') return;
+    if (!socket.user.isAdmin && !userHasPermission(socket.user.id, 'manage_roles')) {
+      return socket.emit('error-msg', 'You don\'t have permission to set a default role');
+    }
+    const code = typeof data.code === 'string' ? data.code.trim() : '';
+    if (!code || !/^[a-f0-9]{8}$/i.test(code)) return;
+    const channel = db.prepare('SELECT id FROM channels WHERE code = ? AND is_dm = 0').get(code);
+    if (!channel) return socket.emit('error-msg', 'Channel not found');
+
+    let roleId = null;
+    if (data.roleId !== null && data.roleId !== undefined && data.roleId !== 0 && data.roleId !== '') {
+      const parsed = parseInt(data.roleId, 10);
+      if (!Number.isFinite(parsed) || parsed <= 0) {
+        return socket.emit('error-msg', 'Invalid role');
+      }
+      const role = db.prepare('SELECT id, name FROM roles WHERE id = ?').get(parsed);
+      if (!role) return socket.emit('error-msg', 'Role not found');
+      roleId = role.id;
+    }
+
+    try {
+      db.prepare('UPDATE channels SET default_role_id = ? WHERE id = ?').run(roleId, channel.id);
+
+      if (roleId) {
+        // Backfill: grant the new default to every current member of this
+        // channel. INSERT OR IGNORE protects against duplicates if any
+        // member already holds the role channel-scoped.
+        const members = db.prepare('SELECT user_id FROM channel_members WHERE channel_id = ?').all(channel.id);
+        const insertRole = db.prepare(
+          'INSERT OR IGNORE INTO user_roles (user_id, role_id, channel_id, granted_by) VALUES (?, ?, ?, ?)'
+        );
+        const txn = db.transaction(() => {
+          for (const m of members) insertRole.run(m.user_id, roleId, channel.id, socket.user.id);
+        });
+        txn();
+        if (typeof applyRoleChannelAccess === 'function') {
+          for (const m of members) {
+            try { applyRoleChannelAccess(roleId, m.user_id, 'grant'); } catch { /* non-critical */ }
+          }
+        }
+      }
+
+      broadcastChannelLists();
+      io.to(`channel:${code}`).emit('channel-default-role-updated', { code, roleId });
+      socket.emit('toast', { message: roleId ? 'Default role set' : 'Default role cleared', type: 'success' });
+      _audit({ actor: socket.user, action: 'channel_default_role_set',
+        target_type: 'channel', target_id: channel.id, details: { code, roleId } });
+    } catch (err) {
+      console.error('Set default role error:', err);
+      socket.emit('error-msg', 'Failed to set default role');
+    }
+  });
+
   socket.on('set-sort-alphabetical', (data) => {
     if (!data || typeof data !== 'object') return;
     if (!socket.user.isAdmin && !userHasPermission(socket.user.id, 'create_channel')) return socket.emit('error-msg', 'You don\'t have permission to change sort settings');

src/socketHandlers/index.js

@@ -1,4 +1,4 @@
-'use strict';
+'use strict';
 
 const crypto = require('crypto');
 const path   = require('path');
@@ -214,15 +214,15 @@ function setupSocketHandlers(io, db) {
                c.parent_channel_id, c.position, c.is_private, c.expires_at, c.is_temp_voice,
                c.streams_enabled, c.music_enabled, c.media_enabled, c.slow_mode_interval, c.category, c.sort_alphabetical,
                c.cleanup_exempt, c.channel_type, c.voice_user_limit, c.notification_type, c.voice_enabled, c.text_enabled, c.voice_bitrate,
-               c.afk_sub_code, c.afk_timeout_minutes, c.read_only, c.auto_delete_mode, c.auto_delete_interval_hours
+               c.afk_sub_code, c.afk_timeout_minutes, c.read_only, c.auto_delete_mode, c.auto_delete_interval_hours, c.default_role_id
         FROM channels c WHERE c.is_dm = 0
         UNION
         SELECT c.id, c.name, c.code, c.created_by, c.topic, c.is_dm,
                c.code_visibility, c.code_mode, c.code_rotation_type, c.code_rotation_interval,
                c.parent_channel_id, c.position, c.is_private, c.expires_at, c.is_temp_voice,
                c.streams_enabled, c.music_enabled, c.media_enabled, c.slow_mode_interval, c.category, c.sort_alphabetical,
                c.cleanup_exempt, c.channel_type, c.voice_user_limit, c.notification_type, c.voice_enabled, c.text_enabled, c.voice_bitrate,
-               c.afk_sub_code, c.afk_timeout_minutes, c.read_only, c.auto_delete_mode, c.auto_delete_interval_hours
+               c.afk_sub_code, c.afk_timeout_minutes, c.read_only, c.auto_delete_mode, c.auto_delete_interval_hours, c.default_role_id
         FROM channels c
         JOIN channel_members cm ON c.id = cm.channel_id
         WHERE cm.user_id = ? AND c.is_dm = 1
@@ -237,7 +237,7 @@ function setupSocketHandlers(io, db) {
                c.parent_channel_id, c.position, c.is_private, c.expires_at, c.is_temp_voice,
                c.streams_enabled, c.music_enabled, c.media_enabled, c.slow_mode_interval, c.category, c.sort_alphabetical,
                c.cleanup_exempt, c.channel_type, c.voice_user_limit, c.notification_type, c.voice_enabled, c.text_enabled, c.voice_bitrate,
-               c.afk_sub_code, c.afk_timeout_minutes, c.read_only, c.auto_delete_mode, c.auto_delete_interval_hours
+               c.afk_sub_code, c.afk_timeout_minutes, c.read_only, c.auto_delete_mode, c.auto_delete_interval_hours, c.default_role_id
         FROM channels c
         JOIN channel_members cm ON c.id = cm.channel_id
         WHERE cm.user_id = ?