fix: 'Save screenshot' failed with "Failed to save screenshot" - defaulted to an unwritable cwd

Real bug reported via live testing: the Command Palette's screenshot
command (re-enabled in the previous release) failed with a bare
"Failed to save screenshot" error every time inside the companion
container. Root cause confirmed directly: Textual's own default
implementation saves to the current working directory, and the
container's WORKDIR (/app) is root-owned while the container runs as
a non-root user - os.access('/app', os.W_OK) confirmed False inside a
real running container, os.access(home, os.W_OK) confirmed True.

Replaced Textual's own auto-generated 'Save screenshot' command with
our own, same title, calling deliver_screenshot(path=str(Path.home()))
explicitly instead of leaving it to default to cwd - home directory
always exists and is always writable by whoever's running this tool,
and is already where this tool keeps its own state (state.py).
Verified the fix directly inside a real built container image, not
just reasoned about: confirmed cwd genuinely unwritable there, screenshot
save now succeeds where it previously failed with the exact reported
error.

243 tests passing (2 new: confirms the replacement command passes the
home-directory path, confirms a failure is reported without crashing
rather than left silent); verified sdist->wheel build. Version bumped
to 0.1.21 for release.

Author: andlo

README.md

@@ -205,7 +205,7 @@ Confirmed NOT sufficient on its own under rootless Podman specifically
 Podman rather than a standard root-owned `dockerd` socket, this may
 need more digging into your specific setup.
 
-Images are tagged by version (`:0.1.20`) and `:latest`, built and
+Images are tagged by version (`:0.1.21`) and `:latest`, built and
 published automatically on every release.
 
 ## Why not just fix ovos-cli-client / neon-cli-client?

ovos_tui_client/app.py

@@ -995,23 +995,22 @@ def get_system_commands(self, screen: Screen):
         nothing at all) is filtered out below - it's the exact same
         show-help-panel action our own 'Help: Toggle panel' entry
         already calls, so keeping both would just be two entries doing
-        the same thing under different names. 'Screenshot' (titled
-        "Save screenshot" - saves an SVG snapshot of the current
-        terminal view) is deliberately kept: an earlier pass through
-        this file tried to filter it out as "not useful for this
-        tool", but that's been reconsidered - an SVG capture of
-        exactly what's on screen is a genuinely handy way to save or
-        share a specific debugging moment.
-
-        No separate description/help line under any entry - state
-        (checked/unchecked, active/inactive) is embedded directly in
-        the title text instead (e.g. "Log: Source: skills
-        (checked)"), matching how the dynamic Provider-based entries
-        already work. One line per command everywhere, nothing more
-        than necessary shown."""
+        the same thing under different names.
+
+        Textual's own default 'Save screenshot' command is ALSO
+        filtered out here, replaced with our own below - not because
+        the feature isn't wanted (it is), but because Textual's own
+        version saves to the current working directory by default,
+        which real testing confirmed fails with "Failed to save
+        screenshot" whenever that directory isn't writable - reliably
+        the case inside the companion container specifically (WORKDIR
+        /app is root-owned, the container runs as a non-root user).
+        Our replacement passes an explicit, always-writable path
+        (the user's home directory) instead."""
         for cmd in super().get_system_commands(screen):
-            if "help panel" not in cmd.title.lower():
+            if "help panel" not in cmd.title.lower() and cmd.title != "Save screenshot":
                 yield cmd
+        yield SystemCommand("Save screenshot", "", self._save_screenshot)
         yield SystemCommand("Help: Toggle panel", "", self.action_toggle_help_panel)
         yield SystemCommand("Focus: Logs", "", self.action_focus_logs)
         yield SystemCommand("Focus: Conversation", "", self.action_focus_conversation)
@@ -1084,6 +1083,29 @@ def _deselect_all_skills(self) -> None:
             self.skill_enabled[skill_id] = False
         self._rerender_logs()
 
+    def _save_screenshot(self) -> None:
+        """Replacement for Textual's own default 'Save screenshot'
+        command - see get_system_commands()'s docstring for why this
+        exists instead of just using Textual's built-in one directly
+        (it defaults to the current working directory, which real
+        testing confirmed isn't reliably writable, especially inside
+        the companion container). Home directory instead - always
+        exists, always writable by the user running this tool, and is
+        already where this tool keeps its own state (state.py).
+
+        Scheduled via set_timer(), same as Textual's own version -
+        matters because the command palette itself is still visually
+        on screen at the exact moment this callback fires, and would
+        otherwise end up IN the screenshot rather than showing the app
+        underneath it."""
+        def _do_save():
+            try:
+                path = self.deliver_screenshot(path=str(Path.home()))
+                self._write_status(f"Screenshot saved to {path}" if path else "Screenshot saved")
+            except Exception as e:
+                self._write_status(f"Failed to save screenshot: {e}")
+        self.set_timer(0.1, _do_save)
+
     def action_toggle_help_panel(self) -> None:
         """F1 (and 'Help: Toggle panel' in the Command Palette) toggle
         Textual's own built-in HelpPanel - a genuine side panel docked

tests/test_command_palette.py

@@ -315,13 +315,51 @@ async def test_screenshot_command_is_available(tmp_path):
     to be filtered out here as "not useful for this tool" -
     reconsidered: it's a genuinely handy way to save/share a specific
     debugging moment, and Textual already provides it for free, so
-    it's no longer filtered."""
+    it's no longer filtered - though see the next test, it's actually
+    OUR OWN replacement command by this point, not Textual's default
+    one directly (same title, different implementation)."""
     app = _app_with_fake_bus(tmp_path)
     async with app.run_test() as pilot:
         titles = [cmd.title for cmd in app.get_system_commands(app.screen)]
         assert any("screenshot" in t.lower() for t in titles)
 
 
+@pytest.mark.asyncio
+async def test_save_screenshot_uses_home_directory_not_cwd(tmp_path):
+    """Real bug found via live testing: Textual's own default 'Save
+    screenshot' command saves to the current working directory, which
+    isn't reliably writable - confirmed failing inside the companion
+    container specifically (WORKDIR /app is root-owned, container runs
+    as a non-root user), with a real "Failed to save screenshot" error
+    shown to the user. Our own replacement command passes an explicit
+    home-directory path instead - this confirms it does, without
+    actually writing a real screenshot file (deliver_screenshot itself
+    is Textual's own, already-tested machinery, not something this
+    project needs to re-verify)."""
+    from pathlib import Path
+    app = _app_with_fake_bus(tmp_path)
+    async with app.run_test() as pilot:
+        with patch.object(app, "deliver_screenshot", return_value="/home/fake/screenshot.svg") as mock_deliver:
+            app._save_screenshot()
+            await pilot.pause(0.2)  # the real command schedules via set_timer(0.1, ...)
+        mock_deliver.assert_called_once_with(path=str(Path.home()))
+        conv = app.query_one("#conversation", RichLog)
+        text = "\n".join(str(line) for line in conv.lines)
+        assert "screenshot.svg" in text.lower() or "saved" in text.lower()
+
+
+@pytest.mark.asyncio
+async def test_save_screenshot_reports_failure_without_crashing(tmp_path):
+    app = _app_with_fake_bus(tmp_path)
+    async with app.run_test() as pilot:
+        with patch.object(app, "deliver_screenshot", side_effect=OSError("disk full")):
+            app._save_screenshot()
+            await pilot.pause(0.2)  # must not raise
+        conv = app.query_one("#conversation", RichLog)
+        text = "\n".join(str(line) for line in conv.lines)
+        assert "failed" in text.lower()
+
+
 @pytest.mark.asyncio
 async def test_other_textual_defaults_are_not_filtered(tmp_path):
     """Confirms the filter is specific to 'Keys' (redundant with our

version.py

@@ -1,5 +1,5 @@
 VERSION_MAJOR = 0
 VERSION_MINOR = 1
-VERSION_BUILD = 20
+VERSION_BUILD = 21
 VERSION_ALPHA = 0
 # END_VERSION_BLOCK