Commit 8211c78
committed
fix: flaky screenshot test timing - 0.2s pause raced against the command's own 0.1s timer
Confirmed via a real CI failure on Python 3.9 (v0.1.22's tag push):
test_save_screenshot_reports_failure_without_crashing failed there
despite passing locally and on other Python versions - a genuine race,
not a real product bug (the feature itself was separately confirmed
working via live testing in a real container before this release).
Both publish workflows' own separate test runs on the same commit
happened not to hit the same timing loss and passed, so v0.1.22 did
ship correctly - this is purely a test-reliability fix, nothing to
re-release for.
Increased both screenshot tests' pilot.pause() from 0.2s to 1.0s - a
10x margin over the command's own set_timer(0.1, ...) delay, verified
stable across 5 repeated local runs before pushing this time, not
just a single one.1 parent d4c523d commit 8211c78
1 file changed
Lines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
407 | 407 | | |
408 | 408 | | |
409 | 409 | | |
410 | | - | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
411 | 418 | | |
412 | 419 | | |
413 | 420 | | |
| |||
420 | 427 | | |
421 | 428 | | |
422 | 429 | | |
423 | | - | |
| 430 | + | |
424 | 431 | | |
425 | 432 | | |
426 | 433 | | |
| |||
0 commit comments