Skip to content

[From PR #924] Extract shared parse_catalog_opts/1 from duplicate parse_search_tools_opts/parse_list_tools_opts #925

@claude

Description

@claude

Context

Identified during review of PR #924 (feat(mcp): catalog/search-tools deterministic lexical search).

Problem

parse_search_tools_opts/1 (catalog_builtins.ex:382-390) and parse_list_tools_opts/1 (catalog_builtins.ex:412-420) are character-for-character identical. As more catalog builtins with options are added, this duplication will grow.

Suggested Fix

Extract a shared parse_catalog_opts/1 private function and call it from both parse_search_tools_opts/1 and parse_list_tools_opts/1. Mechanical rename/extract with no behavior change.

Benefit

Removes duplication and makes adding future catalog builtins with options simpler.

Metadata

Metadata

Assignees

No one assigned

    Labels

    from-pr-reviewIssue created from PR review feedbackquick-fixTrivial fix, batched by batch-fix workflow

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions