improving test

Author: andrehora

gitevo/application.py

@@ -219,7 +219,7 @@ def _ensure_git_repos(self, repo: str) -> list[str]:
                     raise BadGitRepo(f'{repo} is not a directory')
 
                 # Check if repo is a git dir
-                if self._is_git_dir(repo):
+                if is_git_dir(repo):
                     # print('Local Git repository:', repo)
                     return [repo]
 
@@ -230,7 +230,7 @@ def _ensure_git_repos(self, repo: str) -> list[str]:
                 git_repos = []
                 print('Directory containing multiple Git repositories')
                 for path in paths:
-                    if self._is_git_dir(path):
+                    if is_git_dir(path):
                         print('- Found Git repository:', path)
                         git_repos.append(path)
                     else:
@@ -247,10 +247,6 @@ def _check_registered_metrics(self, metric_info: MetricInfo):
         if metric_info.version_chart_type not in ['donut', 'pie', 'bar', 'hbar']:
             raise BadVersionChart(f'version chart in {metric_info.name} should be donut, pie, bar, or hbar, not {metric_info.version_chart_type}')
 
-    def _is_git_dir(self, project_path):
-        git_path = os.path.join(project_path, '.git')
-        return is_git_dir(git_path)
-    
     def _is_git_remote(self, repo: str) -> bool:
         return repo.startswith(("git@", "https://", "http://", "git://"))
 

gitevo/utils.py

@@ -6,8 +6,12 @@
 from datetime import date
 from gitevo.exceptions import BadGitRepo
 
+def is_git_dir(project_path):
+    git_path = os.path.join(project_path, '.git')
+    return _is_git_dir(git_path)
 
-def is_git_dir(d: str) -> bool:
+
+def _is_git_dir(d: str) -> bool:
     # From GitPython
     if osp.isdir(d):
         if (osp.isdir(osp.join(d, "objects")) or "GIT_OBJECT_DIRECTORY" in os.environ) and osp.isdir(

tests/test_utils.py

@@ -55,8 +55,7 @@ def test_formatted_dates_month():
                                                 '01/2001', '02/2001', '03/2001', '04/2001']
 
 def test_is_git_dir(local_repo):
-    git_repo = os.path.join(local_repo, '.git')
-    assert is_git_dir(git_repo)
+    assert is_git_dir(local_repo)
 
 def test_is_notgit_dir():
     assert not is_git_dir('gitevo')