hasPermission now supports Android

Author: andrehtissot

ionic/FCM.d.ts

@@ -56,7 +56,7 @@ export declare class FCMPluginOnIonic {
      */
     getToken(): Promise<string>;
     /**
-     * Checking for permissions on iOS. On android, it always returns `true`.
+     * Checking for permissions.
      *
      * @returns {Promise<boolean | null>} Returns a Promise of:
      * - true: push was allowed (or platform is android)

ionic/ngx/FCM.d.ts

@@ -67,7 +67,7 @@ export declare class FCM {
      */
     getToken(): Promise<string>;
     /**
-     * Checking for permissions on iOS. On android, it always returns `true`.
+     * Checking for permissions.
      *
      * @returns {Promise<boolean | null>} Returns a Promise of:
      * - true: push was allowed (or platform is android)

ionic/v4/FCM.d.ts

@@ -56,7 +56,7 @@ export declare class FCM {
      */
     getToken(): Promise<string>;
     /**
-     * Checking for permissions on iOS. On android, it always returns `true`.
+     * Checking for permissions.
      *
      * @returns {Promise<boolean | null>} Returns a Promise of:
      * - true: push was allowed (or platform is android)

src/android/com/gae/scaffolder/plugin/FCMPlugin.java

@@ -1,5 +1,6 @@
 package com.gae.scaffolder.plugin;
 
+import androidx.core.app.NotificationManagerCompat;
 import android.app.NotificationManager;
 import android.content.Context;
 import android.util.Log;
@@ -137,6 +138,8 @@ public void run() {
                 });
             } else if (action.equals("deleteInstanceId")) {
                 this.deleteInstanceId(callbackContext);
+            } else if (action.equals("hasPermission")) {
+                this.hasPermission(callbackContext);
             } else {
                 callbackContext.error("Method not found");
                 return false;
@@ -230,6 +233,20 @@ public void run() {
         });
     }
 
+    private void hasPermission(final CallbackContext callbackContext) {
+        cordova.getThreadPool().execute(new Runnable() {
+            public void run() {
+                try {
+                    NotificationManagerCompat notificationManagerCompat =
+                        NotificationManagerCompat.from(cordova.getActivity().getApplicationContext());
+                    callbackContext.success(notificationManagerCompat.areNotificationsEnabled() ? 1 : 0);
+                } catch (Exception e) {
+                    callbackContext.error(e.getMessage());
+                }
+            }
+        });
+    }
+
     private JSONObject exceptionToJson(final Exception exception) throws JSONException {
         return new JSONObject() {
             {

src/www/FCMPlugin.ts

@@ -113,17 +113,17 @@ export class FCMPlugin {
     }
 
     /**
-     * Checking for permissions on iOS. On android, it always returns `true`.
+     * Checking for permissions.
      *
      * @returns {Promise<boolean | null>} Returns a Promise of:
      * - true: push was allowed (or platform is android)
      * - false: push will not be available
      * - null: still not answered, recommended checking again later.
      */
     public hasPermission(): Promise<boolean> {
-        return window.cordova.platformId !== 'ios'
-            ? Promise.resolve(true)
-            : execAsPromise('hasPermission')
+        return window.cordova.platformId === 'ios'
+            ? execAsPromise('hasPermission')
+            : execAsPromise('hasPermission').then((value) => !!value)
     }
 
     /**

typings/FCMPlugin.d.ts

@@ -68,7 +68,7 @@ export declare class FCMPlugin {
      */
     getToken(): Promise<string>;
     /**
-     * Checking for permissions on iOS. On android, it always returns `true`.
+     * Checking for permissions.
      *
      * @returns {Promise<boolean | null>} Returns a Promise of:
      * - true: push was allowed (or platform is android)

www/FCMPlugin.js

@@ -68,9 +68,9 @@ var FCMPlugin = (function () {
         return execAsPromise('getToken');
     };
     FCMPlugin.prototype.hasPermission = function () {
-        return window.cordova.platformId !== 'ios'
-            ? Promise.resolve(true)
-            : execAsPromise('hasPermission');
+        return window.cordova.platformId === 'ios'
+            ? execAsPromise('hasPermission')
+            : execAsPromise('hasPermission').then(function (value) { return !!value; });
     };
     FCMPlugin.prototype.onNotification = function (callback, options) {
         return asDisposableListener(this.eventTarget, 'notification', callback, options);