[BUG] <Loss of pokemon>

[Gonzi14]

Describe the bug

I had 3 pokemon disappear from OpenHome, i know this because i made a copy of the storage and in the pokedex function of the app it says that i saw them.

The pokemons were Sunkern, Mienfoo and
Mienshao

Steps to reproduce

I do not know

Expected behavior

No response

Screenshots

No response

Save file

No response

Platform

Arch Linux

Version

1.7.1

Additional context

No response

[andrewbenington]

Hopefully this is fixed with v1.8.1. If not, let me know here and I can work with you to recover them. The download for the new version should be available here within an hour or so.

[Gonzi14]

Hi, ive been trying to run the v1.8.1 in my arch linux setup as well as in my windows 11 setup, none would work. Ive tried to go back to 1.7 and it worked on both of them.

What i saw digging in the json files is that the pokemon missing where in the 'mons' folder, but they werent in the 'box-data.json' or 'banks.json', so my hypothesis is that when im moving around the pokemon, sorting them and then saving the boxes, there is the possibility of overwritting them. Since i dont know much about coding, less in Rust, dont take my word for it, maybe im saying gibberish.

Right now im more worried by not being able to use the v1.8.1, i dont know if maybe its just me since i saw you guys took the #416 bug and worked it out. (EDIT: i updated to 1.8.1 and it runs perfectly, but the pokemon are still missing, they are still in the mons folder, but they dont appear in the json file, but the fix is as simple as rewriting the json files i guess ).

Anyway, happy christmas!

[Gonzi14]

Hi again, ive done a little experiment, ive made a program to see the pokemons that are in the folder "mons_v2" and are not on the "banks.json" file and this are the results:

0001-bb9af838-cb1cec95-2c
0128-4dbf0a52-5b86ae71-04
0128-e0b30b98-f79a078f-32
0132-e0b30b98-148532dc-32
0133-b4162781-86551e94-2f
0145-2258e11d-4fc28c8d-22
0172-b4162781-a465ff2f-2f
0191-4dbf0a52-da3738ea-04
0201-4dbf0a52-9681c665-04
0246-4dbf0a52-599ec9a2-04
0265-b4162781-0951b6ae-2c
0273-2258e11d-0ca4cfea-22
0333-3ac0498f-0dbd7efe-22
0371-2258e11d-6605a542-22
0436-3ac0498f-bfcccc8d-22
0439-b4162781-77fd5c97-2c
0459-3ac0498f-9ce9efab-22
0548-e0b30b98-91f49f90-32
0619-bb9af838-2a70487c-2c
0619-bb9af838-a25bd947-2c
0661-3ac0498f-2ab459f0-22
0661-e0b30b98-36e2d8b6-32
0803-3ac0498f-8ee20252-22
0810-e0b30b98-6b5e1109-22
0813-e0b30b98-b701727f-22
0816-2258e11d-73bc3bf7-22
0896-bb9af838-ef080688-2c

so... a couple. What i've done is also just put them manually on banks.json and box-data.json and it worked! Of course, i havent found the reason why this ones and not others, they are all from different games, different species, different types, different levels, so i dont know why. But the good news is that they arent lost, just not on the boxes.

I wish you all a happy new year!

[andrewbenington]

I think you're right about how the overwriting happened during sorting + moving. I'm not sure if this is still a live bug in the app or if it was a side effect of using the app after the initial v1.8.0 bug, but regardless you are correct in that the actual Pokémon data is still preserved in the mons folder, and they just lose their position in the boxes.

I'm glad you were able to manually edit the JSON to get them back in your boxes. Please let me know if you run into this bug again in the future, because that means there is still an issue with either the moving or the saving logic.

In the meantime, I've put some ideas for a recovery feature in #428, so Pokémon could be forcibly returned to the boxes without needing to edit the JSON

Have a happy New Year!

[Gonzi14]

Hello and good night, i hope you guys have a great new start of the year. Im afraid that the glitch is before the 1.8.0 update, because i first noticed that pokemon where missing in the 1.7, but i dismissed it as forgetting to put them in the boxes. Of course i will keep track of my pokemon and run the little code i wrote to see if any pokemon would go missing to see if we can gather more data from this glitch.

I will add a little suggestion in #428!