[FEAT] Pokémon Recovery Tools

[andrewbenington]

Is your feature request related to a problem?

It would be useful to have a way to forcibly "recover" a Pokémon, as in place a tracked Pokémon in an OpenHome box that was either removed from the boxes due to a glitch (i.e. #415) or was moved to a save file that has been lost.

This would probably be an option on the Tracked Pokémon tab, as that is where all tracked Pokémon can already be viewed, regardless of whether they are present in an OpenHome box.

Describe the solution you'd like

Some ideas:

• Whether or not a tracked Pokémon is in an OpenHome box should be visually indicated on the Tracked Pokémon tab
• Only Pokémon not present in an OpenHome box will be allowed to be "Recovered"
• Because forcibly recovering a Pokémon that was sent to a save file would result in a duplicate if that mon was later moved out of the save, logic to handle duplicate mons in general should be fleshed out
  • If a save file is opened that contains mons that are also present in OpenHome boxes, the user should be prompted on whether to keep the save file version, the OpenHome box version, or merge one into the other
    • If merging, one should still be selected as the "more up-to-date" version to determine how certain values are decided. For example, if both versions have different EV spreads, the "more up-to-date" one will have its EVs used
    • This should also happen on launch if the OpenHome boxes contain any duplicates
    • There could possibly be the option to keep both as separate mons, which I believe would require changing one mon's personality value
• OpenHome could also check if the save file is still present with the Pokémon, and retrieve it from the save file if so instead of forcibly recovering it

Additional context

No response

[Gonzi14]

Hi, i think its a great idea, especially since you could already use the code of seeing if a save file is missing (think of the grey save files when trying to open one), and so if a tracked pokemon where in there you should be able to "retrieve it" by duplicating it.
Adding the automatic save/merge duplications would really help, but not forget to implement it with different banks, so if i have the same save file 2 times, i could theoretically put both of the same pokemons in different banks and get away with it, but without that, the system you thought of is pretty good!

[andrewbenington]

Yep, this will need to happen across banks. Thanks for your feedback! I plan on starting on this soon