Skip to content

Conversation

@srescio
Copy link

@srescio srescio commented Sep 22, 2024

bump pyuhoo version library with temperature unit fetch fix
andrewleech/pyuhoo#1

address homeassistant deprecation warnings

this should go after the librarty fix is merged: andrewleech/pyuhoo#1
also, library is merged the followings should be amended accordingly to point to the updated lib fork:

  1. https://github.com/andrewleech/uhoo-homeassistant/pull/6/files#diff-b808cc0cc914f78642ccc21071fa4b969292fd14fe1c9916663ff1d3a2fb2b34R11
  2. https://github.com/andrewleech/uhoo-homeassistant/pull/6/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R12

@srescio
Copy link
Author

srescio commented Sep 23, 2024

currently struggling with poetry taking literally forever to updated the lockfile... 🐌

@srescio srescio marked this pull request as ready for review September 29, 2024 09:34
@srescio
Copy link
Author

srescio commented Oct 6, 2024

currently struggling with poetry taking literally forever to updated the lockfile... 🐌

solved now, @andrewleech when you have time you can use this branch to test out the library changes 🤞🏻

@andrewleech andrewleech force-pushed the fix-failed-setup branch 9 times, most recently from 0a334e8 to 142f7ee Compare February 8, 2025 09:45
srescio and others added 12 commits February 9, 2025 07:07
…ents/uhoo/pyuhoo

subrepo:
  subdir:   "custom_components/uhoo/pyuhoo"
  merged:   "777e240"
upstream:
  origin:   "[email protected]:andrewleech/pyuhoo.git"
  branch:   "client_id"
  commit:   "777e240"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"
subrepo:
  subdir:   "custom_components/uhoo/pyuhoo"
  merged:   "139d0f2"
upstream:
  origin:   "[email protected]:andrewleech/pyuhoo.git"
  branch:   "client_id"
  commit:   "139d0f2"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"
@andrewleech
Copy link
Owner

Thanks again for your efforts @srescio and sorry it's taken me so long to get to it.

To make it easier to test I've included the updated pyrepo in this repo with git subrepo while it took me a couple of goes to set it up correctly I think it'll make maintenance and testing ink future much easier.

I've also replaced the poetry usage with standard pyproject.toml so it works with standard pop and/or my preferred uv for development venv setup.

I'm not sure if all current issues are resolved; after running for a while mine seems to start failing with a Forbidden error but we can address that later, I'll merge this as is and get a release tag set.

@andrewleech andrewleech merged commit f5ef04a into andrewleech:client_id Feb 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants