Flip polarity, and rename file

Author: andrewlock

…Tests/OverloadResolutionPriorityTests.cs …s.IntegrationTests/PolyfillAttributes.cstests/NetEscapades.EnumGenerators.IntegrationTests/OverloadResolutionPriorityTests.cs renamed to tests/NetEscapades.EnumGenerators.IntegrationTests/PolyfillAttributes.cs tests/NetEscapades.EnumGenerators.IntegrationTests/OverloadResolutionPriorityTests.cs renamed to tests/NetEscapades.EnumGenerators.IntegrationTests/PolyfillAttributes.cs

@@ -19,7 +19,7 @@
 
   <ItemGroup>
     <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\Enums.cs" Link="%(Filename)%(Extension)" />
-    <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\OverloadResolutionPriorityTests.cs" Link="%(Filename)%(Extension)" />
+    <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\PolyfillAttributes.cs" Link="%(Filename)%(Extension)" />
   </ItemGroup>
 
   <ItemGroup>

tests/NetEscapades.EnumGenerators.NetStandard.SystemMemory/NetEscapades.EnumGenerators.NetStandard.SystemMemory.csproj

@@ -17,7 +17,7 @@
 
   <ItemGroup>
     <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\Enums.cs" Link="%(Filename)%(Extension)" />
-    <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\OverloadResolutionPriorityTests.cs" Link="%(Filename)%(Extension)" />
+    <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\PolyfillAttributes.cs" Link="%(Filename)%(Extension)" />
   </ItemGroup>
 
   <ItemGroup>

tests/NetEscapades.EnumGenerators.NetStandard/NetEscapades.EnumGenerators.NetStandard.csproj

@@ -17,7 +17,7 @@
 
   <ItemGroup>
     <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\Enums.cs" Link="%(Filename)%(Extension)" />
-    <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\OverloadResolutionPriorityTests.cs" Link="%(Filename)%(Extension)" />
+    <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\PolyfillAttributes.cs" Link="%(Filename)%(Extension)" />
   </ItemGroup>
 
   <ItemGroup>

tests/NetEscapades.EnumGenerators.Nuget.NetStandard.SystemMemory.PrivateAssets/NetEscapades.EnumGenerators.Nuget.NetStandard.SystemMemory.PrivateAssets.csproj

@@ -17,7 +17,7 @@
 
   <ItemGroup>
     <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\Enums.cs" Link="%(Filename)%(Extension)" />
-    <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\OverloadResolutionPriorityTests.cs" Link="%(Filename)%(Extension)" />
+    <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\PolyfillAttributes.cs" Link="%(Filename)%(Extension)" />
   </ItemGroup>
 
   <ItemGroup>

tests/NetEscapades.EnumGenerators.Nuget.NetStandard.SystemMemory/NetEscapades.EnumGenerators.Nuget.NetStandard.SystemMemory.csproj

@@ -17,7 +17,7 @@
 
   <ItemGroup>
     <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\Enums.cs" Link="%(Filename)%(Extension)" />
-    <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\OverloadResolutionPriorityTests.cs" Link="%(Filename)%(Extension)" />
+    <Compile Include="..\NetEscapades.EnumGenerators.IntegrationTests\PolyfillAttributes.cs" Link="%(Filename)%(Extension)" />
   </ItemGroup>
 
   <ItemGroup>

tests/NetEscapades.EnumGenerators.Nuget.NetStandard/NetEscapades.EnumGenerators.Nuget.NetStandard.csproj

@@ -915,7 +915,7 @@ public void Test()
             }
             """;
 
-        var (diagnostics, output) = TestHelpers.GetGeneratedOutput(Generators(), new(LanguageVersion.CSharp13, null, null, [input], null, ExcludeOverloadResolutionPriority: true));
+        var (diagnostics, output) = TestHelpers.GetGeneratedOutput(Generators(), new(LanguageVersion.CSharp13, null, null, [input], null, IncludeOverloadResolutionPriority: false));
         Assert.Contains(diagnostics, d => d.Id == "CS0121");
         return Verifier.Verify(output, Settings());
     }

tests/NetEscapades.EnumGenerators.Tests/EnumGeneratorTests.cs

@@ -136,7 +136,7 @@ private static (ImmutableArray<Diagnostic> Diagnostics, ImmutableArray<SyntaxTre
 
         // Ensure OverloadResolutionPriorityAttribute is always available in the test compilation,
         // even on older TFMs where it's not in the framework. This keeps snapshot output consistent.
-        if (!opts.ExcludeOverloadResolutionPriority
+        if (opts.IncludeOverloadResolutionPriority
             && compilation.GetTypeByMetadataName("System.Runtime.CompilerServices.OverloadResolutionPriorityAttribute") is null)
         {
             var polyfillParseOptions = new CSharpParseOptions(opts.LanguageVersion)
@@ -390,14 +390,14 @@ public Options(LanguageVersion LanguageVersion,
             Dictionary<string, string>? Features,
             string[] Sources,
             string[]? Stages,
-            bool ExcludeOverloadResolutionPriority = false)
+            bool IncludeOverloadResolutionPriority = true)
         {
             this.LanguageVersion = LanguageVersion;
             this.AnalyzerOptions = AnalyzerOptions;
             this.Features = Features;
             this.Sources = Sources;
             this.Stages = Stages;
-            this.ExcludeOverloadResolutionPriority = ExcludeOverloadResolutionPriority;
+            this.IncludeOverloadResolutionPriority = IncludeOverloadResolutionPriority;
         }
 
         public AnalyzerConfigOptionsProvider? OptionsProvider =>
@@ -408,7 +408,7 @@ public Options(LanguageVersion LanguageVersion,
         public Dictionary<string, string>? Features { get; }
         public string[] Sources { get; }
         public string[]? Stages { get; }
-        public bool ExcludeOverloadResolutionPriority { get; }
+        public bool IncludeOverloadResolutionPriority { get; }
 
     }
 }