Change how the usage analyzers are enabled to use an EnumGenerator_EnableUsageAnalyzers MSBuild property instead

Author: andrewlock

README.md

@@ -285,14 +285,15 @@ _NetEscapades.EnumGenerators_ includes optional analyzers that encourage the use
 
 ### Enabling the analyzers
 
-The usage analyzers are disabled by default. To enable them, [add a `.globalconfig` file](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/configuration-files#global-analyzerconfig) to your project with the following content:
+The usage analyzers are disabled by default. To enable them, set the `EnumGenerator_EnableUsageAnalyzers` MSBuild property to `true` in your project:
 
-```ini
-is_global = true
-netescapades.enumgenerators.usage_analyzers.enable = true
+```xml
+<PropertyGroup>
+  <EnumGenerator_EnableUsageAnalyzers>true</EnumGenerator_EnableUsageAnalyzers>
+</PropertyGroup>
 ```
 
-Your project should automatically detect this configuration file, and enable all the usage analyzers with the default severity of `Warning`.
+After adding this configuration, the analyzers in your project should be enabled with the default severity of `Warning`.
 
 ### Configuring analyzer severity (optional)
 

src/NetEscapades.EnumGenerators/Diagnostics/UsageAnalyzers/GetNamesAnalyzer.cs

@@ -21,7 +21,7 @@ public class GetNamesAnalyzer : DiagnosticAnalyzer
         isEnabledByDefault: true);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
-        => ImmutableArray.Create(Rule, UsageAnalyzerConfig.ConfigDescriptor);
+        => ImmutableArray.Create(Rule);
 
     public override void Initialize(AnalysisContext context)
     {

src/NetEscapades.EnumGenerators/Diagnostics/UsageAnalyzers/GetValuesAnalyzer.cs

@@ -21,7 +21,7 @@ public class GetValuesAnalyzer : DiagnosticAnalyzer
         isEnabledByDefault: true);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
-        => ImmutableArray.Create(Rule, UsageAnalyzerConfig.ConfigDescriptor);
+        => ImmutableArray.Create(Rule);
 
     public override void Initialize(AnalysisContext context)
     {

src/NetEscapades.EnumGenerators/Diagnostics/UsageAnalyzers/GetValuesAsUnderlyingTypeAnalyzer.cs

@@ -21,7 +21,7 @@ public class GetValuesAsUnderlyingTypeAnalyzer : DiagnosticAnalyzer
         isEnabledByDefault: true);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
-        => ImmutableArray.Create(Rule, UsageAnalyzerConfig.ConfigDescriptor);
+        => ImmutableArray.Create(Rule);
 
     public override void Initialize(AnalysisContext context)
     {

src/NetEscapades.EnumGenerators/Diagnostics/UsageAnalyzers/HasFlagAnalyzer.cs

@@ -21,7 +21,7 @@ public class HasFlagAnalyzer : DiagnosticAnalyzer
         isEnabledByDefault: true);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
-        => ImmutableArray.Create(Rule, UsageAnalyzerConfig.ConfigDescriptor);
+        => ImmutableArray.Create(Rule);
 
     public override void Initialize(AnalysisContext context)
     {

src/NetEscapades.EnumGenerators/Diagnostics/UsageAnalyzers/IsDefinedAnalyzer.cs

@@ -21,7 +21,7 @@ public class IsDefinedAnalyzer : DiagnosticAnalyzer
         isEnabledByDefault: true);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
-        => ImmutableArray.Create(Rule, UsageAnalyzerConfig.ConfigDescriptor);
+        => ImmutableArray.Create(Rule);
 
     public override void Initialize(AnalysisContext context)
     {

src/NetEscapades.EnumGenerators/Diagnostics/UsageAnalyzers/ParseAnalyzer.cs

@@ -21,7 +21,7 @@ public class ParseAnalyzer : DiagnosticAnalyzer
         isEnabledByDefault: true);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
-        => ImmutableArray.Create(Rule, UsageAnalyzerConfig.ConfigDescriptor);
+        => ImmutableArray.Create(Rule);
 
     public override void Initialize(AnalysisContext context)
     {

src/NetEscapades.EnumGenerators/Diagnostics/UsageAnalyzers/ToStringAnalyzer.cs

@@ -21,7 +21,7 @@ public class ToStringAnalyzer : DiagnosticAnalyzer
         isEnabledByDefault: true);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
-        => ImmutableArray.Create(Rule, UsageAnalyzerConfig.ConfigDescriptor);
+        => ImmutableArray.Create(Rule);
 
     public override void Initialize(AnalysisContext context)
     {

src/NetEscapades.EnumGenerators/Diagnostics/UsageAnalyzers/TryParseAnalyzer.cs

@@ -21,7 +21,7 @@ public class TryParseAnalyzer : DiagnosticAnalyzer
         isEnabledByDefault: true);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
-        => ImmutableArray.Create(Rule, UsageAnalyzerConfig.ConfigDescriptor);
+        => ImmutableArray.Create(Rule);
 
     public override void Initialize(AnalysisContext context)
     {

src/NetEscapades.EnumGenerators/Diagnostics/UsageAnalyzers/UsageAnalyzerConfig.cs

@@ -6,27 +6,7 @@ namespace NetEscapades.EnumGenerators.Diagnostics.UsageAnalyzers;
 public static class UsageAnalyzerConfig
 {
     public const DiagnosticSeverity DefaultSeverity = DiagnosticSeverity.Warning;
-    public const string EnableKey = "netescapades.enumgenerators.usage_analyzers.enable";
-
-    internal static readonly DiagnosticDescriptor ConfigDescriptor = new(
-#pragma warning disable RS2008 // Enable Analyzer Release Tracking
-        id: "NEEGCONFIG001",
-#pragma warning restore RS2008
-        title: "Enable callsite analyzers for generated enum extensions",
-        messageFormat:
-        "Enable analyzers to encourage use of generated extension methods instead of System.Enum methods",
-        category: "Configuration",
-        defaultSeverity: DiagnosticSeverity.Hidden,
-        isEnabledByDefault: true,
-        customTags:
-        [
-            "EditorConfigOption",
-            "EditorConfigOptionKey=netescapades.enumgenerators.usage_analyzers.enable",
-            "EditorConfigOptionDescription=Enable callsite analyzers for generated enum extensions",
-            "EditorConfigOptionAllowedValues=true,false",
-            "EditorConfigOptionDefault=false",
-            WellKnownDiagnosticTags.NotConfigurable
-        ]);
+    public const string EnableKey = "build_property.EnumGenerator_EnableUsageAnalyzers";
 
     internal static bool IsEnabled(AnalyzerOptions context)
         => context.AnalyzerConfigOptionsProvider.GlobalOptions.TryGetValue(EnableKey, out var value) &&