[webhooks] improve device id validation error message

capcom6 · capcom6 · commit 2b36e2dc2489 · 2025-05-17T07:15:00.000+07:00
diff --git a/internal/sms-gateway/modules/webhooks/service.go b/internal/sms-gateway/modules/webhooks/service.go
@@ -82,7 +82,7 @@ func (s *Service) Replace(userID string, webhook smsgateway.Webhook) error {
 			return fmt.Errorf("failed to select devices: %w", err)
 		}
 		if !ok {
-			return devices.ErrNotFound
+			return newValidationError("device_id", *webhook.DeviceID, devices.ErrNotFound)
 		}
 	}
 
diff --git a/pkg/swagger/docs/requests.http b/pkg/swagger/docs/requests.http
@@ -90,6 +90,7 @@ Content-Type: application/json
 
 {
     "id": "MYofX8bTd5Bov0wWFZLRP",
+    "deviceId": "C0ZGtCNf7-sXTbCtF6JXm",
     "url": "https://webhook.site/280a6655-eb68-40b9-b857-af5be37c5303",
     "event": "sms:received"
 }

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ func (s *Service) Replace(userID string, webhook smsgateway.Webhook) error {`
`82`	`82`	`return fmt.Errorf("failed to select devices: %w", err)`
`83`	`83`	`}`
`84`	`84`	`if !ok {`
`85`		`- return devices.ErrNotFound`
	`85`	`+ return newValidationError("device_id", *webhook.DeviceID, devices.ErrNotFound)`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ Content-Type: application/json`
`90`	`90`
`91`	`91`	`{`
`92`	`92`	`"id": "MYofX8bTd5Bov0wWFZLRP",`
	`93`	`+ "deviceId": "C0ZGtCNf7-sXTbCtF6JXm",`
`93`	`94`	`"url": "https://webhook.site/280a6655-eb68-40b9-b857-af5be37c5303",`
`94`	`95`	`"event": "sms:received"`
`95`	`96`	`}`