feat(kustomize): use LabelTransformer instead of deprecated commonLabels

This is a "piece" of a more comprehensive/interesting PR:
- opendatahub-io#1015

Unfortunately, that PR has grown wildly unwieldy in its size - and immediate feedback received was to try to break it into smaller pieces - so consider this one piece!

The ulitmate goal here on this targetted PR is two-fold:
- standardization irrespective of image build "flavour" our kustomize labelling
- get rid of following warning:

```
$ kubectl kustomize jupyter/minimal/ubi9-python-3.11/kustomize/base
...
```

No actual changes are introduced in this PR - simply leveraging the `LabelTransformer` to accomplish what `commonLabels` was previously doing.

Related-to: https://issues.redhat.com/browse/RHOAIENG-23291

Author: andyatmiami

codeserver/ubi9-python-3.11/kustomize/base/kustomization.yaml

@@ -4,6 +4,8 @@ kind: Kustomization
 namePrefix: codeserver-
 resources:
   - pod.yaml
+transformers:
+  - labels.yaml
 images:
   - name: codeserver-workbench
     newName: quay.io/opendatahub/workbench-images

codeserver/ubi9-python-3.11/kustomize/base/labels.yaml

@@ -0,0 +1,14 @@
+---
+apiVersion: builtin
+kind: LabelTransformer
+metadata:
+  name: add-labels
+labels:
+  app: codeserver-image
+fieldSpecs:
+  - path: metadata/labels
+    create: true
+  - path: spec/template/metadata/labels
+    create: false
+  - path: spec/selector/matchLabels
+    create: false

codeserver/ubi9-python-3.11/kustomize/base/pod.yaml

@@ -3,8 +3,6 @@ apiVersion: v1
 kind: Pod
 metadata:
   name: pod
-  labels:
-    app: codeserver-image
 spec:
   containers:
     - name: codeserver

jupyter/datascience/ubi9-python-3.11/kustomize/base/kustomization.yaml

@@ -2,11 +2,11 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 namePrefix: jupyter-datascience-ubi9-python-3-11-
-commonLabels:
-  app: jupyter-datascience-ubi9-python-3-11
 resources:
   - service.yaml
   - statefulset.yaml
+transformers:
+  - labels.yaml
 images:
   - name: quay.io/opendatahub/workbench-images
     newName: quay.io/opendatahub/workbench-images

jupyter/datascience/ubi9-python-3.11/kustomize/base/labels.yaml

@@ -0,0 +1,14 @@
+---
+apiVersion: builtin
+kind: LabelTransformer
+metadata:
+  name: add-labels
+labels:
+  app: jupyter-datascience-ubi9-python-3-11
+fieldSpecs:
+  - path: metadata/labels
+    create: true
+  - path: spec/template/metadata/labels
+    create: false
+  - path: spec/selector/matchLabels
+    create: false

jupyter/datascience/ubi9-python-3.11/kustomize/base/statefulset.yaml

@@ -9,7 +9,8 @@ metadata:
     opendatahub.io/user: jovyan
 spec:
   replicas: 1
-  selector: {}
+  selector:
+    matchLabels: {}
   serviceName: notebook
   template:
     metadata:

jupyter/minimal/ubi9-python-3.11/kustomize/base/kustomization.yaml

@@ -2,11 +2,11 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 namePrefix: jupyter-minimal-ubi9-python-3-11-
-commonLabels:
-  app: jupyter-minimal-ubi9-python-3-11
 resources:
   - service.yaml
   - statefulset.yaml
+transformers:
+  - labels.yaml
 images:
   - name: quay.io/opendatahub/workbench-images
     newName: quay.io/opendatahub/workbench-images

jupyter/minimal/ubi9-python-3.11/kustomize/base/labels.yaml

@@ -0,0 +1,14 @@
+---
+apiVersion: builtin
+kind: LabelTransformer
+metadata:
+  name: add-labels
+labels:
+  app: jupyter-minimal-ubi9-python-3-11
+fieldSpecs:
+  - path: metadata/labels
+    create: true
+  - path: spec/template/metadata/labels
+    create: false
+  - path: spec/selector/matchLabels
+    create: false

jupyter/minimal/ubi9-python-3.11/kustomize/base/statefulset.yaml

@@ -9,7 +9,8 @@ metadata:
     opendatahub.io/user: jovyan
 spec:
   replicas: 1
-  selector: {}
+  selector:
+    matchLabels: {}
   serviceName: notebook
   template:
     metadata:

jupyter/pytorch/ubi9-python-3.11/kustomize/base/kustomization.yaml

@@ -2,11 +2,11 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 namePrefix: jupyter-pytorch-ubi9-python-3-11-
-commonLabels:
-  app: jupyter-pytorch-ubi9-python-3-11
 resources:
   - service.yaml
   - statefulset.yaml
+transformers:
+  - labels.yaml
 images:
   - name: quay.io/opendatahub/workbench-images
     newName: quay.io/opendatahub/workbench-images

jupyter/pytorch/ubi9-python-3.11/kustomize/base/labels.yaml

@@ -0,0 +1,14 @@
+---
+apiVersion: builtin
+kind: LabelTransformer
+metadata:
+  name: add-labels
+labels:
+  app: jupyter-pytorch-ubi9-python-3-11
+fieldSpecs:
+  - path: metadata/labels
+    create: true
+  - path: spec/template/metadata/labels
+    create: false
+  - path: spec/selector/matchLabels
+    create: false

jupyter/pytorch/ubi9-python-3.11/kustomize/base/statefulset.yaml

@@ -9,7 +9,8 @@ metadata:
     opendatahub.io/user: jovyan
 spec:
   replicas: 1
-  selector: {}
+  selector:
+    matchLabels: {}
   serviceName: notebook
   template:
     metadata:

jupyter/rocm/pytorch/ubi9-python-3.11/kustomize/base/kustomization.yaml

@@ -2,11 +2,11 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 namePrefix: jupyter-rocm-pytorch-ubi9-python-3-11-
-commonLabels:
-  app: jupyter-rocm-pytorch-ubi9-python-3-11
 resources:
   - service.yaml
   - statefulset.yaml
+transformers:
+  - labels.yaml
 images:
   - name: quay.io/opendatahub/workbench-images
     newName: quay.io/opendatahub/workbench-images

jupyter/rocm/pytorch/ubi9-python-3.11/kustomize/base/labels.yaml

@@ -0,0 +1,14 @@
+---
+apiVersion: builtin
+kind: LabelTransformer
+metadata:
+  name: add-labels
+labels:
+  app: jupyter-rocm-pytorch-ubi9-python-3-11
+fieldSpecs:
+  - path: metadata/labels
+    create: true
+  - path: spec/template/metadata/labels
+    create: false
+  - path: spec/selector/matchLabels
+    create: false

jupyter/rocm/pytorch/ubi9-python-3.11/kustomize/base/statefulset.yaml

@@ -9,7 +9,8 @@ metadata:
     opendatahub.io/user: jovyan
 spec:
   replicas: 1
-  selector: {}
+  selector:
+    matchLabels: {}
   serviceName: notebook
   template:
     metadata:

jupyter/rocm/tensorflow/ubi9-python-3.11/kustomize/base/kustomization.yaml

@@ -2,11 +2,11 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 namePrefix: jupyter-rocm-tensorflow-ubi9-python-3-11-
-commonLabels:
-  app: jupyter-rocm-tensorflow-ubi9-python-3-11
 resources:
   - service.yaml
   - statefulset.yaml
+transformers:
+  - labels.yaml
 images:
   - name: quay.io/opendatahub/workbench-images
     newName: quay.io/opendatahub/workbench-images

jupyter/rocm/tensorflow/ubi9-python-3.11/kustomize/base/labels.yaml

@@ -0,0 +1,14 @@
+---
+apiVersion: builtin
+kind: LabelTransformer
+metadata:
+  name: add-labels
+labels:
+  app: jupyter-rocm-tensorflow-ubi9-python-3-11
+fieldSpecs:
+  - path: metadata/labels
+    create: true
+  - path: spec/template/metadata/labels
+    create: false
+  - path: spec/selector/matchLabels
+    create: false

jupyter/rocm/tensorflow/ubi9-python-3.11/kustomize/base/statefulset.yaml

@@ -9,7 +9,8 @@ metadata:
     opendatahub.io/user: jovyan
 spec:
   replicas: 1
-  selector: {}
+  selector:
+    matchLabels: {}
   serviceName: notebook
   template:
     metadata:

jupyter/tensorflow/ubi9-python-3.11/kustomize/base/kustomization.yaml

@@ -2,11 +2,11 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 namePrefix: jupyter-tensorflow-ubi9-python-3-11-
-commonLabels:
-  app: jupyter-tensorflow-ubi9-python-3-11
 resources:
   - service.yaml
   - statefulset.yaml
+transformers:
+  - labels.yaml
 images:
   - name: quay.io/opendatahub/workbench-images
     newName: quay.io/opendatahub/workbench-images

jupyter/tensorflow/ubi9-python-3.11/kustomize/base/labels.yaml

@@ -0,0 +1,14 @@
+---
+apiVersion: builtin
+kind: LabelTransformer
+metadata:
+  name: add-labels
+labels:
+  app: jupyter-tensorflow-ubi9-python-3-11
+fieldSpecs:
+  - path: metadata/labels
+    create: true
+  - path: spec/template/metadata/labels
+    create: false
+  - path: spec/selector/matchLabels
+    create: false

jupyter/tensorflow/ubi9-python-3.11/kustomize/base/statefulset.yaml

@@ -9,7 +9,8 @@ metadata:
     opendatahub.io/user: jovyan
 spec:
   replicas: 1
-  selector: {}
+  selector:
+    matchLabels: {}
   serviceName: notebook
   template:
     metadata:

jupyter/trustyai/ubi9-python-3.11/kustomize/base/kustomization.yaml

@@ -2,11 +2,11 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 namePrefix: jupyter-trustyai-ubi9-python-3-11-
-commonLabels:
-  app: jupyter-trustyai-ubi9-python-3-11
 resources:
   - service.yaml
   - statefulset.yaml
+transformers:
+  - labels.yaml
 images:
   - name: quay.io/opendatahub/workbench-images
     newName: quay.io/opendatahub/workbench-images

jupyter/trustyai/ubi9-python-3.11/kustomize/base/labels.yaml

@@ -0,0 +1,14 @@
+---
+apiVersion: builtin
+kind: LabelTransformer
+metadata:
+  name: add-labels
+labels:
+  app: jupyter-trustyai-ubi9-python-3-11
+fieldSpecs:
+  - path: metadata/labels
+    create: true
+  - path: spec/template/metadata/labels
+    create: false
+  - path: spec/selector/matchLabels
+    create: false

jupyter/trustyai/ubi9-python-3.11/kustomize/base/statefulset.yaml

@@ -9,7 +9,8 @@ metadata:
     opendatahub.io/user: jovyan
 spec:
   replicas: 1
-  selector: {}
+  selector:
+    matchLabels: {}
   serviceName: notebook
   template:
     metadata:

manifests/base/kustomization.yaml

@@ -21,9 +21,8 @@ resources:
   - runtime-rocm-tensorflow-imagestream.yaml
   - runtime-tensorflow-imagestream.yaml
 
-commonLabels:
-  opendatahub.io/component: "true"
-  component.opendatahub.io/name: notebooks
+transformers:
+  - labels.yaml
 
 configMapGenerator:
   - name: notebooks-parameters

manifests/base/labels.yaml

@@ -0,0 +1,11 @@
+---
+apiVersion: builtin
+kind: LabelTransformer
+metadata:
+  name: add-labels
+labels:
+  opendatahub.io/component: "true"
+  component.opendatahub.io/name: notebooks
+fieldSpecs:
+  - path: metadata/labels
+    create: true

manifests/overlays/additional/kustomization.yaml

@@ -5,6 +5,5 @@ kind: Kustomization
 resources:
   - ../../base
 
-commonLabels:
-  opendatahub.io/component: "true"
-  component.opendatahub.io/name: notebooks
+transformers:
+  - labels.yaml

manifests/overlays/additional/labels.yaml

@@ -0,0 +1,11 @@
+---
+apiVersion: builtin
+kind: LabelTransformer
+metadata:
+  name: add-labels
+labels:
+  opendatahub.io/component: "true"
+  component.opendatahub.io/name: notebooks
+fieldSpecs:
+  - path: metadata/labels
+    create: true

rstudio/c9s-python-3.11/kustomize/base/kustomization.yaml

@@ -4,6 +4,8 @@ kind: Kustomization
 namePrefix: rstudio-
 resources:
   - pod.yaml
+transformers:
+  - labels.yaml
 images:
   - name: rstudio-workbench
     newName: quay.io/opendatahub/workbench-images

rstudio/c9s-python-3.11/kustomize/base/labels.yaml

@@ -0,0 +1,14 @@
+---
+apiVersion: builtin
+kind: LabelTransformer
+metadata:
+  name: add-labels
+labels:
+  app: rstudio-image
+fieldSpecs:
+  - path: metadata/labels
+    create: true
+  - path: spec/template/metadata/labels
+    create: false
+  - path: spec/selector/matchLabels
+    create: false

rstudio/c9s-python-3.11/kustomize/base/pod.yaml

@@ -3,8 +3,6 @@ apiVersion: v1
 kind: Pod
 metadata:
   name: pod
-  labels:
-    app: rstudio-image
 spec:
   containers:
     - name: rstudio

rstudio/rhel9-python-3.11/kustomize/base/kustomization.yaml

@@ -4,6 +4,8 @@ kind: Kustomization
 namePrefix: rstudio-
 resources:
   - pod.yaml
+transformers:
+  - labels.yaml
 images:
   - name: rstudio-workbench
     newName: quay.io/opendatahub/workbench-images