Start the unattended-upgrades service on every puppet run

[yarikdot]

Checking the unattended-upgrades init script I can see:

start|restart|force-reload|status)
    # nothing, just to keep update-rc.d happy (see debian #630732)
    ;;

Is it then required to have:

service { $package:
    ensure    => running,
    subscribe => [ File[$conf_path], File[$apt_path], Package[$package], ],
}

as it doesn't do anything? It just starts the service on every puppet run:

Notice: /Stage[main]/Unattended_upgrades/Service[unattended-upgrades]/ensure: ensure changed 'stopped' to 'running'
Debug: /Stage[main]/Unattended_upgrades/Service[unattended-upgrades]: The container Class[Unattended_upgrades] will propagate my refresh event
Info: /Stage[main]/Unattended_upgrades/Service[unattended-upgrades]: Unscheduling refresh on Service[unattended-upgrades]

OS: Debian Jessie

[andyleejordan]

Is this a request or a bug or a question? See here.

[yarikdot]

It's a question. I suppose this behavior has some purpose, otherwise it wouldn't be there. If there is no reason to have the service "running", I will prepare a pull request.

[andyleejordan]

At the time this module was written, the service was required to run unattended-upgrades. Please feel free to test if its still required and report your results.

[andyleejordan]

I think @pschichtel is going to open a PR to address this issue. I don't think that there is a reason to have the service running any more, but I don't actively use Puppet any more, so I need a PR with the fix and tests.