Skip to content

Add named search query properties to use in keyword filtering #1

@andymerskin

Description

@andymerskin

It would be awesome to have the ability to specify and pass parameters/properties to a keyword filter.

Example keyword definition for a rating filter:

keywords: {
  rating: {
    queries: [
      '{{count}} stars',
      'rated {{count}}'
      ],
    filter: (collection, {count}) => {
      return collection.filter(item => item.rating >= parseInt(count, 10))
    }    
  }
}

Questions:

  • Should type conversions be handled by the user?
    • We could have it test for a parsed Number, and if true, pass as a number (feels too prescriptive).
      const numCount = parseInt(count)
      return numCount ? numCount : count
    • Users could specify types in the keyword definition. Would be useful for validation before filtering collection.
      {
        queries: ...,
        filter: ...,
        props: {
          count: Number
        }
      }

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions