adapt to biome specific parameters

Author: stathis-alexander

README.md

@@ -1,8 +1,8 @@
 <div align="center">
 
-# asdf-biome [![Build](https://github.com/stathis-alexander/asdf-biome/actions/workflows/build.yml/badge.svg)](https://github.com/stathis-alexander/asdf-biome/actions/workflows/build.yml) [![Lint](https://github.com/stathis-alexander/asdf-biome/actions/workflows/lint.yml/badge.svg)](https://github.com/stathis-alexander/asdf-biome/actions/workflows/lint.yml)
+# asdf-biome [![Build](https://github.com/angellist/asdf-biome/actions/workflows/build.yml/badge.svg)](https://github.com/angellist/asdf-biome/actions/workflows/build.yml) [![Lint](https://github.com/angellist/asdf-biome/actions/workflows/lint.yml/badge.svg)](https://github.com/angellist/asdf-biome/actions/workflows/lint.yml)
 
-[biome](https://github.com/angellist/asdf-biome) plugin for the [asdf version manager](https://asdf-vm.com).
+[biome](https://github.com/biomejs/biome) plugin for the [asdf version manager](https://asdf-vm.com).
 
 </div>
 
@@ -15,10 +15,7 @@
 
 # Dependencies
 
-**TODO: adapt this section**
-
-- `bash`, `curl`, `tar`, and [POSIX utilities](https://pubs.opengroup.org/onlinepubs/9699919799/idx/utilities.html).
-- `SOME_ENV_VAR`: set this environment variable in your shell config to load the correct version of tool x.
+- `bash`, `curl`, and [POSIX utilities](https://pubs.opengroup.org/onlinepubs/9699919799/idx/utilities.html).
 
 # Install
 
@@ -27,7 +24,7 @@ Plugin:
 ```shell
 asdf plugin add biome
 # or
-asdf plugin add biome https://github.com/stathis-alexander/asdf-biome.git
+asdf plugin add biome https://github.com/angellist/asdf-biome.git
 ```
 
 biome:
@@ -53,7 +50,7 @@ install & manage versions.
 
 Contributions of any kind welcome! See the [contributing guide](contributing.md).
 
-[Thanks goes to these contributors](https://github.com/stathis-alexander/asdf-biome/graphs/contributors)!
+[Thanks goes to these contributors](https://github.com/angellist/asdf-biome/graphs/contributors)!
 
 # License
 

bin/download

@@ -10,14 +10,5 @@ source "${plugin_dir}/lib/utils.bash"
 
 mkdir -p "$ASDF_DOWNLOAD_PATH"
 
-# TODO: Adapt this to proper extension and adapt extracting strategy.
-release_file="$ASDF_DOWNLOAD_PATH/$TOOL_NAME-$ASDF_INSTALL_VERSION.tar.gz"
-
 # Download tar.gz file to the download directory
-download_release "$ASDF_INSTALL_VERSION" "$release_file"
-
-#  Extract contents of tar.gz file into the download directory
-tar -xzf "$release_file" -C "$ASDF_DOWNLOAD_PATH" --strip-components=1 || fail "Could not extract $release_file"
-
-# Remove the tar.gz file since we don't need to keep it
-rm "$release_file"
+download_release "$ASDF_INSTALL_VERSION" $(release_file $ASDF_DOWNLOAD_PATH)

bin/latest-stable

@@ -23,7 +23,7 @@ printf "redirect url: %s\n" "$redirect_url" >&2
 if [[ "$redirect_url" == "$GH_REPO/releases" ]]; then
 	version="$(list_all_versions | sort_versions | tail -n1 | xargs echo)"
 else
-	version="$(printf "%s\n" "$redirect_url" | sed 's|.*/tag/v\{0,1\}||')"
+	version="$(printf "%s\n" "$redirect_url" | sed 's|.*/tag/v\{0,1\}||' | sed $CLEAN_RELEASE_REGEX)"
 fi
 
 printf "%s\n" "$version"

contributing.md

@@ -3,10 +3,7 @@
 Testing Locally:
 
 ```shell
-asdf plugin test <plugin-name> <plugin-url> [--asdf-tool-version <version>] [--asdf-plugin-gitref <git-ref>] [test-command*]
-
-# TODO: adapt this
-asdf plugin test biome https://github.com/stathis-alexander/asdf-biome.git "biome --version"
+asdf plugin test biome https://github.com/angellist/asdf-biome.git "biome --version"
 ```
 
 Tests are automatically run in GitHub Actions on push and PR.

lib/utils.bash

@@ -2,10 +2,10 @@
 
 set -euo pipefail
 
-# TODO: Ensure this is the correct GitHub homepage where releases can be downloaded for biome.
-GH_REPO="https://github.com/angellist/asdf-biome"
+GH_REPO="https://github.com/biomejs/biome"
 TOOL_NAME="biome"
 TOOL_TEST="biome --version"
+CLEAN_RELEASE_REGEX='s/^cli\/v//'
 
 fail() {
 	echo -e "asdf-$TOOL_NAME: $*"
@@ -27,22 +27,44 @@ sort_versions() {
 list_github_tags() {
 	git ls-remote --tags --refs "$GH_REPO" |
 		grep -o 'refs/tags/.*' | cut -d/ -f3- |
-		sed 's/^v//' # NOTE: You might want to adapt this sed to remove non-version strings from tags
+		grep -o "cli/v[0-9]\+\.[0-9]\+\.[0-9]\+$" | # Match semantic versioning tags
+		sed $CLEAN_RELEASE_REGEX
 }
 
 list_all_versions() {
-	# TODO: Adapt this. By default we simply list the tag names from GitHub releases.
-	# Change this function if biome has other means of determining installable versions.
 	list_github_tags
 }
 
+binary_suffix() {
+	local suffix
+
+	if [[ "$OSTYPE" == "darwin"* ]]; then
+		suffix="-darwin-arm64"
+	elif [[ "$OSTYPE" == "linux-gnu"* ]]; then
+		suffix="-linux-x64"
+	else
+		fail "Unsupported OS: $OSTYPE"
+	fi
+
+	echo "$suffix"
+}
+
+release_file() {
+	local download_path="$1"
+
+	echo "$download_path/$TOOL_NAME$(binary_suffix)"
+}
+
 download_release() {
 	local version filename url
 	version="$1"
 	filename="$2"
 
-	# TODO: Adapt the release URL convention for biome
-	url="$GH_REPO/archive/v${version}.tar.gz"
+	if [[ "$version" =~ "cli/v[0-9]\+\.[0-9]\+\.[0-9]\+$" ]]; then
+		version="$(echo "$version" | sed 's/^cli\/v//')"
+	fi
+
+	url="$GH_REPO/releases/download/cli/v${version}/biome$(binary_suffix)"
 
 	echo "* Downloading $TOOL_NAME release $version..."
 	curl "${curl_opts[@]}" -o "$filename" -C - "$url" || fail "Could not download $url"
@@ -53,15 +75,12 @@ install_version() {
 	local version="$2"
 	local install_path="${3%/bin}/bin"
 
-	if [ "$install_type" != "version" ]; then
-		fail "asdf-$TOOL_NAME supports release installs only"
-	fi
-
 	(
 		mkdir -p "$install_path"
-		cp -r "$ASDF_DOWNLOAD_PATH"/* "$install_path"
+		mv $(release_file $ASDF_DOWNLOAD_PATH) "$install_path/$TOOL_NAME"
+		chmod +x "$install_path/$TOOL_NAME"
 
-		# TODO: Assert biome executable exists.
+		# Assert biome executable exists.
 		local tool_cmd
 		tool_cmd="$(echo "$TOOL_TEST" | cut -d' ' -f1)"
 		test -x "$install_path/$tool_cmd" || fail "Expected $install_path/$tool_cmd to be executable."