bump tapioca to latest and fix type checking in extended AR compilers

Author: stathis-alexander

.rubocop.yml

@@ -11,6 +11,7 @@ AllCops:
   NewCops: disable
   Exclude:
   - "vendor/**/*"
+  - "sorbet/rbi/**/*"
   Include:
   - "sorbet/rbi/shims/**/*.rbi"
 

Gemfile

@@ -11,6 +11,7 @@ group :development do
   gem "minitest-reporters"
 
   gem "attr_json"
+  gem "graphql"
   gem "kaminari-activerecord"
   gem "money-rails"
   gem "paperclip"

Gemfile.lock

@@ -3,7 +3,7 @@ PATH
   specs:
     boba (0.0.17)
       sorbet-static-and-runtime (~> 0.5)
-      tapioca (<= 0.16.9)
+      tapioca (<= 0.16.11)
 
 GEM
   remote: https://rubygems.org/
@@ -93,8 +93,13 @@ GEM
     date (3.3.4)
     drb (2.2.1)
     erubi (1.13.1)
+    fiber-storage (1.0.0)
     globalid (1.2.1)
       activesupport (>= 6.1)
+    graphql (2.4.10)
+      base64
+      fiber-storage
+      logger
     i18n (1.14.6)
       concurrent-ruby (~> 1.0)
     io-console (0.7.2)
@@ -210,7 +215,7 @@ GEM
       zeitwerk (~> 2.6)
     rainbow (3.1.1)
     rake (13.2.1)
-    rbi (0.2.2)
+    rbi (0.2.4)
       prism (~> 1.0)
       sorbet-runtime (>= 0.5.9204)
     rdoc (6.7.0)
@@ -240,24 +245,25 @@ GEM
       rubocop (>= 1)
     ruby-progressbar (1.13.0)
     securerandom (0.3.1)
-    sorbet (0.5.11742)
-      sorbet-static (= 0.5.11742)
-    sorbet-runtime (0.5.11742)
-    sorbet-static (0.5.11742-universal-darwin)
-    sorbet-static (0.5.11742-x86_64-linux)
-    sorbet-static-and-runtime (0.5.11742)
-      sorbet (= 0.5.11742)
-      sorbet-runtime (= 0.5.11742)
-    spoom (1.5.0)
+    sorbet (0.5.11851)
+      sorbet-static (= 0.5.11851)
+    sorbet-runtime (0.5.11851)
+    sorbet-static (0.5.11851-universal-darwin)
+    sorbet-static (0.5.11851-x86_64-linux)
+    sorbet-static-and-runtime (0.5.11851)
+      sorbet (= 0.5.11851)
+      sorbet-runtime (= 0.5.11851)
+    spoom (1.5.4)
       erubi (>= 1.10.0)
       prism (>= 0.28.0)
+      rbi (>= 0.2.3)
       sorbet-static-and-runtime (>= 0.5.10187)
       thor (>= 0.19.2)
     sqlite3 (2.3.1)
       mini_portile2 (~> 2.8.0)
     state_machines (0.6.0)
     stringio (3.1.1)
-    tapioca (0.16.9)
+    tapioca (0.16.11)
       benchmark
       bundler (>= 2.2.25)
       netrc (>= 0.11.0)
@@ -292,6 +298,7 @@ PLATFORMS
 DEPENDENCIES
   attr_json
   boba!
+  graphql
   kaminari-activerecord
   minitest
   minitest-hooks

boba.gemspec

@@ -28,5 +28,5 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = ">= 3.0.0"
 
   spec.add_dependency("sorbet-static-and-runtime", "~> 0.5")
-  spec.add_dependency("tapioca", "<= 0.16.9")
+  spec.add_dependency("tapioca", "<= 0.16.11")
 end

lib/tapioca/dsl/compilers/active_record_associations_persisted.rb

@@ -1,4 +1,4 @@
-# typed: ignore
+# typed: strict
 # frozen_string_literal: true
 
 require "tapioca/dsl/compilers/active_record_associations"
@@ -54,6 +54,8 @@ module Compilers
       class ActiveRecordAssociationsPersisted < ::Tapioca::Dsl::Compilers::ActiveRecordAssociations
         extend T::Sig
 
+        ConstantType = type_member { { fixed: T.class_of(ActiveRecord::Base) } }
+
         private
 
         sig { returns(Boba::Options::AssociationTypeOption) }

lib/tapioca/dsl/compilers/active_record_columns_persisted.rb

@@ -1,4 +1,4 @@
-# typed: ignore
+# typed: strict
 # frozen_string_literal: true
 
 require "tapioca/dsl/compilers/active_record_columns"
@@ -128,8 +128,11 @@ module Compilers
       class ActiveRecordColumnsPersisted < ::Tapioca::Dsl::Compilers::ActiveRecordColumns
         extend T::Sig
 
+        ConstantType = type_member { { fixed: T.class_of(ActiveRecord::Base) } }
+
         private
 
+        sig { returns(::Tapioca::Dsl::Helpers::ActiveRecordColumnTypeHelper) }
         def column_type_helper
           ::Tapioca::Dsl::Helpers::ActiveRecordColumnTypeHelper.new(
             constant,
@@ -153,9 +156,9 @@ def type_for(attribute_name, column_name = attribute_name)
         def column_type_for(column_name)
           return ["T.untyped", "T.untyped"] if column_type_option.untyped?
 
-          nilable_column = Boba::ActiveRecord::AttributeService.nilable_attribute?(@constant, column_name)
+          nilable_column = Boba::ActiveRecord::AttributeService.nilable_attribute?(constant, column_name)
 
-          column_type = @constant.attribute_types[column_name]
+          column_type = constant.attribute_types[column_name]
           getter_type = column_type_helper.send(
             :type_for_activerecord_value,
             column_type,
@@ -169,7 +172,7 @@ def column_type_for(column_name)
               getter_type
             end
 
-          virtual_attribute = Boba::ActiveRecord::AttributeService.virtual_attribute?(@constant, column_name)
+          virtual_attribute = Boba::ActiveRecord::AttributeService.virtual_attribute?(constant, column_name)
           if column_type_option.persisted? && (virtual_attribute || !nilable_column)
             [getter_type, setter_type]
           else