Use angellist rubocop + autocorrects

Author: chamod-gamage

.rubocop.yml

@@ -1,63 +1,9 @@
-require:
-  - rubocop-rspec
+inherit_gem:
+  rubocop-angellist: rubocop.yml
 
+# Local project tweaks can go below. Keep minimal; rely on shared config.
 AllCops:
-  NewCops: enable
-  TargetRubyVersion: 3.0
   Exclude:
-    - 'vendor/**/*'
-    - 'sorbet/**/*'
-    - 'tmp/**/*'
-
-Style/Documentation:
-  Enabled: false
-
-Style/StringLiterals:
-  EnforcedStyle: single_quotes
-
-Style/FrozenStringLiteralComment:
-  Enabled: true
-
-Layout/LineLength:
-  Max: 120
-
-Metrics/BlockLength:
-  Exclude:
-    - 'spec/**/*'
-    - 'examples/**/*'
-
-Metrics/MethodLength:
-  Max: 20
-  Exclude:
-    - 'spec/**/*'
-
-Metrics/AbcSize:
-  Max: 25
-  Exclude:
-    - 'spec/**/*'
-
-Style/TrailingCommaInArrayLiteral:
-  EnforcedStyleForMultiline: no_comma
-
-Style/TrailingCommaInHashLiteral:
-  EnforcedStyleForMultiline: no_comma
-
-Naming/MethodParameterName:
-  AllowedNames:
-    - io
-    - id
-    - to
-    - by
-    - on
-    - in
-    - at
-
-RSpec/ExampleLength:
-  Max: 15
-
-RSpec/MultipleExpectations:
-  Max: 5
-
-RSpec/NestedGroups:
-  Max: 4
-
+    - "vendor/**/*"
+    - "sorbet/**/*"
+    - "tmp/**/*"

Gemfile

@@ -7,3 +7,7 @@ gemspec
 
 gem 'pry', '~> 0.14'
 gem 'simplecov', '~> 0.22', require: false
+
+group :development do
+  gem 'rubocop-angellist', github: 'angellist/rubocop-angellist'
+end

Rakefile

@@ -8,11 +8,11 @@ RSpec::Core::RakeTask.new(:spec)
 RuboCop::RakeTask.new
 
 desc 'Run Sorbet type checker'
-task :sorbet do
+task sorbet: :environment do
   sh 'bundle exec srb tc'
 end
 
 desc 'Run all checks (tests, linting, type checking)'
-task checks: %i[spec rubocop sorbet]
+task checks: [:spec, :rubocop, :sorbet]
 
 task default: :checks

examples/basic_spreadsheet.rb

@@ -23,19 +23,19 @@
   bg_color: '366092',
   fg_color: 'FFFFFF',
   b: true,
-  alignment: { horizontal: :center }
+  alignment: { horizontal: :center },
 )
 
 document.add_style!(
   :currency,
-  format_code: '$#,##0.00'
+  format_code: '$#,##0.00',
 )
 
 document.add_style!(
   :total,
   b: true,
   format_code: '$#,##0.00',
-  bg_color: 'E7E6E6'
+  bg_color: 'E7E6E6',
 )
 
 # Add header row
@@ -46,15 +46,15 @@
   { month: 'January', sales: 50_000, expenses: 30_000 },
   { month: 'February', sales: 55_000, expenses: 32_000 },
   { month: 'March', sales: 60_000, expenses: 35_000 },
-  { month: 'April', sales: 58_000, expenses: 33_000 }
+  { month: 'April', sales: 58_000, expenses: 33_000 },
 ]
 
 rows = []
 data.each_with_index do |item, index|
   row = sheet.add_row!(:"month_#{index + 1}")
-             .add!(:month, value: item[:month])
-             .add!(:sales, value: item[:sales], style: :currency)
-             .add!(:expenses, value: item[:expenses], style: :currency)
+    .add!(:month, value: item[:month])
+    .add!(:sales, value: item[:sales], style: :currency)
+    .add!(:expenses, value: item[:expenses], style: :currency)
 
   # Profit = Sales - Expenses (formula)
   row.add!(:profit, value: row.ref(:sales) - row.ref(:expenses), style: :currency)
@@ -63,27 +63,27 @@
 
 # Add total row
 total_row = sheet.add_row!(:total)
-                 .add!(:month, value: 'TOTAL', style: :total)
+  .add!(:month, value: 'TOTAL', style: :total)
 
 # Sum all sales
 total_row.add!(
   :sales,
   value: Zaxcel::Functions.sum(Zaxcel::Lang.range(rows.first!.ref(:sales), rows.last!.ref(:sales))),
-  style: :total
+  style: :total,
 )
 
 # Sum all expenses
 total_row.add!(
   :expenses,
   value: Zaxcel::Functions.sum(Zaxcel::Lang.range(rows.first!.ref(:expenses), rows.last!.ref(:expenses))),
-  style: :total
+  style: :total,
 )
 
 # Sum all profit
 total_row.add!(
   :profit,
   value: Zaxcel::Functions.sum(Zaxcel::Lang.range(rows.first!.ref(:profit), rows.last!.ref(:profit))),
-  style: :total
+  style: :total,
 )
 
 # Position rows before generating so references resolve

examples/cross_sheet_references.rb

@@ -24,15 +24,15 @@
   { name: 'Widget A', price: 10.50, stock: 100 },
   { name: 'Widget B', price: 15.75, stock: 75 },
   { name: 'Gadget X', price: 25.00, stock: 50 },
-  { name: 'Gadget Y', price: 30.25, stock: 25 }
+  { name: 'Gadget Y', price: 30.25, stock: 25 },
 ]
 
 product_rows = []
 products.each do |product|
   row = data_sheet.add_row!(product[:name])
-                  .add!(:product, value: product[:name])
-                  .add!(:unit_price, value: product[:price], style: :currency)
-                  .add!(:stock, value: product[:stock])
+    .add!(:product, value: product[:name])
+    .add!(:unit_price, value: product[:price], style: :currency)
+    .add!(:stock, value: product[:stock])
   product_rows << row
 end
 
@@ -51,46 +51,46 @@
 end
 
 summary_sheet.add_row!(:total_inventory)
-             .add!(:metric, value: 'Total Inventory Value')
-             .add!(:value, value: inventory_formula, style: :currency)
+  .add!(:metric, value: 'Total Inventory Value')
+  .add!(:value, value: inventory_formula, style: :currency)
 
 # Average product price
 avg_price = Zaxcel::Functions::Average.new(
   Zaxcel::Lang.range(
     data_sheet.cell_ref(:unit_price, products.first[:name]),
-    data_sheet.cell_ref(:unit_price, products.last[:name])
-  )
+    data_sheet.cell_ref(:unit_price, products.last[:name]),
+  ),
 )
 
 summary_sheet.add_row!(:avg_price)
-             .add!(:metric, value: 'Average Product Price')
-             .add!(:value, value: avg_price, style: :currency)
+  .add!(:metric, value: 'Average Product Price')
+  .add!(:value, value: avg_price, style: :currency)
 
 # Total stock units
 total_stock = Zaxcel::Functions.sum(
   Zaxcel::Lang.range(
     data_sheet.cell_ref(:stock, products.first[:name]),
-    data_sheet.cell_ref(:stock, products.last[:name])
-  )
+    data_sheet.cell_ref(:stock, products.last[:name]),
+  ),
 )
 
 summary_sheet.add_row!(:total_stock)
-             .add!(:metric, value: 'Total Stock Units')
-             .add!(:value, value: total_stock)
+  .add!(:metric, value: 'Total Stock Units')
+  .add!(:value, value: total_stock)
 
 # Most expensive product
 max_price = Zaxcel::Functions::Max.new(
   [
     Zaxcel::Lang.range(
       data_sheet.cell_ref(:unit_price, products.first[:name]),
-      data_sheet.cell_ref(:unit_price, products.last[:name])
-    )
-  ]
+      data_sheet.cell_ref(:unit_price, products.last[:name]),
+    ),
+  ],
 )
 
 summary_sheet.add_row!(:max_price)
-             .add!(:metric, value: 'Highest Price')
-             .add!(:value, value: max_price, style: :currency)
+  .add!(:metric, value: 'Highest Price')
+  .add!(:value, value: max_price, style: :currency)
 
 summary_sheet.position_rows!
 summary_sheet.generate_sheet!

lib/zaxcel/binary_expression.rb

@@ -11,7 +11,7 @@ class Zaxcel::BinaryExpression < Zaxcel::CellFormula
     params(
       operator: String,
       lh_value: Zaxcel::Cell::ValueType,
-      rh_value: Zaxcel::Cell::ValueType
+      rh_value: Zaxcel::Cell::ValueType,
     ).void
   end
   def initialize(operator, lh_value, rh_value)
@@ -33,7 +33,7 @@ def format(on_sheet:)
   sig do
     params(
       value: Zaxcel::Cell::ValueType,
-      on_sheet: String
+      on_sheet: String,
     ).returns(T.any(Numeric, Money, String))
   end
   def format_value(value, on_sheet:)

lib/zaxcel/binary_expressions/addition.rb

@@ -7,7 +7,7 @@ class Zaxcel::BinaryExpressions::Addition < Zaxcel::BinaryExpression
   sig do
     params(
       lh_value: Zaxcel::Cell::ValueType,
-      rh_value: Zaxcel::Cell::ValueType
+      rh_value: Zaxcel::Cell::ValueType,
     ).void
   end
   def initialize(lh_value, rh_value)

lib/zaxcel/binary_expressions/division.rb

@@ -7,7 +7,7 @@ class Zaxcel::BinaryExpressions::Division < Zaxcel::BinaryExpression
   sig do
     params(
       lh_value: Zaxcel::Cell::ValueType,
-      rh_value: Zaxcel::Cell::ValueType
+      rh_value: Zaxcel::Cell::ValueType,
     ).void
   end
   def initialize(lh_value, rh_value)

lib/zaxcel/binary_expressions/multiplication.rb

@@ -7,7 +7,7 @@ class Zaxcel::BinaryExpressions::Multiplication < Zaxcel::BinaryExpression
   sig do
     params(
       lh_value: Zaxcel::Cell::ValueType,
-      rh_value: Zaxcel::Cell::ValueType
+      rh_value: Zaxcel::Cell::ValueType,
     ).void
   end
   def initialize(lh_value, rh_value)

lib/zaxcel/binary_expressions/subtraction.rb

@@ -7,7 +7,7 @@ class Zaxcel::BinaryExpressions::Subtraction < Zaxcel::BinaryExpression
   sig do
     params(
       lh_value: Zaxcel::Cell::ValueType,
-      rh_value: Zaxcel::Cell::ValueType
+      rh_value: Zaxcel::Cell::ValueType,
     ).void
   end
   def initialize(lh_value, rh_value)