Merge pull request #51 from spion/feature/supress-while-type-errors-present

Feature: Supress linter errors while type errors present

Author: angelozerr

README.md

@@ -40,6 +40,7 @@ Your `node_modules` folder should look like this:
  * `ignoreDefinitionFiles` - control if TypeScript definition files should be ignored.
  * `alwaysShowRuleFailuresAsWarnings` - always show rule failures as warnings, ignoring the severity configuration in the tslint.json configuration.
  * `disableNoUnusedVariableRule` - disable `no-unused-variable` rule.
+ * `supressWhileTypeErrorsPresent` - supress tslint errors from being reported while other errors are present.
 
 Here a configuration sample:
 
@@ -51,7 +52,8 @@ Here a configuration sample:
         "alwaysShowRuleFailuresAsWarnings": false,
         "ignoreDefinitionFiles": true,
         "configFile": "../tslint.json",
-        "disableNoUnusedVariableRule": false
+        "disableNoUnusedVariableRule": false,
+        "supressWhileTypeErrorsPresent": false
       }
     ]
   }

src/index.ts

@@ -8,6 +8,7 @@ interface Settings {
     ignoreDefinitionFiles?: boolean;
     configFile?: string;
     disableNoUnusedVariableRule?: boolean  // support to enable/disable the workaround for https://github.com/Microsoft/TypeScript/issues/15344
+    supressWhileTypeErrorsPresent: boolean;
 }
 
 //TODO we "steal"" an error code with a registered code fix. 2515 = implement inherited abstract class
@@ -303,6 +304,10 @@ function init(modules: { typescript: typeof ts_module }) {
         proxy.getSemanticDiagnostics = (fileName: string) => {
             const prior = oldLS.getSemanticDiagnostics(fileName);
 
+            if (config.supressWhileTypeErrorsPresent && prior.length > 0) {
+                return prior;
+            }
+
             try {
                 info.project.projectService.logger.info(`Computing tslint semantic diagnostics...`);
                 if (codeFixActions.has(fileName)) {
@@ -368,7 +373,10 @@ function init(modules: { typescript: typeof ts_module }) {
 
         proxy.getCodeFixesAtPosition = function (fileName: string, start: number, end: number, errorCodes: number[], formatOptions: ts.FormatCodeSettings): ts.CodeAction[] {
             let prior = oldLS.getCodeFixesAtPosition(fileName, start, end, errorCodes, formatOptions);
-  
+            if (config.supressWhileTypeErrorsPresent && prior.length > 0) {
+                return prior;
+            }
+
             info.project.projectService.logger.info("tslint-language-service getCodeFixes " + errorCodes[0]);
             let documentFixes = codeFixActions.get(fileName);
 
@@ -406,4 +414,4 @@ namespace codefix {
         errorCodes: number[];
         getCodeActions(context: any): ts.CodeAction[] | undefined;
     }
-}
+}