Skip to content

Commit ab5ba2d

Browse files
committed
Revert "Memoize QFunctionTableModel::data() (#853)"
This reverts commit b7b7bf7.
1 parent 2aa67c0 commit ab5ba2d

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

angrmanagement/ui/widgets/qfunction_table.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ def __init__(self, workspace, instance, func_list):
5353
self.workspace = workspace
5454
self.instance = instance
5555
self._config = Conf
56-
self._data_cache = {}
5756

5857
def __len__(self):
5958
if self._func_list is not None:
@@ -72,7 +71,6 @@ def func_list(self) -> List["Function"]:
7271
def func_list(self, v):
7372
self._func_list = None
7473
self._raw_func_list = v
75-
self._data_cache.clear()
7674
self.emit(SIGNAL("layoutChanged()"))
7775

7876
def filter(self, keyword):
@@ -87,7 +85,6 @@ def filter(self, keyword):
8785
if self._func_match_keyword(func, keyword, extra_columns=extra_columns)
8886
]
8987

90-
self._data_cache.clear()
9188
self.emit(SIGNAL("layoutChanged()"))
9289

9390
def rowCount(self, *args, **kwargs): # pylint:disable=unused-argument
@@ -120,16 +117,6 @@ def data(self, index, role):
120117
return None
121118

122119
col = index.column()
123-
124-
key = (row, col, role)
125-
if key in self._data_cache:
126-
value = self._data_cache[key]
127-
else:
128-
value = self._data_uncached(row, col, role)
129-
self._data_cache[key] = value
130-
return value
131-
132-
def _data_uncached(self, row, col, role):
133120
func = self.func_list[row]
134121

135122
if role == Qt.DisplayRole:

0 commit comments

Comments
 (0)