Skip to content

App Module: Invalid imports in 1-start branch #30

Open
@tgavara

Description

@tgavara

app.module.ts imports the below even when there is not 'Directives' folder in the '1-start' branch

import {AppShellRenderDirective} from "./directives/app-shell-render.directive";
import {AppShellNoRenderDirective} from "./directives/app-shell-norender.directive";

Activity

faridhajnal

faridhajnal commented on Jul 12, 2023

@faridhajnal

yes i faced the very same situation. Just go ahead and remove those imports and the directives from the declarations array. If you follow the course, those directives will be created and added to the app.module.ts.
Of course this should ideally be fixed by a PR or something so that other students don't experience this issue when freshly cloning the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      App Module: Invalid imports in 1-start branch · Issue #30 · angular-university/angular-ssr-course