Lint fixes

Author: tolyo

@types/animations/animation.d.ts

@@ -8,7 +8,7 @@ export class AnimationProvider {
         $injector: ng.InjectorService,
         $$rAFScheduler: import("./raf-scheduler.js").RafScheduler,
         $$animateCache: any,
-      ) => (element: any, event: any, options: any) => AnimateRunner)
+      ) => (elementParam: any, event: any, options: any) => AnimateRunner)
   )[];
 }
 import { AnimateRunner } from "./runner/animate-runner.js";

src/angular.js

@@ -26,7 +26,7 @@ const ngMinErr = minErr("ng");
 const $injectorMinErr = minErr("$injector");
 
 /** @type {Object.<string, NgModule>} */
-const modules = {};
+const moduleRegistry = {};
 
 export class Angular {
   constructor() {
@@ -119,11 +119,11 @@ export class Angular {
   module(name, requires, configFn) {
     assertNotHasOwnProperty(name, "module");
 
-    if (requires && hasOwn(modules, name)) {
-      modules[name] = null; // force ensure to recreate the module
+    if (requires && hasOwn(moduleRegistry, name)) {
+      moduleRegistry[name] = null; // force ensure to recreate the module
     }
 
-    return ensure(modules, name, () => {
+    return ensure(moduleRegistry, name, () => {
       if (!requires) {
         throw $injectorMinErr(
           "nomod",
@@ -331,6 +331,8 @@ export class Angular {
     if (scope) {
       return scope.$proxy;
     }
+
+    return undefined;
   }
 }
 

src/animations/animate-css-driver.js

@@ -214,7 +214,7 @@ export function AnimateCssDriverProvider($$animationProvider) {
 
         // no point in doing anything when there are no elements to animate
         if (!fromAnimation && !toAnimation && anchorAnimations.length === 0)
-          return;
+          return undefined;
 
         return {
           start() {

src/animations/animate-js-driver.js

@@ -16,7 +16,7 @@ export function AnimateJsDriverProvider($$animationProvider) {
 
           const toAnimation = prepareAnimation(animationDetails.to);
 
-          if (!fromAnimation && !toAnimation) return;
+          if (!fromAnimation && !toAnimation) return undefined;
 
           return {
             start() {

src/animations/animate-js.js

@@ -94,7 +94,7 @@ export function AnimateJsProvider($animateProvider) {
         }
 
         // no matching animations
-        if (!before && !after) return;
+        if (!before && !after) return undefined;
 
         function applyOptions() {
           options.domOperation();
@@ -231,32 +231,38 @@ export function AnimateJsProvider($animateProvider) {
           },
         };
 
-        function executeAnimationFn(fn, element, event, options, onDone) {
+        function executeAnimationFn(
+          fn,
+          elemParam,
+          eventParam,
+          optionsParam,
+          onDone,
+        ) {
           let args;
 
-          switch (event) {
+          switch (eventParam) {
             case "animate":
-              args = [element, options.from, options.to, onDone];
+              args = [elemParam, optionsParam.from, optionsParam.to, onDone];
               break;
 
             case "setClass":
-              args = [element, classesToAdd, classesToRemove, onDone];
+              args = [elemParam, classesToAdd, classesToRemove, onDone];
               break;
 
             case "addClass":
-              args = [element, classesToAdd, onDone];
+              args = [elemParam, classesToAdd, onDone];
               break;
 
             case "removeClass":
-              args = [element, classesToRemove, onDone];
+              args = [elemParam, classesToRemove, onDone];
               break;
 
             default:
-              args = [element, onDone];
+              args = [elemParam, onDone];
               break;
           }
 
-          args.push(options);
+          args.push(optionsParam);
 
           let value = fn.apply(fn, args);
 
@@ -279,41 +285,22 @@ export function AnimateJsProvider($animateProvider) {
         }
 
         function groupEventedAnimations(
-          element,
-          event,
-          options,
-          animations,
+          elemParam,
+          eventParam,
+          optionsParam,
+          animationsParam,
           fnName,
         ) {
           const operations = [];
 
-          animations.forEach((ani) => {
+          animationsParam.forEach((ani) => {
             const animation = ani[fnName];
 
             if (!animation) return;
 
             // note that all of these animations will run in parallel
             operations.push(() => {
-              let runner;
-
-              let endProgressCb;
-
-              let resolved = false;
-
-              const onAnimationComplete = function (rejected) {
-                if (!resolved) {
-                  resolved = true;
-                  (
-                    endProgressCb ||
-                    (() => {
-                      /* empty */
-                    })
-                  )(rejected);
-                  runner.complete(!rejected);
-                }
-              };
-
-              runner = new AnimateRunner({
+              const newRunner = new AnimateRunner({
                 end() {
                   onAnimationComplete();
                 },
@@ -322,37 +309,52 @@ export function AnimateJsProvider($animateProvider) {
                 },
               });
 
-              endProgressCb = executeAnimationFn(
+              const endProgressCb = executeAnimationFn(
                 animation,
-                element,
-                event,
-                options,
+                elemParam,
+                eventParam,
+                optionsParam,
                 (result) => {
                   const cancelled = result === false;
 
                   onAnimationComplete(cancelled);
                 },
               );
 
-              return runner;
+              let resolved = false;
+
+              const onAnimationComplete = function (rejected) {
+                if (!resolved) {
+                  resolved = true;
+                  (
+                    endProgressCb ||
+                    (() => {
+                      /* empty */
+                    })
+                  )(rejected);
+                  newRunner.complete(!rejected);
+                }
+              };
+
+              return newRunner;
             });
           });
 
           return operations;
         }
 
         function packageAnimations(
-          element,
-          event,
-          options,
-          animations,
+          elementParam,
+          eventParam,
+          optionsParam,
+          animationsParam,
           fnName,
         ) {
           let operations = groupEventedAnimations(
-            element,
-            event,
-            options,
-            animations,
+            elementParam,
+            eventParam,
+            optionsParam,
+            animationsParam,
             fnName,
           );
 
@@ -363,32 +365,32 @@ export function AnimateJsProvider($animateProvider) {
 
             if (fnName === "beforeSetClass") {
               a = groupEventedAnimations(
-                element,
+                elementParam,
                 "removeClass",
-                options,
-                animations,
+                optionsParam,
+                animationsParam,
                 "beforeRemoveClass",
               );
               b = groupEventedAnimations(
-                element,
+                elementParam,
                 "addClass",
-                options,
-                animations,
+                optionsParam,
+                animationsParam,
                 "beforeAddClass",
               );
             } else if (fnName === "setClass") {
               a = groupEventedAnimations(
-                element,
+                elementParam,
                 "removeClass",
-                options,
-                animations,
+                optionsParam,
+                animationsParam,
                 "removeClass",
               );
               b = groupEventedAnimations(
-                element,
+                elementParam,
                 "addClass",
-                options,
-                animations,
+                optionsParam,
+                animationsParam,
                 "addClass",
               );
             }

src/animations/animate.js

@@ -309,6 +309,8 @@ export function AnimateProvider($provide) {
           } else {
             element.setAttribute("animate", `${enabled}`);
           }
+
+          return true;
         },
 
         /**