Harden lint configs

Author: tolyo

eslint.config.js

@@ -5,7 +5,7 @@ import eslintPluginPrettierRecommended from "eslint-plugin-prettier/recommended"
 
 export default defineConfig([
   {
-    files: ["**/*.{js,mjs,cjs}"],
+    files: ["./src/**/*.{js,mjs,cjs}"],
     languageOptions: {
       ecmaVersion: "latest",
       sourceType: "module",
@@ -16,11 +16,101 @@ export default defineConfig([
     },
     plugins: { js },
     extends: ["js/recommended"],
-    ignores: ["**/*.spec.js"],
-  },
-  {
-    files: ["**/*.{js,mjs,cjs}"],
-    languageOptions: { globals: globals.browser },
+    rules: {
+      // ===== Code style =====
+      indent: ["error", 2],
+      quotes: ["error", "single"],
+      semi: ["error", "always"],
+      "comma-dangle": ["error", "never"],
+      "comma-spacing": ["error", { before: false, after: true }],
+      "space-before-function-paren": ["error", "always"],
+      "space-in-parens": ["error", "never"],
+      "space-infix-ops": "error",
+      "object-curly-spacing": ["error", "always"],
+      "array-bracket-spacing": ["error", "never"],
+      "arrow-spacing": ["error", { before: true, after: true }],
+      "block-spacing": "error",
+      "brace-style": ["error", "1tbs", { allowSingleLine: false }],
+      "max-len": [
+        "error",
+        { code: 100, ignoreComments: false, ignoreStrings: false },
+      ],
+
+      // ===== Best practices =====
+      "no-var": "error",
+      "prefer-const": "error",
+      eqeqeq: ["error", "always"],
+      curly: ["error", "all"],
+      "no-console": ["error"],
+      "no-debugger": "error",
+      "no-alert": "error",
+      "no-eval": "error",
+      "no-duplicate-imports": "error",
+      "no-unused-vars": [
+        "error",
+        { args: "after-used", ignoreRestSiblings: false },
+      ],
+      "no-implicit-globals": "error",
+      "no-magic-numbers": [
+        "warn",
+        { ignore: [0, 1, -1], ignoreArrayIndexes: true, enforceConst: true },
+      ],
+      "no-empty-function": "error",
+      "no-fallthrough": "error",
+      "no-invalid-this": "error",
+      "no-return-assign": "error",
+      "no-self-assign": "error",
+      "no-self-compare": "error",
+      "no-shadow": "error",
+      "no-useless-catch": "error",
+      "no-useless-return": "error",
+
+      // ===== Modern JS =====
+      "prefer-arrow-callback": "error",
+      "prefer-template": "error",
+      "prefer-exponentiation-operator": "error",
+      "prefer-destructuring": ["error", { object: true, array: false }],
+      "object-shorthand": ["error", "always"],
+      "arrow-body-style": ["error", "as-needed"],
+      "no-useless-constructor": "error",
+
+      // ===== Readability & organization =====
+      "newline-per-chained-call": ["error", { ignoreChainWithDepth: 1 }],
+      "padding-line-between-statements": [
+        "error",
+        { blankLine: "always", prev: "*", next: "return" },
+        { blankLine: "always", prev: ["const", "let", "var"], next: "*" },
+        { blankLine: "always", prev: "*", next: "if" },
+        { blankLine: "always", prev: "*", next: "for" },
+        { blankLine: "always", prev: "*", next: "while" },
+        { blankLine: "always", prev: "*", next: "try" },
+      ],
+      "lines-between-class-members": [
+        "error",
+        "always",
+        { exceptAfterSingleLine: true },
+      ],
+      "max-classes-per-file": ["error", 1],
+      "consistent-return": "error",
+      "dot-notation": "error",
+      "id-length": ["warn", { min: 2, exceptions: ["i", "j"] }],
+      "sort-imports": [
+        "error",
+        {
+          ignoreCase: false,
+          ignoreDeclarationSort: false,
+          memberSyntaxSortOrder: ["none", "all", "multiple", "single"],
+        },
+      ],
+      "newline-before-return": "error",
+
+      // ===== Security & safety =====
+      "no-prototype-builtins": "error",
+      "no-new-object": "error",
+      "no-new-func": "error",
+      "no-with": "error",
+    },
+    ignores: ["**/*.spec.js", "**/*.test.js"],
   },
   eslintPluginPrettierRecommended,
 ]);

src/angular.js

@@ -22,6 +22,7 @@ import { $injectTokens as $t } from "./injection-tokens.js";
 import { annotate } from "./core/di/di.js";
 
 const ngMinErr = minErr("ng");
+
 const $injectorMinErr = minErr("$injector");
 
 /** @type {Object.<string, NgModule>} */
@@ -64,7 +65,7 @@ export class Angular {
     this.errorHandlingConfig = errorHandlingConfig;
     this.$t = $t;
 
-    window["angular"] = this;
+    window.angular = this;
     registerNgModule(this);
   }
 
@@ -117,9 +118,11 @@ export class Angular {
    */
   module(name, requires, configFn) {
     assertNotHasOwnProperty(name, "module");
+
     if (requires && hasOwn(modules, name)) {
       modules[name] = null; // force ensure to recreate the module
     }
+
     return ensure(modules, name, () => {
       if (!requires) {
         throw $injectorMinErr(
@@ -128,6 +131,7 @@ export class Angular {
           name,
         );
       }
+
       return new NgModule(name, requires, configFn);
     });
   }
@@ -204,6 +208,7 @@ export class Angular {
     this.bootsrappedModules.unshift("ng");
 
     const injector = createInjector(this.bootsrappedModules, config.strictDi);
+
     injector.invoke([
       $t.$rootScope,
       $t.$rootElement,
@@ -223,6 +228,7 @@ export class Angular {
         setCacheData(el, "$injector", $injector);
 
         const compileFn = compile(el);
+
         compileFn(scope);
 
         // https://github.com/angular-ui/ui-router/issues/3678
@@ -251,6 +257,7 @@ export class Angular {
           );
       },
     ]);
+
     return injector;
   }
 
@@ -268,11 +275,15 @@ export class Angular {
    */
   init(element) {
     let appElement;
+
     let module;
+
     const config = {};
+
     // The element `element` has priority over any other element.
     ngAttrPrefixes.forEach((prefix) => {
       const name = `${prefix}app`;
+
       if (
         /** @type {Element} */ (element).hasAttribute &&
         /** @type {Element} */ (element).hasAttribute(name)
@@ -283,6 +294,7 @@ export class Angular {
     });
     ngAttrPrefixes.forEach((prefix) => {
       const name = `${prefix}app`;
+
       let candidate;
 
       if (
@@ -293,6 +305,7 @@ export class Angular {
         module = candidate.getAttribute(name);
       }
     });
+
     if (appElement) {
       config.strictDi = getNgAttribute(appElement, "strict-di") !== null;
       this.bootstrap(appElement, module ? [module] : [], config);
@@ -312,6 +325,7 @@ export class Angular {
    */
   getScopeByName(name) {
     const scope = this.$rootScope.$searchByName(name);
+
     if (scope) {
       return scope.$proxy;
     }

src/animations/animate-cache.js

@@ -1,5 +1,7 @@
 const KEY = "$animId";
+
 let parentCounter = 0;
+
 const cache = new Map();
 
 export function animateCache() {
@@ -14,10 +16,15 @@ export function animateCache() {
      */
     cacheKey(node, method, addClass, removeClass) {
       const { parentNode } = node;
+
       const parentID = parentNode[KEY] ?? (parentNode[KEY] = ++parentCounter);
+
       const parts = [parentID, method, node.getAttribute("class")];
+
       if (addClass) parts.push(addClass);
+
       if (removeClass) parts.push(removeClass);
+
       return parts.join(" ");
     },
 
@@ -28,6 +35,7 @@ export function animateCache() {
      */
     containsCachedAnimationWithoutDuration(key) {
       const entry = cache.get(key);
+
       return entry ? !entry.isValid : false;
     },
 
@@ -65,6 +73,7 @@ export function animateCache() {
      */
     put(key, value, isValid) {
       const entry = cache.get(key);
+
       if (entry) {
         entry.total++;
         entry.value = value;

src/animations/animate-children-directive.js

@@ -12,7 +12,8 @@ $$AnimateChildrenDirective.$inject = [$t.$interpolate];
 export function $$AnimateChildrenDirective($interpolate) {
   return {
     link(scope, element, attrs) {
-      const val = attrs["ngAnimateChildren"];
+      const val = attrs.ngAnimateChildren;
+
       if (isString(val) && val.length === 0) {
         // empty attribute
         setCacheData(element, NG_ANIMATE_CHILDREN_DATA, true);

src/animations/animate-css-driver.js

@@ -3,9 +3,11 @@ import { AnimateRunner } from "./runner/animate-runner.js";
 import { concatWithSpace } from "./shared.js";
 
 const NG_ANIMATE_SHIM_CLASS_NAME = "ng-animate-shim";
+
 const NG_ANIMATE_ANCHOR_CLASS_NAME = "ng-anchor";
 
 const NG_OUT_ANCHOR_CLASS_NAME = "ng-anchor-out";
+
 const NG_IN_ANCHOR_CLASS_NAME = "ng-anchor-in";
 
 AnimateCssDriverProvider.$inject = ["$$animationProvider"];
@@ -30,6 +32,7 @@ export function AnimateCssDriverProvider($$animationProvider) {
      */
     function ($animateCss, $rootElement) {
       const bodyNode = document.body;
+
       const rootNode = $rootElement;
 
       const rootBodyElement =
@@ -52,6 +55,7 @@ export function AnimateCssDriverProvider($$animationProvider) {
 
       function prepareAnchoredAnimation(outAnchor, inAnchor) {
         const clone = outAnchor.cloneNode(true);
+
         const startingClasses = filterCssClasses(getClassVal(clone));
 
         outAnchor[0].classList.add(NG_ANIMATE_SHIM_CLASS_NAME);
@@ -62,6 +66,7 @@ export function AnimateCssDriverProvider($$animationProvider) {
         rootBodyElement.append(clone);
 
         let animatorIn;
+
         const animatorOut = prepareOutAnimation();
 
         // the user may not end up using the `out` animation and
@@ -70,6 +75,7 @@ export function AnimateCssDriverProvider($$animationProvider) {
         // animation is over unless both animations are not used.
         if (!animatorOut) {
           animatorIn = prepareInAnimation();
+
           if (!animatorIn) {
             return end();
           }
@@ -82,17 +88,21 @@ export function AnimateCssDriverProvider($$animationProvider) {
             let runner;
 
             let currentAnimation = startingAnimator.start();
+
             currentAnimation.done(() => {
               currentAnimation = null;
+
               if (!animatorIn) {
                 animatorIn = prepareInAnimation();
+
                 if (animatorIn) {
                   currentAnimation = animatorIn.start();
                   currentAnimation.done(() => {
                     currentAnimation = null;
                     end();
                     runner.complete();
                   });
+
                   return currentAnimation;
                 }
               }
@@ -125,6 +135,7 @@ export function AnimateCssDriverProvider($$animationProvider) {
           // all the keys for the coords object when iterated
           ["width", "height", "top", "left"].forEach((key) => {
             let value = coords[key];
+
             switch (key) {
               case "top":
                 value += bodyNode.scrollTop;
@@ -135,6 +146,7 @@ export function AnimateCssDriverProvider($$animationProvider) {
             }
             styles[key] = `${Math.floor(value)}px`;
           });
+
           return styles;
         }
 
@@ -156,7 +168,9 @@ export function AnimateCssDriverProvider($$animationProvider) {
 
         function prepareInAnimation() {
           const endingClasses = filterCssClasses(getClassVal(inAnchor));
+
           const toAdd = getUniqueValues(endingClasses, startingClasses);
+
           const toRemove = getUniqueValues(startingClasses, endingClasses);
 
           const animator = $animateCss(clone, {
@@ -180,13 +194,18 @@ export function AnimateCssDriverProvider($$animationProvider) {
 
       function prepareFromToAnchorAnimation(from, to, anchors) {
         const fromAnimation = prepareRegularAnimation(from);
+
         const toAnimation = prepareRegularAnimation(to);
 
         const anchorAnimations = [];
+
         anchors.forEach((anchor) => {
           const outElement = anchor.out;
+
           const inElement = anchor.in;
+
           const animator = prepareAnchoredAnimation(outElement, inElement);
+
           if (animator) {
             anchorAnimations.push(animator);
           }
@@ -278,6 +297,8 @@ function filterCssClasses(classes) {
 
 function getUniqueValues(a, b) {
   if (isString(a)) a = a.split(" ");
+
   if (isString(b)) b = b.split(" ");
+
   return a.filter((val) => b.indexOf(val) === -1).join(" ");
 }