Type improvements

Author: Anatoly Ostrovsky

@types/animations/interface.d.ts

@@ -100,6 +100,10 @@ export interface AnimationOptions {
   tempClasses: string | string[];
   /** Optional DOM operation callback executed before animation */
   domOperation?: () => void;
+  $$domOperationFired?: boolean;
+  $$prepared?: boolean;
+  preparationClasses?: string;
+  activeClasses?: string;
 }
 export interface AnimateJsRunner {
   $$willAnimate: true;

@types/animations/shared.d.ts

@@ -1,10 +1,25 @@
-export function assertArg(arg: any, name: any, reason: any): any;
-export function packageStyles(options: any): {
-  to: any;
-  from: any;
-};
-export function pendClasses(classes: any, fix: any, isPrefix: any): string;
-export function removeFromArray(arr: any, val: any): void;
+/**
+ * @param {ng.AnimationOptions} options
+ */
+export function packageStyles(options: ng.AnimationOptions):
+  | {
+      to: Record<string, string | number>;
+      from: Record<string, string | number>;
+    }
+  | {
+      to?: undefined;
+      from?: undefined;
+    };
+/**
+ * @param {string | string[]} classes
+ * @param {string} fix
+ * @param {boolean | undefined} [isPrefix]
+ */
+export function pendClasses(
+  classes: string | string[],
+  fix: string,
+  isPrefix?: boolean | undefined,
+): string;
 /**
  *
  * @param {NodeList|Node} element
@@ -13,31 +28,36 @@ export function removeFromArray(arr: any, val: any): void;
 export function stripCommentsFromElement(
   element: NodeList | Node,
 ): Node[] | Node | undefined;
-/**
- * @param {NodeList|Node} element
- * @returns {Node}
- */
-export function extractElementNode(element: NodeList | Node): Node;
 export function applyAnimationClassesFactory(): (
-  element: any,
-  options: any,
+  /** @type {HTMLElement} */ element: HTMLElement,
+  /** @type {ng.AnimationOptions} */ options: ng.AnimationOptions,
 ) => void;
-export function prepareAnimationOptions(options: any): any;
-export function applyAnimationStyles(element: any, options: any): void;
+/**
+ * @param {ng.AnimationOptions | undefined} options
+ */
+export function prepareAnimationOptions(
+  options: ng.AnimationOptions | undefined,
+): import("./interface.ts").AnimationOptions;
+/**
+ * @param {HTMLElement} element
+ * @param {ng.AnimationOptions | undefined} options
+ */
+export function applyAnimationStyles(
+  element: HTMLElement,
+  options: ng.AnimationOptions | undefined,
+): void;
 /**
  * Applies initial animation styles to a DOM element.
  *
  * This function sets the element's inline styles using the properties
  * defined in `options.from`, then clears the property to prevent reuse.
  *
  * @param {HTMLElement} element - The target DOM element to apply styles to.
- * @param {{ from?: Partial<CSSStyleDeclaration> | null }} options - options containing a `from` object with CSS property–value pairs.
+ * @param {ng.AnimationOptions} [options] - options containing a `from` object with CSS property–value pairs.
  */
 export function applyAnimationFromStyles(
   element: HTMLElement,
-  options: {
-    from?: Partial<CSSStyleDeclaration> | null;
-  },
+  options?: ng.AnimationOptions,
 ): void;
 /**
  * Applies final animation styles to a DOM element.
@@ -46,41 +66,77 @@ export function applyAnimationFromStyles(
  * defined in `options.to`, then clears the property to prevent reuse.
  *
  * @param {HTMLElement} element - The target DOM element to apply styles to.
- * @param {{ to?: Partial<CSSStyleDeclaration> | null }} options - options containing a `from` object with CSS property–value pairs.
+ * @param {ng.AnimationOptions} [options] - options containing a `from` object with CSS property–value pairs.
  */
 export function applyAnimationToStyles(
   element: HTMLElement,
-  options: {
-    to?: Partial<CSSStyleDeclaration> | null;
-  },
+  options?: ng.AnimationOptions,
 ): void;
+/**
+ * Merge old and new animation options for an element, computing
+ * the final addClass and removeClass values.
+ *
+ * @param {HTMLElement} element - The DOM element being animated.
+ * @param {{ options?: ng.AnimationOptions; addClass?: string; removeClass?: string }} oldAnimation
+ * @param {{ options?: ng.AnimationOptions; addClass?: string; removeClass?: string; preparationClasses?: string }} newAnimation
+ * @returns {ng.AnimationOptions} - The merged animation options.
+ */
 export function mergeAnimationDetails(
-  element: any,
-  oldAnimation: any,
-  newAnimation: any,
-): any;
-export function resolveElementClasses(
-  existing: any,
-  toAdd: any,
-  toRemove: any,
-): {
-  addClass: string;
-  removeClass: string;
-};
+  element: HTMLElement,
+  oldAnimation: {
+    options?: ng.AnimationOptions;
+    addClass?: string;
+    removeClass?: string;
+  },
+  newAnimation: {
+    options?: ng.AnimationOptions;
+    addClass?: string;
+    removeClass?: string;
+    preparationClasses?: string;
+  },
+): ng.AnimationOptions;
+/**
+ * @param {HTMLElement} element
+ * @param {string | null} event
+ * @param {ng.AnimationOptions} options
+ */
 export function applyGeneratedPreparationClasses(
-  element: any,
-  event: any,
-  options: any,
+  element: HTMLElement,
+  event: string | null,
+  options: ng.AnimationOptions,
 ): void;
-export function clearGeneratedClasses(element: any, options: any): void;
-export function blockKeyframeAnimations(node: any, applyBlock: any): string[];
-export function applyInlineStyle(node: any, styleTuple: any): void;
-export function concatWithSpace(a: any, b: any): any;
+/**
+ * @param {HTMLElement} element
+ * @param {ng.AnimationOptions} options
+ */
+export function clearGeneratedClasses(
+  element: HTMLElement,
+  options: ng.AnimationOptions,
+): void;
+/**
+ * @param {HTMLElement} node
+ * @param {boolean} applyBlock
+ * @returns {string[]}
+ */
+export function blockKeyframeAnimations(
+  node: HTMLElement,
+  applyBlock: boolean,
+): string[];
+/**
+ * @param {HTMLElement} node
+ * @param {any[]} styleTuple
+ */
+export function applyInlineStyle(node: HTMLElement, styleTuple: any[]): void;
+/**
+ * @param {string} a
+ * @param {string} b
+ * @returns {string}
+ */
+export function concatWithSpace(a: string, b: string): string;
 export const ADD_CLASS_SUFFIX: "-add";
 export const REMOVE_CLASS_SUFFIX: "-remove";
 export const EVENT_CLASS_PREFIX: "ng-";
 export const ACTIVE_CLASS_SUFFIX: "-active";
 export const PREPARE_CLASS_SUFFIX: "-prepare";
 export const NG_ANIMATE_CLASSNAME: "ng-animate";
 export const NG_ANIMATE_CHILDREN_DATA: "$$ngAnimateChildren";
-export const ngMinErr: (arg0: string, ...arg1: any[]) => Error;

@types/namespace.d.ts

@@ -80,7 +80,10 @@ import {
 } from "./directive/worker/interface.ts";
 import { Provider as TProvideService } from "./interface.ts";
 import { Location as TLocationService } from "./services/location/location.js";
-import { AnimateService as TAnimateService } from "./animations/interface.ts";
+import {
+  AnimateService as TAnimateService,
+  AnimationOptions as TAnimationOptions,
+} from "./animations/interface.ts";
 import {
   StorageBackend as TStorageBackend,
   StorageType as TStorageType,
@@ -185,6 +188,7 @@ declare global {
     type UrlService = TUrlService;
     type ViewService = TViewService;
     type ViewScrollService = TViewScrollService;
+    type AnimationOptions = TAnimationOptions;
     type ErrorHandlingConfig = TErrorHandlingConfig;
     type ListenerFn = TListenerFn;
     type Listener = TListener;

@types/shared/dom.d.ts

@@ -11,24 +11,24 @@ export function kebabToCamel(name: string): string;
  */
 export function snakeToCamel(name: string): string;
 /**
- * Removes expando data from this element. If key is provided, only
- * its field is removed. If data is empty, also removes `ExpandoStore`
- * from cache.
- * @param {Element} element
- * @param {string} [name] - key of field to remove
+ * @param {Element & Record<string, any>} element
+ * @param {string} [name]
  */
-export function removeElementData(element: Element, name?: string): void;
+export function removeElementData(
+  element: Element & Record<string, any>,
+  name?: string,
+): void;
 /**
  * Stores data associated with an element inside the expando property of the DOM element.
  *
  * @see {@link https://developer.mozilla.org/en-US/docs/Glossary/Expando MDN Glossary: Expando}
  *
- * @param {Element} element
+ * @param {Element & Record<string, any> } element
  * @param {boolean} [createIfNecessary=false]
  * @returns {import("../interface.ts").ExpandoStore}
  */
 export function getExpando(
-  element: Element,
+  element: Element & Record<string, any>,
   createIfNecessary?: boolean,
 ): import("../interface.ts").ExpandoStore;
 /**
@@ -38,22 +38,30 @@ export function getExpando(
  */
 export function isTextNode(html: string): boolean;
 /**
- * @param {Element} element
+ * @param {Element & Record<string, any>} element
+ * @param {Element & Record<string, any>} element
  * @param {boolean} [onlyDescendants]
  * @returns {void}
  */
-export function dealoc(element: Element, onlyDescendants?: boolean): void;
+export function dealoc(
+  element: Element & Record<string, any>,
+  onlyDescendants?: boolean,
+): void;
 /**
  * Gets or sets cache data for a given element.
  *
  * @param {Element} element - The DOM element to get or set data on.
- * @param {string|Object} key - The key (as a string) to get/set or an object for mass-setting.
+ * @param {string|Object.<string, any>} key - The key to get/set or an object for mass-setting.
  * @param {*} [value] - The value to set. If not provided, the function acts as a getter.
- * @returns {*} - The retrieved data if acting as a getter. Otherwise, returns undefined.
+ * @returns {*} - The retrieved data if acting as a getter. Otherwise, undefined.
  */
 export function getOrSetCacheData(
   element: Element,
-  key: string | any,
+  key:
+    | string
+    | {
+        [x: string]: any;
+      },
   value?: any,
 ): any;
 /**
@@ -128,10 +136,11 @@ export function getController(
   name?: string,
 ): ng.Scope | undefined;
 /**
+ * Walk up the DOM tree (including Shadow DOM) to get inherited data.
  *
- * @param {Node} element
- * @param {string} name
- * @returns
+ * @param {Node} element - The starting element (or document/document fragment)
+ * @param {string} name - The data key to look up
+ * @returns {any} - The found value, or undefined if not found
  */
 export function getInheritedData(element: Node, name: string): any;
 /**
@@ -149,10 +158,10 @@ export function removeElement(element: Element, keepData?: boolean): void;
 export function startingTag(elementOrStr: string | Element | Node): string;
 /**
  * Return the DOM siblings between the first and last node in the given array.
- * @param {Array<Node>} nodes An array-like object
- * @returns {*[]|Array<Node>} the inputted object or a JQLite collection containing the nodes
+ * @param {Node[]} nodes
+ * @returns {Node[]}
  */
-export function getBlockNodes(nodes: Array<Node>): any[] | Array<Node>;
+export function getBlockNodes(nodes: Node[]): Node[];
 /**
  * Gets the name of a boolean attribute if it exists on a given element.
  *
@@ -230,6 +239,11 @@ export function animatedomInsert(
  * @returns {string} The base href.
  */
 export function getBaseHref(): string;
+/**
+ * @param {NodeList|Node} element
+ * @returns {Node | undefined}
+ */
+export function extractElementNode(element: NodeList | Node): Node | undefined;
 /**
  * Expando cache for adding properties to DOM nodes with JavaScript.
  * This used to be an Object in JQLite decorator, but swapped out for a Map