Version bump

tolyo · tolyo · commit 4ff432b03bab · 2024-11-15T23:03:41.000+02:00
diff --git a/Makefile b/Makefile
@@ -11,6 +11,7 @@ build:
 		echo "Removing $(BUILD_DIR)..."; \
 		rm -r "$(BUILD_DIR)"; \
 	fi
+	@npm i
 	./node_modules/.bin/rollup -c
 
 pretty:
diff --git a/dist/angular-ts.esm.js b/dist/angular-ts.esm.js
diff --git a/dist/angular-ts.umd.js b/dist/angular-ts.umd.js
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "@angular-wave/angular.ts",
   "description": "A modern, optimized and typesafe version of AngularJS",
   "license": "MIT",
-  "version": "0.4.5",
+  "version": "0.4.6",
   "type": "module",
   "main": "dist/angular-ts.esm.js",
   "browser": "dist/angular-ts.umd.js",
diff --git a/src/directive/events/events.html b/src/directive/events/events.html
@@ -11,6 +11,7 @@
     <script src="/jasmine/jasmine-5.1.2/boot0.js"></script>
     <script src="/jasmine/jasmine-5.1.2/boot1.js"></script>
     <script type="module" src="/src/directive/events/event.spec.js"></script>
+    <script type="module" src="/src/directive/events/click.spec.js"></script>
   </head>
   <body>
     <div id="dummy"></div>
diff --git a/src/directive/observe/observe.js b/src/directive/observe/observe.js
@@ -6,8 +6,11 @@ export function ngObserveDirective() {
     restrict: "A",
     link: (scope, element, attrs) => {
       const targetElement = element[0];
-      const prop = targetElement.dataset["update"];
       const source = attrs["ngObserve"];
+      let prop = targetElement.dataset["update"];
+      if (!prop) {
+        prop = source;
+      }
 
       if (!scope[prop]) {
         scope[prop] = targetElement.getAttribute(source);
diff --git a/src/directive/observe/observe.spec.js b/src/directive/observe/observe.spec.js
@@ -89,4 +89,25 @@ describe("observe", () => {
 
     expect(observerSpy.disconnect).toHaveBeenCalled();
   });
+
+  it("should observe attribute changes and update the same scope name if data-update attribute is absent", () => {
+    $scope.myProp = "";
+    const template = `<div ng-observe="test-attribute"></div>`;
+    element = $compile(template)($scope);
+    $scope.$digest();
+    spyOn($scope, "$digest").and.callThrough();
+
+    const mutationObserverCallback =
+      MutationObserver.calls.mostRecent().args[0];
+    const mutationRecord = {
+      target: element[0],
+      attributeName: "test-attribute",
+    };
+
+    element.attr("test-attribute", "newValue");
+    element[0].setAttribute("test-attribute", "newValue");
+
+    mutationObserverCallback([mutationRecord]);
+    expect($scope.$digest).toHaveBeenCalled();
+  });
 });
diff --git a/src/directive/observe/test.html b/src/directive/observe/test.html
@@ -86,11 +86,7 @@
     <br />
 
     {{ activeid }}
-    <fluent-tabs
-      ng-observe="activeid"
-      data-update="activeid"
-      activeid="entrees"
-    >
+    <fluent-tabs ng-observe="activeid" activeid="entrees">
       <fluent-tab id="apps">Appetizers</fluent-tab>
       <fluent-tab id="entrees">Entrees</fluent-tab>
       <fluent-tab id="desserts">Desserts</fluent-tab>
@@ -173,13 +169,9 @@
       </fluent-tab-panel>
     </fluent-tabs>
 
-    {{ radio }}
+    {{ value }}
 
-    <fluent-radio-group
-      ng-observe="value"
-      data-update="radio"
-      orientation="vertical"
-    >
+    <fluent-radio-group ng-observe="value" orientation="vertical">
       <fluent-radio value="1">18-24</fluent-radio>
       <fluent-radio value="2">25-33</fluent-radio>
       <fluent-radio value="3">34-44</fluent-radio>
