Skip to content

Commit 7f762f4

Browse files
committed
Type improvements
1 parent d344345 commit 7f762f4

26 files changed

+111
-79
lines changed

@types/namespace.d.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ import { NgModelController as TNgModelController } from "./directive/model/model
9292
import { RouterProvider } from "./router/router.ts";
9393
import { TransitionProvider as TTransitionProvider } from "./router/transition/transition-service.js";
9494
import { AnimateProvider as TAnimateProvider } from "./animations/animate.js";
95+
import { UrlService as TUrlService } from "./router/url/url-service.js";
96+
import { LocationProvider as TLocationProvider } from "./services/location/location.js";
9597
declare global {
9698
interface Function {
9799
$inject?: readonly string[] | undefined;
@@ -119,11 +121,12 @@ declare global {
119121
type LinkFnMapping = TLinkFnMapping;
120122
type AnchorScrollProvider = TAnchorScrollProvider;
121123
type AnimateProvider = TAnimateProvider;
124+
type FilterProvider = TFilterProvider;
122125
type InterpolateProvider = TInterpolateProvider;
123126
type HttpParamSerializerProvider = THttpParamSerializerProvider;
127+
type LocationProvider = TLocationProvider;
124128
type SceProvider = TSceProvider;
125129
type SceDelegateProvider = TSceDelegateProvider;
126-
type FilterProvider = TFilterProvider;
127130
type TransitionProvider = TTransitionProvider;
128131
type AnchorScrollService = TAnchorScrollService;
129132
type AnimateService = TAnimateService;
@@ -151,6 +154,7 @@ declare global {
151154
type SseConfig = TSseConfig;
152155
type TemplateCacheService = Map<string, string>;
153156
type TemplateRequestService = TTemplateRequestService;
157+
type UrlService = TUrlService;
154158
type ErrorHandlingConfig = TErrorHandlingConfig;
155159
type ListenerFn = TListenerFn;
156160
type Listener = TListener;

@types/router/state/state-service.d.ts

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,13 @@
44
* This API is located at `router.stateService` ([[UIRouter.stateService]])
55
*/
66
export class StateProvider {
7-
static $inject: string[];
7+
static $inject: any;
88
/**
99
*
10-
* @param {import('../router.js').RouterProvider} globals
10+
* @param {ng.RouterService} globals
1111
* @param {*} transitionService
12-
* @param {import('../../core/di/internal-injector.js').InjectorService} $injector
1312
*/
14-
constructor(
15-
globals: import("../router.js").RouterProvider,
16-
transitionService: any,
17-
$injector: import("../../core/di/internal-injector.js").InjectorService,
18-
);
13+
constructor(globals: ng.RouterService, transitionService: any);
1914
/**
2015
* The latest successful state parameters
2116
*
@@ -34,14 +29,16 @@ export class StateProvider {
3429
* @deprecated This is a passthrough through to [[Router.$current]]
3530
*/
3631
get $current(): import("./state-object.js").StateObject;
37-
stateRegistry: any;
38-
urlService: any;
3932
globals: import("../router.js").RouterProvider;
4033
transitionService: any;
41-
$injector: import("../../core/di/internal-injector.js").InjectorService;
34+
stateRegistry: any;
35+
/** @type {ng.UrlService} */
36+
urlService: ng.UrlService;
37+
/** @type {ng.InjectorService} */
38+
$injector: ng.InjectorService;
4239
invalidCallbacks: any[];
4340
_defaultErrorHandler: ($error$: any) => never;
44-
$get: () => this;
41+
$get: any[];
4542
/**
4643
* Decorates states when they are registered
4744
*

@types/router/url/url-service.d.ts

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,21 @@
44
export class UrlService {
55
static $inject: string[];
66
/**
7-
* @param {import("../../services/location/location").LocationProvider} $locationProvider
7+
* @param {ng.LocationProvider} $locationProvider
88
* @param {import("../../router/state/state-service.js").StateProvider} stateService
99
* @param {import("../router.js").RouterProvider} globals
1010
* @param {import("../../router/url/url-config.js").UrlConfigProvider} urlConfigProvider
1111
*/
1212
constructor(
13-
$locationProvider: any,
13+
$locationProvider: ng.LocationProvider,
1414
stateService: import("../../router/state/state-service.js").StateProvider,
1515
globals: import("../router.js").RouterProvider,
1616
urlConfigProvider: import("../../router/url/url-config.js").UrlConfigProvider,
1717
);
18-
/** @type {import("../../services/location/location").Location} */
19-
$location: any;
20-
$locationProvider: any;
18+
/** @type {ng.LocationService} */
19+
$location: ng.LocationService;
20+
/** @private */
21+
private _locationProvider;
2122
stateService: import("../../router/state/state-service.js").StateProvider;
2223
/** Provides services related to the URL */
2324
urlRuleFactory: UrlRuleFactory;
@@ -60,7 +61,10 @@ export class UrlService {
6061
getHash(): string;
6162
$get: (
6263
| string
63-
| (($location: ng.LocationService, $rootScope: ng.Scope) => UrlService)
64+
| ((
65+
$location: ng.LocationService,
66+
$rootScope: ng.RootScopeService,
67+
) => ng.UrlService)
6468
)[];
6569
/**
6670
* @returns {string}
@@ -118,7 +122,7 @@ export class UrlService {
118122
*
119123
* @return the url (after potentially being processed)
120124
*/
121-
url(newUrl?: string, state?: any): any;
125+
url(newUrl?: string, state?: any): string;
122126
/**
123127
* @private
124128
*
@@ -196,7 +200,7 @@ export class UrlService {
196200
*/
197201
match(url: any): any;
198202
update(read: any): void;
199-
location: any;
203+
location: string;
200204
/**
201205
* Internal API.
202206
*

docs/static/typedoc/assets/hierarchy.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/static/typedoc/assets/navigation.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/static/typedoc/assets/search.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)