Type improvements

Author: tolyo

@types/core/parse/parse.d.ts

@@ -29,5 +29,8 @@ export class ParseProvider {
     identifierStart?: (arg0: any) => boolean,
     identifierContinue?: (arg0: any) => boolean,
   ) => ParseProvider;
-  $get: (string | (($filter: (any: any) => any) => any))[];
+  $get: (
+    | string
+    | (($filter: (any: any) => any) => import("./interface.ts").ParseService)
+  )[];
 }

@types/directive/form/form.d.ts

@@ -108,6 +108,7 @@ export class FormController {
   $$success: {};
   $pending: any;
   $$classCache: {};
+  $target: {};
   /**
    * Rollback all form controls pending updates to the `$modelValue`.
    *
@@ -154,8 +155,9 @@ export class FormController {
    * Likewise, adding a control to, or removing a control from the form is not reflected
    * in the shallow copy. That means you should get a fresh copy from `$getControls()` every time
    * you need access to the controls.
+   * @returns {ReadonlyArray<FormController>}
    */
-  $getControls(): any[];
+  $getControls(): ReadonlyArray<FormController>;
   $$renameControl(control: any, newName: any): void;
   /**
    * Deregister a control from the form.
@@ -166,8 +168,9 @@ export class FormController {
    * form. `$dirty`, `$submitted` states will not be changed, because the expected behavior can be
    * different from case to case. For example, removing the only `$dirty` control from a form may or
    * may not mean that the form is still `$dirty`.
+   * @param {FormController } control
    */
-  $removeControl(control: any): void;
+  $removeControl(control: FormController): void;
   /**
    * Sets the form to a dirty state.
    *

@types/directive/model/interface.d.ts

@@ -0,0 +1,18 @@
+export interface ModelValidators {
+  /**
+   * viewValue is any because it can be an object that is called in the view like $viewValue.name:$viewValue.subName
+   */
+  [index: string]: (modelValue: any, viewValue: any) => boolean;
+}
+export interface AsyncModelValidators {
+  [index: string]: (modelValue: any, viewValue: any) => Promise<any>;
+}
+export interface ModelParser {
+  (value: any): any;
+}
+export interface ModelFormatter {
+  (value: any): any;
+}
+export interface ModelViewChangeListener {
+  (): void;
+}

@types/directive/model/model.d.ts

@@ -72,16 +72,16 @@ export class NgModelController {
   $modelValue: any;
   /** @type {any} */
   $$rawModelValue: any;
-  /** @type {any} */
-  $validators: any;
-  /** @type {any} */
-  $asyncValidators: any;
-  /** @type {Array<any>} */
-  $parsers: Array<any>;
-  /** @type {Array<any>} */
-  $formatters: Array<any>;
-  /** @type {Array<any>} */
-  $viewChangeListeners: Array<any>;
+  /** @type {import("./interface.ts").ModelValidators} */
+  $validators: import("./interface.ts").ModelValidators;
+  /** @type {import("./interface.ts").AsyncModelValidators} */
+  $asyncValidators: import("./interface.ts").AsyncModelValidators;
+  /** @type {Array<import("./interface.ts").ModelParser>} */
+  $parsers: Array<import("./interface.ts").ModelParser>;
+  /** @type {Array<import("./interface.ts").ModelFormatter>} */
+  $formatters: Array<import("./interface.ts").ModelFormatter>;
+  /** @type {Array<import("./interface.ts").ModelViewChangeListener>} */
+  $viewChangeListeners: Array<import("./interface.ts").ModelViewChangeListener>;
   /** @type {boolean} */
   $untouched: boolean;
   /** @type {boolean} */
@@ -398,10 +398,12 @@ export class NgModelController {
    * **Note:** it is not possible to override the `getterSetter` option.
    * </div>
    *
-   * @param {Object} options a hash of settings to override the previous options
+   * @param {import("../../interface.ts").NgModelOptions} options a hash of settings to override the previous options
    *
    */
-  $overrideModelOptions(options: any): void;
+  $overrideModelOptions(
+    options: import("../../interface.ts").NgModelOptions,
+  ): void;
   /**
      * Runs the model -> view pipeline on the current
      * {@link ngModel.NgModelController#$modelValue $modelValue}.

@types/interface.d.ts

@@ -465,6 +465,24 @@ export type CloneAttachFunction = (
   clonedElement?: Element,
   scope?: Scope,
 ) => any;
+export interface TemplateLinkingFunction {
+  (
+    scope: ng.Scope,
+    cloneAttachFn?: CloneAttachFunction,
+    options?: TemplateLinkingFunctionOptions,
+  ): Element;
+}
+export interface TemplateLinkingFunctionOptions {
+  parentBoundTranscludeFn?: TranscludeFunctionObject | undefined;
+  transcludeControllers?:
+    | {
+        [controller: string]: {
+          instance: Controller;
+        };
+      }
+    | undefined;
+  futureParentElement?: Element | undefined;
+}
 /**
  * Configuration for ngModel behavior.
  */

@types/router/state/state-queue-manager.d.ts

@@ -2,29 +2,29 @@ export class StateQueueManager {
   /**
    * @param {import("./state-registry.js").StateRegistryProvider} stateRegistry
    * @param {import("../url/url-rules.js").UrlRules} urlServiceRules
-   * @param {import("./interface.js").StateStore} states
+   * @param {import("./interface.ts").StateStore} states
    * @param {*} builder
    * @param {*} listeners
    */
   constructor(
     stateRegistry: import("./state-registry.js").StateRegistryProvider,
     urlServiceRules: import("../url/url-rules.js").UrlRules,
-    states: import("./interface.js").StateStore,
+    states: import("./interface.ts").StateStore,
     builder: any,
     listeners: any,
   );
   stateRegistry: import("./state-registry.js").StateRegistryProvider;
   /** @type {import("../url/url-rules.js").UrlRules} */
   urlServiceRules: import("../url/url-rules.js").UrlRules;
-  states: import("./interface.js").StateStore;
+  states: import("./interface.ts").StateStore;
   builder: any;
   listeners: any;
   /**
    * @type {Array<StateObject>}
    */
   queue: Array<StateObject>;
   register(stateDecl: any): StateObject;
-  flush(): import("./interface.js").StateStore;
+  flush(): import("./interface.ts").StateStore;
   /**
    *
    * @param {ng.StateDeclaration} state

@types/services/http/http.d.ts

@@ -23,27 +23,7 @@ export function defaultHttpResponseTransform(data: any, headers: any): any;
  */
 export function HttpProvider(): void;
 export class HttpProvider {
-  defaults: {
-    transformResponse: (typeof defaultHttpResponseTransform)[];
-    transformRequest: ((data: any) => any)[];
-    headers: {
-      common: {
-        Accept: string;
-      };
-      post: {
-        "Content-Type": string;
-      };
-      put: {
-        "Content-Type": string;
-      };
-      patch: {
-        "Content-Type": string;
-      };
-    };
-    xsrfCookieName: string;
-    xsrfHeaderName: string;
-    paramSerializer: string;
-  };
+  defaults: import("./interface.ts").HttpProviderDefaults;
   /**
    * Configure $http service to combine processing of multiple http responses received at around
    * the same time via {@link ng.$rootScope.Scope#$applyAsync $rootScope.$applyAsync}. This can result in
@@ -68,8 +48,11 @@ export class HttpProvider {
    * array, on request, but reverse order, on response.
    *
    * {@link ng.$http#interceptors Interceptors detailed info}
+   * @type {Array<string | ng.Injectable<import("./interface.ts").HttpInterceptorFactory>>}
    */
-  interceptors: any[];
+  interceptors: Array<
+    string | ng.Injectable<import("./interface.ts").HttpInterceptorFactory>
+  >;
   /**
    * Array containing URLs whose origins are trusted to receive the XSRF token. See the
    * {@link ng.$http#security-considerations Security Considerations} sections for more details on
@@ -124,27 +107,7 @@ export class HttpProvider {
          *
          * See "Setting HTTP Headers" and "Transforming Requests and Responses" sections above.
          */
-        defaults: {
-          transformResponse: (typeof defaultHttpResponseTransform)[];
-          transformRequest: ((data: any) => any)[];
-          headers: {
-            common: {
-              Accept: string;
-            };
-            post: {
-              "Content-Type": string;
-            };
-            put: {
-              "Content-Type": string;
-            };
-            patch: {
-              "Content-Type": string;
-            };
-          };
-          xsrfCookieName: string;
-          xsrfHeaderName: string;
-          paramSerializer: string;
-        };
+        defaults: import("./interface.ts").HttpProviderDefaults;
       })
   )[];
 }

@types/services/http/interface.d.ts

@@ -4,6 +4,14 @@ export interface HttpHeadersGetter {
   };
   (headerName: string): string;
 }
+export interface HttpPromiseCallback<T> {
+  (
+    data: T,
+    status: number,
+    headers: HttpHeadersGetter,
+    config: RequestConfig,
+  ): void;
+}
 export interface HttpRequestConfigHeaders {
   [requestType: string]: any;
   common?: any;
@@ -18,6 +26,9 @@ export interface HttpRequestTransformer {
 export interface HttpResponseTransformer {
   (data: any, headersGetter: HttpHeadersGetter, status: number): any;
 }
+export interface HttpHeaderType {
+  [requestType: string]: string | ((config: RequestConfig) => string);
+}
 /**
  * Object that controls the defaults for $http provider. Not all fields of RequestShortcutConfig can be configured
  * via defaults and the docs do not say which. The following is based on the inspection of the source code.
@@ -228,3 +239,14 @@ export type HttpParams = Record<
  * A function that serializes an object into a URL-encoded query string.
  */
 export type HttpParamSerializer = (params?: HttpParams) => string;
+export interface HttpInterceptor {
+  request?(config: RequestConfig): RequestConfig | Promise<RequestConfig>;
+  requestError?(rejection: any): RequestConfig | Promise<RequestConfig>;
+  response?<T>(
+    response: HttpResponse<T>,
+  ): Promise<HttpResponse<T>> | HttpResponse<T>;
+  responseError?<T>(rejection: any): Promise<HttpResponse<T>> | HttpResponse<T>;
+}
+export interface HttpInterceptorFactory {
+  (...args: any[]): HttpInterceptor;
+}