New typecheck settings

Author: Anatoly Ostrovsky

.husky/pre-commit

@@ -1,5 +1,4 @@
 make lint
-make check
 make types
 make pretty
 git add ./

@types/angular.d.ts

@@ -12,22 +12,19 @@ export class Angular {
   /**
    * Gets the controller instance for a given element, if exists. Defaults to "ngControllerController"
    *
-   * @type {(element: Element, name: string?) => ng.Scope|undefined}
+   * @type {(element: Element, name?: string) => ng.Scope|undefined}
    */
-  getController: (
-    element: Element,
-    name: string | null,
-  ) => ng.Scope | undefined;
+  getController: (element: Element, name?: string) => ng.Scope | undefined;
   /**
    * Return instance of InjectorService attached to element
-   * @type {(Element) => ng.InjectorService}
+   * @type {typeof getInjector}
    */
-  getInjector: (Element: any) => ng.InjectorService;
+  getInjector: typeof getInjector;
   /**
    * Gets scope for a given element.
-   * @type {(Element) => ng.Scope}
+   *  @type {typeof getScope}
    */
-  getScope: (Element: any) => ng.Scope;
+  getScope: typeof getScope;
   errorHandlingConfig: typeof errorHandlingConfig;
   $t: Readonly<Record<string, string>>;
   /**
@@ -158,5 +155,10 @@ export class Angular {
    */
   getScopeByName(name: string): ProxyHandler<ng.Scope> | undefined;
 }
+export type ModuleRegistry = {
+  [x: string]: NgModule;
+};
+import { getInjector } from "./shared/dom.js";
+import { getScope } from "./shared/dom.js";
 import { errorHandlingConfig } from "./shared/utils.js";
 import { NgModule } from "./core/di/ng-module/ng-module.js";

@types/core/scope/scope.d.ts

@@ -62,7 +62,7 @@ export class Scope {
     }
   >;
   /** Current proxy being operated on */
-  $proxy: any;
+  $proxy: ProxyConstructor | ng.Scope;
   /** @type {Scope} The actual proxy */
   $handler: Scope;
   /** @type {*} Current target being called on */

@types/directive/ref/ref.d.ts

@@ -1,11 +1,8 @@
-export function ngRefDirective($parse: any): {
-  priority: number;
-  restrict: string;
-  compile(
-    tElement: any,
-    tAttrs: any,
-  ): (scope: any, element: any, attrs: any) => void;
-};
+/**
+ * @param {ng.ParseService} $parse
+ * @return {ng.Directive}
+ */
+export function ngRefDirective($parse: ng.ParseService): ng.Directive;
 export namespace ngRefDirective {
   let $inject: string[];
 }

@types/interface.d.ts

@@ -358,8 +358,8 @@ export type DirectiveLinkFn<T> = (
  * A compile function used to prepare directives before linking.
  */
 export type DirectiveCompileFn = (
-  templateElement?: HTMLElement,
-  templateAttributes?: Attributes & Record<string, any>,
+  templateElement: HTMLElement,
+  templateAttributes: Attributes & Record<string, any>,
   transclude?: (...args: any[]) => any,
 ) => void | DirectiveLinkFn<any> | DirectivePrePost;
 /**

@types/namespace.d.ts

@@ -95,6 +95,8 @@ import { AnimateProvider as TAnimateProvider } from "./animations/animate.js";
 import { UrlService as TUrlService } from "./router/url/url-service.js";
 import { LocationProvider as TLocationProvider } from "./services/location/location.js";
 import { ViewService as TViewService } from "./router/view/view.js";
+import { StateDeclaration as TStateDeclaration } from "./router/state/interface.ts";
+import { StateObject as TStateObject } from "./router/state/state-object.js";
 declare global {
   interface Function {
     $inject?: readonly string[] | undefined;
@@ -182,5 +184,7 @@ declare global {
     type Expression = TExpression;
     type NgModelController = TNgModelController;
     type Validator = TValidator;
+    type StateDeclaration = TStateDeclaration;
+    type StateObject = TStateObject;
   }
 }

@types/router/state/state-builder.d.ts

@@ -38,8 +38,9 @@
  *   new Resolvable("myBarResolve", function(dep) { return dep.fetchSomethingAsPromise() }, [ "DependencyName" ]),
  *   { provide: "myBazResolve", useFactory: function(dep) { dep.fetchSomethingAsPromise() }, deps: [ "DependencyName" ] }
  * ]
+ * @param {ng.StateObject} state
  */
-export function resolvablesBuilder(state: any): any[];
+export function resolvablesBuilder(state: ng.StateObject): any[];
 /**
  * A internal global service
  *

@types/router/state/state-object.d.ts

@@ -24,9 +24,9 @@ export class StateObject implements StateDeclaration {
   includes: any;
   $$state: () => this;
   /**
-   * @type {import('./interface.ts').StateDeclaration}
+   * @type {ng.StateDeclaration}
    */
-  self: import("./interface.ts").StateDeclaration;
+  self: ng.StateDeclaration;
   __stateObjectCache: {
     nameGlob: Glob;
   };

@types/router/state/state-queue-manager.d.ts

@@ -2,28 +2,28 @@ export class StateQueueManager {
   /**
    * @param {import("./state-registry.js").StateRegistryProvider} stateRegistry
    * @param {*} urlServiceRules
-   * @param {*} states
+   * @param {Record<string, ng.StateObject>} states
    * @param {*} builder
    * @param {*} listeners
    */
   constructor(
     stateRegistry: import("./state-registry.js").StateRegistryProvider,
     urlServiceRules: any,
-    states: any,
+    states: Record<string, ng.StateObject>,
     builder: any,
     listeners: any,
   );
   stateRegistry: import("./state-registry.js").StateRegistryProvider;
   urlServiceRules: any;
-  states: any;
+  states: Record<string, StateObject>;
   builder: any;
   listeners: any;
   /**
    * @type {Array<StateObject>}
    */
   queue: Array<StateObject>;
   register(stateDecl: any): StateObject;
-  flush(): any;
+  flush(): Record<string, StateObject>;
   attachRoute(state: any): void;
 }
 import { StateObject } from "./state-object.js";

@types/router/state/state-registry.d.ts

@@ -8,20 +8,21 @@
 export class StateRegistryProvider {
   static $inject: string[];
   /**
-   * @param urlService
-   * @param stateService
-   * @param {import('../router.js').RouterProvider} globals
-   * @param viewService
+   * @param {ng.UrlService} urlService
+   * @param {ng.StateService} stateService
+   * @param {ng.RouterService} globals
+   * @param {ng.ViewService} viewService
    */
   constructor(
-    urlService: any,
-    stateService: any,
-    globals: import("../router.js").RouterProvider,
-    viewService: any,
+    urlService: ng.UrlService,
+    stateService: ng.StateService,
+    globals: ng.RouterService,
+    viewService: ng.ViewService,
   );
-  states: {};
-  urlService: any;
-  urlServiceRules: any;
+  /** @type {Record<string, import("./state-object.js").StateObject>} */
+  states: Record<string, import("./state-object.js").StateObject>;
+  urlService: import("../url/url-service.js").UrlService;
+  urlServiceRules: import("../url/url-rules.js").UrlRules;
   $injector: any;
   listeners: any[];
   matcher: StateMatcher;
@@ -110,6 +111,10 @@ export class StateRegistryProvider {
    * @returns {import('./state-object').StateObject[]} a list of removed states
    */
   deregister(stateOrName: any): any[];
+  /**
+   * @return {ng.StateDeclaration[]}
+   */
+  getAll(): ng.StateDeclaration[];
   get(stateOrName: any, base: any, ...args: any[]): any;
   /**
    * Registers a [[BuilderFunction]] for a specific [[StateObject]] property (e.g., `parent`, `url`, or `path`).