Normalize name

Author: tolyo

src/directive/observe/observe.js

@@ -1,4 +1,4 @@
-import { isUndefined } from "../../shared/utils.js";
+import { kebabToCamel } from "../../shared/jqlite/jqlite.js";
 
 /**
  * @param {string} source - the name of the attribute to be observed
@@ -10,20 +10,21 @@ export function ngObserveDirective(source, prop) {
     restrict: "A",
     compile: () => (scope, element) => {
       const targetElement = element[0];
-      if (isUndefined(prop) || prop == "") {
+      if (prop === "") {
         prop = source;
       }
-      if (!scope[prop]) {
-        scope[prop] = targetElement.getAttribute(source);
+      const normalized = kebabToCamel(prop);
+      if (!scope[normalized]) {
+        scope[normalized] = targetElement.getAttribute(source);
       }
 
       const observer = new MutationObserver((mutations) => {
         const mutation = mutations[0];
         const newValue = /** @type {HTMLElement} */ (
           mutation.target
         ).getAttribute(source);
-        if (scope[prop] !== newValue) {
-          scope[prop] = newValue;
+        if (scope[normalized] !== newValue) {
+          scope[normalized] = newValue;
           scope.$digest();
         }
       });

src/directive/observe/observe.spec.js

@@ -89,7 +89,7 @@ describe("observe", () => {
   });
 
   it("should observe attribute changes and update the same scope name if data-update attribute is absent", () => {
-    $scope.myProp = "";
+    $scope.testAttribute = "";
     const template = `<div ng-observe-test-attribute></div>`;
     element = $compile(template)($scope);
     $scope.$digest();
@@ -107,5 +107,6 @@ describe("observe", () => {
 
     mutationObserverCallback([mutationRecord]);
     expect($scope.$digest).toHaveBeenCalled();
+    expect($scope.testAttribute).toBe("newValue");
   });
 });