Skip to content

Commit cd9a1eb

Browse files
committed
Revert check on husky
1 parent 8264ba5 commit cd9a1eb

File tree

11 files changed

+34
-31
lines changed

11 files changed

+34
-31
lines changed

.husky/pre-commit

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
1-
1+
make lint
2+
make check
3+
make types
4+
make pretty
25
git add ./

@types/core/di/ng-module/ng-module.d.ts

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
/** @private */
2-
export const INJECTOR_LITERAL: "$injector";
3-
/** @private */
42
export const COMPILE_LITERAL: "$compileProvider";
53
/** @private */
64
export const ANIMATION_LITERAL: "$animateProvider";
@@ -13,10 +11,6 @@ export const CONTROLLER_LITERAL: "$controllerProvider";
1311
* controllers, directives, filters, etc. They provide recipes for the injector
1412
* to do the actual instantiation. A module itself has no behaviour but only state.
1513
* A such, it acts as a data structure between the Angular instance and the injector service.
16-
*
17-
* Since this is an internal structure that is exposed only via the Angular instance,
18-
* it contains no validation of the items it receives. It is up to the instantiator on
19-
* modules to do the actual validation.
2014
*/
2115
export class NgModule {
2216
/**
@@ -49,7 +43,6 @@ export class NgModule {
4943
/** @type {!Array.<ng.Injectable<any>>} */
5044
runBlocks: Array<ng.Injectable<any>>;
5145
services: any[];
52-
wasmModules: any[];
5346
restDefinitions: any[];
5447
/**
5548
* @param {string} name
@@ -123,11 +116,17 @@ export class NgModule {
123116
*/
124117
filter(name: string, filterFn: ng.Injectable<any>): NgModule;
125118
/**
126-
* @param {string} name
127-
* @param {ng.Injectable<any>} ctlFn
119+
* The $controller service is used by Angular to create new controllers.
120+
* This provider allows controller registration via the register method.
121+
*
122+
* @param {string} name Controller name
123+
* @param {ng.Injectable<ng.ControllerConstructor>} ctlFn Controller constructor fn (optionally decorated with DI annotations in the array notation)
128124
* @returns {NgModule}
129125
*/
130-
controller(name: string, ctlFn: ng.Injectable<any>): NgModule;
126+
controller(
127+
name: string,
128+
ctlFn: ng.Injectable<ng.ControllerConstructor>,
129+
): NgModule;
131130
/**
132131
* Register a named WebAssembly module that will be instantiated via $provide.
133132
*

@types/core/scope/scope.d.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,16 @@ export function nextId(): number;
1010
*/
1111
export function createScope(target?: any, context?: Scope): Scope;
1212
/**
13+
* @ignore
14+
* Checks if a target should be excluded from scope observability
1315
* @param {any} target
1416
* @returns {boolean}
1517
*/
16-
export function isUnsafeGlobal(target: any): boolean;
18+
export function isNonScope(target: any): boolean;
19+
/**
20+
* Decorator for excluding objects from scope observability
21+
*/
22+
export const NONSCOPE: "$nonscope";
1723
export const $postUpdateQueue: any[];
1824
export let rootScope: any;
1925
export class RootScopeProvider {
@@ -26,10 +32,6 @@ export class RootScopeProvider {
2632
) => Scope)
2733
)[];
2834
}
29-
/**
30-
* Decorator for excluding objects from scope observability
31-
*/
32-
export const NONSCOPE: "$nonscope";
3335
/**
3436
* Scope class for the Proxy. It intercepts operations like property access (get)
3537
* and property setting (set), and adds support for deep change tracking and
@@ -84,8 +86,6 @@ export class Scope {
8486
*/
8587
$root: Scope;
8688
$parent: Scope;
87-
/** @type {import('./interface.ts').AsyncQueueTask[]} */
88-
$$asyncQueue: import("./interface.ts").AsyncQueueTask[];
8989
filters: any[];
9090
/** @type {boolean} */
9191
$$destroyed: boolean;

@types/directive/style/style.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
/**
2-
* @returns {import('../../interface.ts').Directive}
2+
* @returns {ng.Directive}
33
*/
4-
export function ngStyleDirective(): import("../../interface.ts").Directive;
4+
export function ngStyleDirective(): ng.Directive;

@types/namespace.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ import {
4040
DirectiveFactory as TDirectiveFactory,
4141
Component as TComponent,
4242
Controller as TController,
43+
ControllerConstructor as TControllerConstructor,
4344
Injectable as TInjectable,
4445
} from "./interface.ts";
4546
import {
@@ -149,6 +150,7 @@ declare global {
149150
type StorageType = TStorageType;
150151
type StreamConnectionConfig = TStreamConnectionConfig;
151152
type CookieOptions = TCookieOptions;
153+
type ControllerConstructor = TControllerConstructor;
152154
type CookieStoreOptions = TCookieStoreOptions;
153155
type RestService<T, ID> = TRestService<T, ID>;
154156
type RestDefinition<T> = TRestDefinition<T>;

@types/services/cookie/cookie.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export class CookieService {
3434
*
3535
* @param {string} key
3636
* @returns {string|null}
37+
* @throws {URIError} – If decodeURIComponent fails.
3738
*/
3839
get(key: string): string | null;
3940
/**
@@ -49,6 +50,7 @@ export class CookieService {
4950
* Returns an object containing all raw cookies.
5051
*
5152
* @returns {Record<string, string>}
53+
* @throws {URIError} – If decodeURIComponent fails
5254
*/
5355
getAll(): Record<string, string>;
5456
/**

@types/services/exception/exception.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
* }
3838
* ```
3939
*
40-
* @see {@link ng.ExceptionHandlerService ExceptionHandlerService}
40+
* @see {@link ng.ExceptionHandlerService} ExceptionHandlerService
4141
*/
4242
/**
4343
* Provider for the `$exceptionHandler` service.

@types/services/http/http.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ export class HttpProvider {
108108
| ((
109109
$injector: ng.InjectorService,
110110
$sce: any,
111+
$cookie: ng.CookieService,
111112
) => {
112113
(requestConfig: any): Promise<any>;
113114
pendingRequests: any[];

@types/services/pubsub/pubsub.d.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export class PubSubProvider {
1515
$get: () => PubSub;
1616
}
1717
export class PubSub {
18+
static $nonscope: any;
1819
/**
1920
* Runs a function asynchronously.
2021
*
@@ -153,7 +154,7 @@ export class PubSub {
153154
* the order in which they were added, passing all arguments along.
154155
*
155156
* If this object was created with async=true, subscribed functions are called
156-
* via Promise.resolve(). Otherwise, the functions are called directly, and if
157+
* via `queueMicrotask`. Otherwise, the functions are called directly, and if
157158
* any of them throw an uncaught error, publishing is aborted.
158159
*
159160
* @param {string} topic Topic to publish to.

@types/services/rest/rest.d.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,14 @@ export class RestService<T, ID> {
99
*
1010
* @param {ng.HttpService} $http Angular-like $http service
1111
* @param {string} baseUrl Base URL or URI template
12-
* @param {{new(data: any): T}=} entityClass Optional constructor to map JSON to objects
13-
* @param {Object=} options Optional settings (interceptors, headers, etc.)
12+
* @param {ng.EntityClass<T>} [entityClass] Optional constructor to map JSON to objects
13+
* @param {Object} [options] Optional settings (interceptors, headers, etc.)
1414
*/
1515
constructor(
1616
$http: ng.HttpService,
1717
baseUrl: string,
18-
entityClass?:
19-
| {
20-
new (data: any): T;
21-
}
22-
| undefined,
23-
options?: any | undefined,
18+
entityClass?: ng.EntityClass<T>,
19+
options?: any,
2420
);
2521
/** @private */
2622
private $http;

0 commit comments

Comments
 (0)