Lint fixes

Author: tolyo

src/core/parse/ast/ast.js

@@ -560,6 +560,8 @@ export class AST {
     } else {
       return /** @type  {import("../lexer/lexer.js").Token} */ (token);
     }
+
+    return undefined;
   }
 
   /**
@@ -597,10 +599,10 @@ export class AST {
     if (this.tokens.length > i) {
       const token = this.tokens[i];
 
-      const t = token.text;
+      const { text } = token;
 
       if (
-        expected.includes(t) ||
+        expected.includes(text) ||
         (!expected[0] && !expected[1] && !expected[2] && !expected[3])
       ) {
         return token;

src/core/scope/scope.js

@@ -97,7 +97,7 @@ export function createScope(target = {}, context) {
   return proxy;
 }
 
-const g = globalThis;
+const global = globalThis;
 
 const proto = Object.prototype;
 
@@ -115,10 +115,10 @@ export function isNonScope(target) {
   if (
     target[NONSCOPE] === true ||
     (target.constructor && target.constructor[NONSCOPE]) === true ||
-    target === g.window ||
-    target === g.document ||
-    target === g.self ||
-    target === g.frames ||
+    target === global.window ||
+    target === global.document ||
+    target === global.self ||
+    target === global.frames ||
     target instanceof Window ||
     target instanceof Document ||
     target instanceof Element ||
@@ -395,9 +395,9 @@ export class Scope {
             const keys = this.objectListeners.get(proxy);
 
             for (let i = 0, l = keys.length; i < l; i++) {
-              const listeners = this.watchers.get(keys[i]);
+              const currentListeners = this.watchers.get(keys[i]);
 
-              if (listeners) this.#scheduleListener(listeners);
+              if (currentListeners) this.#scheduleListener(currentListeners);
             }
             decodeURI;
           }
@@ -618,9 +618,9 @@ export class Scope {
         for (let i = 0, l = keys.length; i < l; i++) {
           const key = keys[i];
 
-          const listeners = this.watchers.get(key);
+          const currentListeners = this.watchers.get(key);
 
-          if (listeners) this.#scheduleListener(listeners);
+          if (currentListeners) this.#scheduleListener(currentListeners);
         }
       }
 
@@ -1141,8 +1141,8 @@ export class Scope {
   $apply(expr) {
     try {
       return $parse(expr)(this.$proxy);
-    } catch (e) {
-      $exceptionHandler(e);
+    } catch (err) {
+      $exceptionHandler(err);
     }
   }
 
@@ -1370,8 +1370,8 @@ export class Scope {
 
         fn();
       }
-    } catch (e) {
-      $exceptionHandler(e);
+    } catch (err) {
+      $exceptionHandler(err);
     }
   }
 
@@ -1412,14 +1412,14 @@ export class Scope {
   }
 
   $searchByName(name) {
-    const getByName = (scope, name) => {
-      if (scope.$scopename === name) {
+    const getByName = (scope, nameParam) => {
+      if (scope.$scopename === nameParam) {
         return scope;
       } else {
         let res = undefined;
 
         for (const child of scope.$children) {
-          const found = getByName(child, name);
+          const found = getByName(child, nameParam);
 
           if (found) {
             res = found;

src/directive/aria/aria.js

@@ -20,6 +20,8 @@ const isNodeOneOf = function (elem, nodeTypeArray) {
   if (nodeTypeArray.indexOf(elem.nodeName) !== -1) {
     return true;
   }
+
+  return false;
 };
 
 /**
@@ -129,7 +131,7 @@ export function ngClickAriaDirective($aria, $parse) {
   return {
     restrict: "A",
     compile(_elem, attr) {
-      if (hasOwn(attr, ARIA_DISABLE_ATTR)) return;
+      if (hasOwn(attr, ARIA_DISABLE_ATTR)) return undefined;
 
       const fn = $parse(attr.ngClick);
 
@@ -268,7 +270,7 @@ export function ngModelAriaDirective($aria) {
     require: "ngModel",
     priority: 200, // Make sure watches are fired after any other directives that affect the ngModel value
     compile(_, attr) {
-      if (hasOwn(attr, ARIA_DISABLE_ATTR)) return;
+      if (hasOwn(attr, ARIA_DISABLE_ATTR)) return undefined;
 
       const shape = getShape(attr);
 

src/directive/input/input.js

@@ -130,7 +130,7 @@ function textInputType(scope, element, attr, ctrl) {
   stringBasedInputType(ctrl);
 }
 
-function baseInputType(scope, element, attr, ctrl) {
+function baseInputType(_, element, attr, ctrl) {
   const type = element.type.toLowerCase();
 
   let composing = false;
@@ -193,6 +193,7 @@ function baseInputType(scope, element, attr, ctrl) {
   ) {
     element.addEventListener(PARTIAL_VALIDATION_EVENTS, function (ev) {
       if (!timeout) {
+        // eslint-disable-next-line no-invalid-this
         const validity = this[VALIDITY_STATE_PROPERTY];
 
         const origBadInput = validity.badInput;
@@ -521,7 +522,7 @@ export function createDateInputType(type, regexp, parseDate) {
 
     function isValidDate(value) {
       // Invalid Date: getTime() returns NaN
-      return value && !(value.getTime && value.getTime() !== value.getTime());
+      return value && !(value.getTime && Number.isNaN(value.getTime()));
     }
 
     function parseObservedDateValue(val) {
@@ -963,10 +964,8 @@ function radioInputType(scope, element, attr, ctrl) {
   }
 
   const listener = function (ev) {
-    let value;
-
     if (element.checked) {
-      value = attr.value;
+      let { value } = attr;
 
       if (doTrim) {
         value = trim(value);
@@ -1108,7 +1107,7 @@ export function hiddenInputBrowserCacheDirective() {
       }
 
       return {
-        pre(scope, element) {
+        pre(_scope, element) {
           const node = element;
 
           // Support: Edge
@@ -1122,6 +1121,8 @@ export function hiddenInputBrowserCacheDirective() {
           if (Object.defineProperty) {
             Object.defineProperty(node, "value", valueProperty);
           }
+
+          return undefined;
         },
       };
     },

src/directive/messages/messages.js

@@ -171,6 +171,8 @@ class NgMessageCtrl {
         parentLookup.push(prevNode);
       }
     }
+
+    return undefined;
   }
 
   insertMessageNode(parent, comment, key) {
@@ -264,12 +266,12 @@ export const ngMessageDefaultDirective = ngMessageDirectiveFactory(true);
  * @returns {(any) => ng.Directive}
  */
 function ngMessageDirectiveFactory(isDefault) {
-  ngMessageDirective.$inject = ["$animate"];
+  ngMessageDirectiveFn.$inject = ["$animate"];
   /**
    * @param {ng.AnimateService} $animate
    * @returns {ng.Directive}
    */
-  function ngMessageDirective($animate) {
+  function ngMessageDirectiveFn($animate) {
     return {
       restrict: "AE",
       transclude: "element",
@@ -369,7 +371,7 @@ function ngMessageDirectiveFactory(isDefault) {
     };
   }
 
-  return ngMessageDirective;
+  return ngMessageDirectiveFn;
 }
 
 function contains(collection, key) {

src/directive/options/options.js

@@ -169,22 +169,22 @@ export function ngOptionsDirective($compile, $parse) {
 
           const value = optionValues[key];
 
-          const locals = getLocals(value, key);
+          const updatedLocals = getLocals(value, key);
 
-          const selectValue = getTrackByValueFn(value, locals);
+          const selectValue = getTrackByValueFn(value, updatedLocals);
 
           watchedArray.push(selectValue);
 
           // Only need to watch the displayFn if there is a specific label expression
           if (match[2] || match[1]) {
-            const label = displayFn(scope, locals);
+            const label = displayFn(scope, updatedLocals);
 
             watchedArray.push(label);
           }
 
           // Only need to watch the disableWhenFn if there is a specific disable expression
           if (match[4]) {
-            const disableWhen = disableWhenFn(scope, locals);
+            const disableWhen = disableWhenFn(scope, updatedLocals);
 
             watchedArray.push(disableWhen);
           }
@@ -214,17 +214,17 @@ export function ngOptionsDirective($compile, $parse) {
 
           const value = optionValues[key];
 
-          const locals = getLocals(value, key);
+          const updatedLocals = getLocals(value, key);
 
-          const viewValue = viewValueFn(scope, locals);
+          const viewValue = viewValueFn(scope, updatedLocals);
 
-          const selectValue = getTrackByValueFn(viewValue, locals);
+          const selectValue = getTrackByValueFn(viewValue, updatedLocals);
 
-          const label = displayFn(scope, locals);
+          const label = displayFn(scope, updatedLocals);
 
-          const group = groupByFn(scope, locals);
+          const group = groupByFn(scope, updatedLocals);
 
-          const disabled = disableWhenFn(scope, locals);
+          const disabled = disableWhenFn(scope, updatedLocals);
 
           const optionItem = new Option(
             selectValue,

src/router/state/state-registry.js

@@ -101,7 +101,7 @@ export class StateRegistryProvider {
           $transition$: trans,
         });
 
-        return that.$injector.invoke(hook, this, locals);
+        return that.$injector.invoke(hook, that, locals);
       }
 
       return hook ? decoratedNg1Hook : undefined;