Skip to content

Commit de2a935

Browse files
committed
Remove filter from inputs
1 parent f5e8adf commit de2a935

File tree

2 files changed

+6
-20
lines changed

2 files changed

+6
-20
lines changed

@types/directive/input/input.d.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export function numberInputType(
2424
element: any,
2525
attr: any,
2626
ctrl: any,
27-
$filter: any,
2827
$parse: any,
2928
): void;
3029
export function rangeInputType(
@@ -34,14 +33,10 @@ export function rangeInputType(
3433
ctrl: any,
3534
): void;
3635
/**
37-
* @param {ng.FilterFactory} $filter
3836
* @param {ng.ParseService} $parse
3937
* @returns {ng.Directive}
4038
*/
41-
export function inputDirective(
42-
$filter: ng.FilterFactory,
43-
$parse: ng.ParseService,
44-
): ng.Directive;
39+
export function inputDirective($parse: ng.ParseService): ng.Directive;
4540
export namespace inputDirective {
4641
let $inject: string[];
4742
}

src/directive/input/input.js

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -206,14 +206,7 @@ function baseInputType(_, element, attr, ctrl) {
206206
* @returns {*}
207207
*/
208208
export function createStringDateInputType(type, regexp) {
209-
return function stringDateInputType(
210-
scope,
211-
element,
212-
attr,
213-
ctrl,
214-
$filter,
215-
$parse,
216-
) {
209+
return function stringDateInputType(scope, element, attr, ctrl, $parse) {
217210
baseInputType(scope, element, attr, ctrl);
218211
ctrl.$parsers.push((value) => {
219212
if (ctrl.$isEmpty(value)) return null;
@@ -381,7 +374,7 @@ export function isValidForStep(viewValue, stepBase, step) {
381374
return (value - stepBase) % step === 0;
382375
}
383376

384-
export function numberInputType(scope, element, attr, ctrl, $filter, $parse) {
377+
export function numberInputType(scope, element, attr, ctrl, $parse) {
385378
badInputChecker(scope, element, attr, ctrl, "number");
386379
numberFormatterParser(ctrl);
387380
baseInputType(scope, element, attr, ctrl);
@@ -720,7 +713,7 @@ function parseConstantExpr($parse, context, name, expression, fallback) {
720713
return fallback;
721714
}
722715

723-
function checkboxInputType(scope, element, attr, ctrl, $filter, $parse) {
716+
function checkboxInputType(scope, element, attr, ctrl, $parse) {
724717
const trueValue = parseConstantExpr(
725718
$parse,
726719
scope,
@@ -759,14 +752,13 @@ function checkboxInputType(scope, element, attr, ctrl, $filter, $parse) {
759752
ctrl.$parsers.push((value) => (value ? trueValue : falseValue));
760753
}
761754

762-
inputDirective.$inject = [$injectTokens._filter, $injectTokens._parse];
755+
inputDirective.$inject = [$injectTokens._parse];
763756

764757
/**
765-
* @param {ng.FilterFactory} $filter
766758
* @param {ng.ParseService} $parse
767759
* @returns {ng.Directive}
768760
*/
769-
export function inputDirective($filter, $parse) {
761+
export function inputDirective($parse) {
770762
return {
771763
restrict: "E",
772764
require: ["?ngModel"],
@@ -778,7 +770,6 @@ export function inputDirective($filter, $parse) {
778770
element,
779771
attr,
780772
ctrls[0],
781-
$filter,
782773
$parse,
783774
);
784775
}

0 commit comments

Comments
 (0)